Re: [linux-next:master 4179/4667] drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:3301:3: error: call to undeclared function 'pci_prepare_ats'; ISO C99 and later do not support implicit function declarations

[Jason Gunthorpe <jgg@nvidia.com>]

On Wed, Aug 28, 2024 at 04:51:33PM +0200, Konrad Dybcio wrote:
> On 15.08.2024 12:09 AM, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   320eb81df4f6c1a1814fd02ebb4ba41eb80a3c7e
> > commit: 2665d975db35f124d47e9584d448a3fb4d54f225 [4179/4667] iommu: Allow ATS to work on VFs when the PF uses IDENTITY
> > config: arm64-randconfig-003-20240815 (https://download.01.org/0day-ci/archive/20240815/202408150626.4kndgpL3-lkp@intel.com/config)
> > compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project f86594788ce93b696675c94f54016d27a6c21d18)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240815/202408150626.4kndgpL3-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202408150626.4kndgpL3-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    In file included from drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:15:
> >    In file included from include/linux/crash_dump.h:5:
> >    In file included from include/linux/kexec.h:18:
> >    In file included from include/linux/vmcore_info.h:6:
> >    In file included from include/linux/elfcore.h:11:
> >    In file included from include/linux/ptrace.h:10:
> >    In file included from include/linux/pid_namespace.h:7:
> >    In file included from include/linux/mm.h:2228:
> >    include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
> >      514 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
> >          |                               ~~~~~~~~~~~ ^ ~~~
> >>> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:3301:3: error: call to undeclared function 'pci_prepare_ats'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> >     3301 |                 pci_prepare_ats(to_pci_dev(dev), stu);
> >          |                 ^
> >    drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:3301:3: note: did you mean 'pci_enable_ats'?
> >    include/linux/pci-ats.h:18:19: note: 'pci_enable_ats' declared here
> >       18 | static inline int pci_enable_ats(struct pci_dev *d, int ps)
> >          |                   ^
> >    1 warning and 1 error generated.
> > 
> > 
> > vim +/pci_prepare_ats +3301 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> 
> Hi, this is still an issue on next-20240826

https://patch.msgid.link/r/0-v1-3ff295fa1528+d7-pci_prepare_ats_proto_jgg@nvidia.com

Joerg?

Jason