From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB078C7113C for ; Wed, 28 Aug 2024 21:39:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69C296B0089; Wed, 28 Aug 2024 17:39:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64B146B008A; Wed, 28 Aug 2024 17:39:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 512706B008C; Wed, 28 Aug 2024 17:39:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 324BF6B0089 for ; Wed, 28 Aug 2024 17:39:07 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B58041C0470 for ; Wed, 28 Aug 2024 21:39:06 +0000 (UTC) X-FDA: 82502969892.22.59EAA4D Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf02.hostedemail.com (Postfix) with ESMTP id DAC5780006 for ; Wed, 28 Aug 2024 21:39:03 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=S9rnW2mH; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724881099; a=rsa-sha256; cv=none; b=N4e8jbmlMk3YtnFiZdjXM6PKkDTXIqCbuz5PWecZpWzQgs2wlINiRpW+rirSpQ1Uyjqhtn /QEavVr8DBz8llEb5NOxZvPK1noADtRBTy2a63zERfd/v+Qch0W5wY4JZ8BhrnpCBZ/cgC scLETq3EKhrwJXxrAVIf5228JXnGfK4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=S9rnW2mH; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724881099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3QnW/GZRFR9SHgc3r/Tyncd5MzsS70+ue2dnnat703M=; b=nDREfEbW+hFOluGV7ddlZQX/25kQ5uaS3Ww5+AqQkBqpCAeRdB5HwTleox7FxqLK5jwwoy J53FofJSp2jWGYXiRKSNjKedCZ1A8Dx7lk7zKSZ2rmtpNyeE+aarbvWG6/T4Xq/XnOPyfr UXj80+T52SYP8tZjcugP4CalQ/Fmovk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 5BDA6AE3859; Wed, 28 Aug 2024 21:38:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F199CC4CEC0; Wed, 28 Aug 2024 21:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1724881141; bh=U5j/HWff1z275j88K6HFf95DiUEX3WN4z1hCAhIWKAg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=S9rnW2mHUcO8y2TKZ76XmYVkyK+PeEXVG+F9BeaT8lqElFH6D3JFksiBU1ELRGvH2 rl1d7CX3P/WTZhcCQ0wxeVfmZW18DNhz74Op6Q/ZUyW53hj6zgiCcYOkZ34z7ln9VB 0e2+gQLgz5AXf7gRk5xUJdGeXyJRVkXl6Hc0zUQE= Date: Wed, 28 Aug 2024 14:39:00 -0700 From: Andrew Morton To: Mateusz Guzik Cc: muchun.song@linux.dev, dave@stgolabs.net, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/hugetlb: sort out global lock annotations Message-Id: <20240828143900.d0fe36a6c05982159607fd3d@linux-foundation.org> In-Reply-To: References: <20240828160704.1425767-1-mjguzik@gmail.com> <20240828124929.db332259c2afad1e9e545b1f@linux-foundation.org> <20240828134435.443d7f7ec65eba1db4436434@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: yskfhk9a3y1e9r8dpih4z5o9yhopbzdy X-Rspamd-Queue-Id: DAC5780006 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724881143-969993 X-HE-Meta: U2FsdGVkX198de3Zujwe7aib6upPKTOb67Qy1cIYyWQRAf2yjOul+uFMDDV1O7TjjnghnGhWYjkPhDHUTM0ADuxQxaAWT5Qq9l5SvsS8IzMKT0PkxEc+cxFzxBAI7WRTBArDoGYLJpZCfqaam7p+N8CD4JR/VXNdCb5ywSROvC6ajVJwKQGhpe3Zm/xXqb+keXGT9jIrlTyrZEWUpOaE0wOqJTiKgXVfCZr5ed+OCvjOGyC+F2rK3r8PpPTqlateuGHEdlEsk2locrAQR3/YKLQcFo/RbH4ZCr8GpOKDVJHXyhfRKdJKzzUL6Excu2bvpW++bw8UE9AobJhzqnqkxs1qcbaS4ElWuB/OiAA6Y8mMwFxwWLQO+L8zw6qYfrOeN3+V1Lmf1TuntVqS/8tJNPBxFe3MnjaoSUEbnk/hUocfWoUp03BkmkxsrLe9DoLlbsVNfsT8h8KQdMz/zeYmrSwGevEslST8R9BSCA5Bbzh5J+14LfKWomyaMdzHO83S/pslcQxkVM1Lc0IGjvDmNUfuTP49ttDti8xCxRmxwnLlKu+uD99rO+EXlloyh5drZBLjv0HTl9u8Ycu+75aXhp6fw4KnYxUhZz3s5zj6+hhUp411L+b/z926eCuTv+S6j5KWiuH9vtz6juSiB7C0hy2c50Jo+YEOXt8dKUtLf3HsFuvtk/MPqx3jB3Q75NIErQo/P2LfKDIfqHfLp7PHwTX+YQxgiyHD+SbjGc1nODBUwiTNgvEpg8oR/cQY3+cAInQPBHtp3INtYzN2lIZ1bxDlr9gFpOxCOzxhNeoa3CX4iDbSKc5GSbdSVj6jQQUAyhon0tKNUIEeTxlEBwSyzfnAgbRsE+uXlfj9HMyYYvWN4FlKAB30vKXcdcSGD5+zSDJORhNKOL221Zfa8f/E1XkpviwMB/XguVybDgufaMrj2m93Meur2Wt2M3Usq7n0IDxrhs8emcQitzw16Q7 qdlBoGVU bcFfdtedm21WcHcAYPqqWT2y0PE+Z6K99ctp94XG5sF0Cqf+CHBXP0KCsM/oEZzc8y0fCG/ZxANSHONC/8FwddfL6daZbYFTZMDmFww9KKrd6MpUmke3J54hWNR4IUYtOFgbZdsy0m9IOZ71cOAspPwSHnk2q/PnAnnJvucNkhsKCKp8uL/F9WdGB92r0jc86OWQNZwRsqlhm9NcqSDE/Ivsxp6FGs6bSlNSHX7HSVT83mxyfI4Hsb4jNEJwMW+AcIVHKArtZJJbMZQbZvJxPSFdX3W3dZbVl6Sux X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 28 Aug 2024 23:02:39 +0200 Mateusz Guzik wrote: > > We'd need a new DEFINE_SPINLOCK_ALIGNED() or something. > > > > Ho hum, I'll fix. > > that would be a nice addition > > so as is this triviality grew to 3 patches which I consider rather > extreme, and the middle one breaks the build > > In the vfs land this would get squashed into one commit with a > maintainer note that some tweaking was performed, which I would > suggest here Yep. In mm land they get piled up as base+fix+fix-2 etc and then squashed before being moved into mm.git's non-rebasing mm-stable branch. > alternatively, given the trivial nature of the entire thing, if you > add DEFINE_SPINLOCK_ALIGNED and do the annotation tweak, you may as > well commit this as your own patch. I don't need any credit eh, it's very minor.