From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F062C5472F for ; Tue, 27 Aug 2024 16:04:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C38766B008C; Tue, 27 Aug 2024 12:04:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBFC06B0092; Tue, 27 Aug 2024 12:04:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A607A6B0093; Tue, 27 Aug 2024 12:04:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 833D16B008C for ; Tue, 27 Aug 2024 12:04:08 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2F75541A97 for ; Tue, 27 Aug 2024 16:04:08 +0000 (UTC) X-FDA: 82498496976.05.4D9A1B4 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by imf17.hostedemail.com (Postfix) with ESMTP id AA20240019 for ; Tue, 27 Aug 2024 16:04:04 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OWc9dJ5y; spf=pass (imf17.hostedemail.com: domain of lkp@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724774602; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jb3n6obEnvFJUuU//zpAaUWeUibC5AZ7lAK1LPV3ZgQ=; b=TVe+DFOqNoZ/X73yk5DrGBXU6uBLC8LZfYVYQ6j11h4fofm+zRWbjYWXKvTI5DdPspBQgY SBF/sbOxFdi+oZbDm/ztl5PeGll2dyA5TV6J18ItVVqyCPTp9eLxKWqCvY5AcH6jsDcCVO hnB06DKuRNajGu5+sSrlOQJoCifWLMQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OWc9dJ5y; spf=pass (imf17.hostedemail.com: domain of lkp@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724774602; a=rsa-sha256; cv=none; b=4tUN0UXpTnJsFrJZ75HAz9m5bmvbvKS9VgdjEfuLcWG2N5MKeejtQHnvLTHVXwbwbnt+aR jTNmmwmn28HP0zt2RD51OSSubJLmSfY6pFRxY7B1dIoJ+zjOJspMuHZNCmcOAlw6KKseN0 FquPNYlerU0XFSQn4r2Tohy7zriqTqc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724774645; x=1756310645; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ao0RX5ro/6ez3vKUPCpFiFkR1VW7QTBa5WWL6WRZhY8=; b=OWc9dJ5yhHSwOWEZDwoYpi3kRA1ZMivf3TBmQI7Ll6SNfbxis+O1EQD+ 5vfhUBLvzI8DiV0X18KK4eTV4NP1tb05oo0sLzTCyQ1ck/2+Uqh5/56/Q cQl7EUdKuUfSwDbNyfQtdZWqlqsbf3xuO5U6F98A37x3xCEfoNlwqlv0K lWL+9Lrdg3QoemwJhe2QDaS/43DzNU18Xi2Yi0ZcapNesjTTad/Nz09Yy XiN+hbKrLAXVmT5o595YFbtmhQ2GiuHE1S1PC7/mnf1oldvXLrLwEnbjP ly/ASxPfYQ7woO8/qv4DVbJLD2Cp7zeidp2nfSppYwQ7XACeD45IDPn6T w==; X-CSE-ConnectionGUID: n3kbpYuORG2TwmspLEHF6A== X-CSE-MsgGUID: Im3JyEC+St+iQYTX8Nov4g== X-IronPort-AV: E=McAfee;i="6700,10204,11177"; a="40736296" X-IronPort-AV: E=Sophos;i="6.10,180,1719903600"; d="scan'208";a="40736296" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2024 09:04:03 -0700 X-CSE-ConnectionGUID: tzVhxsI0SNCeFoPEq+h/sw== X-CSE-MsgGUID: QS6uijy3TGulNDeXCOoRGg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,180,1719903600"; d="scan'208";a="93634623" Received: from lkp-server01.sh.intel.com (HELO 9a732dc145d3) ([10.239.97.150]) by orviesa002.jf.intel.com with ESMTP; 27 Aug 2024 09:03:59 -0700 Received: from kbuild by 9a732dc145d3 with local (Exim 4.96) (envelope-from ) id 1siyfj-000Jny-1n; Tue, 27 Aug 2024 16:03:55 +0000 Date: Wed, 28 Aug 2024 00:03:19 +0800 From: kernel test robot To: Shakeel Butt , Andrew Morton Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , David Rientjes , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Eric Dumazet , "David S . Miller" , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v1] memcg: add charging of already allocated slab objects Message-ID: <202408272341.k4cl3jz0-lkp@intel.com> References: <20240826232908.4076417-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240826232908.4076417-1-shakeel.butt@linux.dev> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: AA20240019 X-Stat-Signature: iirfgekt3mtrd3jby7zdgspaw3ijshxp X-HE-Tag: 1724774644-126946 X-HE-Meta: U2FsdGVkX19qaI3dOzRoKoFwYU6fYhqXHmKmfZDCdDUJPrjeNLfon0WRHV0r4f5yK0xF1fWxuJTwoIKjwap9mGEpcvrzAEDul5K/6S8baEZGir1GVihiyi97GzampEW+dZcfXuxHvb0flQE5/L12eenasBORcLZ229/4sMj4UGZK/ns5AFyTBZ1PUv/9inwHNGryTa9kVPg5D5XvK/1t7k32UzobShvijtpyVYSpgAB0a+CMT4wzKLAdMAJyX/cJIse7ZgFIlV7nN7j2rP4/LF6PQIYYfNpeU+2TvQgSd6MixjFHDjasAuGgoUnYCxQbXnWTJtJK5MdgDdxQnOWDsVUmnu6FC9MYQTpQOSlJlLKoIIoy1bSGZc2blpCget/QhGRezmPbqvBT7i7gR1eN1yGw/B65ryt8HH1O5tcgCpPfj3wPRUWWA3JJuo5jrarePPH+D6x18UAqk2LGf1caS5A5FhzWtzsMBmUvgFK3c5/mRyXO19UmtOsdYlnH86MHli0pl+e9ZfYquYfNVPWBV+g4sEcTVEg7/wZB/U73huUlq5dCCcbZnk1vSbliTKQosRz5Y4Pu2vQ57WWTnX/bxGWXHgHyYNwJyyeIkvWFL3XU+E9c85jxmc8Yjzz8DOsN/5qWdEOIADwpG2+H++po/kTIJ77f5+6lE5shR6CYtN3qZLPDyoprZR+uWnmSFoxfSraQT4XyCkWZWkCE7BgwFnI0bVtUVOSVAiBak9Fyw1CY7ZXHfzchNNgifE9yS65A/1/y7NTcjCfmdm8AhIcPCHtA4Z4Cd9ZvZ7tpNfb1ty6vWWR/iu/XN3+rmcR6R4Jdo4Tz7pGSb6DCTMxhpxGxGtnjQ/xXchlhz0bfo5iYWRN3LfW2f2TekM6K8JCxyDQBZ6Jyg8/Qzo3Xsf4nLsyCo/f+tIEO40xgvY5HzszaWdiSgrEGybKElircYPzr5xSU85WNtYW8LAEUMpu6Zp3 /xS/w7OH 6oJsFXZ1vJlbVVlYDpnf1l9abNauBl3kwn8a+3TvZedn5fk5yN3hAeXGU171kqMg14adZixOV2f1bHYNII+cTOTbg+h/Ge3HhOZqNJMcgPgHR4Uci60ldcU3fHvuOvWNBisi5L3RQvj/XIY+q3SCQ5wz+0hdzjDibiVmTzpYTJySvoC6663j7EQcAfI/U1rYhASBYI8UbM9z7kj5de8ownnIr2n3nCXktT2gxYSz4b1VWsdhdD8PkbeH3F+m5PR5GHYO+rO1LcGD55J4pn+7aswSpZC8i0ExsGJr13j0UyFFm8vlD4jyP/pfEDmjH5hxysmyHEQVyoYbh4qUsuGSbf2HgkNdgXUGY+cvvHN0w7Kt9llg3NhgspvdYRaawFaHmxQnMM0tyZHEA3VoIkzSQRIKrHQi3YdpW6vH4kQgUrb2bNLviFB8556Lt2S35cVLXSwxJYcUx0++mbX/GeQ011dpjCRm2ndyCJR5ttOwpJpS8paNKtDwuSnQ4hw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Shakeel, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master v6.11-rc5 next-20240827] [cannot apply to vbabka-slab/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Shakeel-Butt/memcg-add-charging-of-already-allocated-slab-objects/20240827-073150 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20240826232908.4076417-1-shakeel.butt%40linux.dev patch subject: [PATCH v1] memcg: add charging of already allocated slab objects config: s390-allnoconfig (https://download.01.org/0day-ci/archive/20240827/202408272341.k4cl3jz0-lkp@intel.com/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 08e5a1de8227512d4774a534b91cb2353cef6284) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240827/202408272341.k4cl3jz0-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202408272341.k4cl3jz0-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from mm/slub.c:13: In file included from include/linux/mm.h:2198: include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ In file included from mm/slub.c:49: In file included from mm/internal.h:13: include/linux/mm_inline.h:47:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 47 | __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~ ^ ~~~ include/linux/mm_inline.h:49:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 49 | NR_ZONE_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~~~~~~ ^ ~~~ >> mm/slub.c:4115:31: error: no member named 'objcg' in 'struct slabobj_ext' 4115 | if (unlikely(slab_exts[off].objcg)) | ~~~~~~~~~~~~~~ ^ include/linux/compiler.h:77:42: note: expanded from macro 'unlikely' 77 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ 3 warnings and 1 error generated. vim +4115 mm/slub.c 4085 4086 #define KMALLOC_TYPE (SLAB_KMALLOC | SLAB_CACHE_DMA | \ 4087 SLAB_ACCOUNT | SLAB_RECLAIM_ACCOUNT) 4088 4089 bool kmem_cache_charge(void *objp, gfp_t gfpflags) 4090 { 4091 struct slabobj_ext *slab_exts; 4092 struct kmem_cache *s; 4093 struct folio *folio; 4094 struct slab *slab; 4095 unsigned long off; 4096 4097 if (!memcg_kmem_online()) 4098 return true; 4099 4100 folio = virt_to_folio(objp); 4101 if (unlikely(!folio_test_slab(folio))) 4102 return false; 4103 4104 slab = folio_slab(folio); 4105 s = slab->slab_cache; 4106 4107 /* Ignore KMALLOC_NORMAL cache to avoid circular dependency. */ 4108 if ((s->flags & KMALLOC_TYPE) == SLAB_KMALLOC) 4109 return true; 4110 4111 /* Ignore already charged objects. */ 4112 slab_exts = slab_obj_exts(slab); 4113 if (slab_exts) { 4114 off = obj_to_index(s, slab, objp); > 4115 if (unlikely(slab_exts[off].objcg)) 4116 return true; 4117 } 4118 4119 return memcg_slab_post_charge(s, objp, gfpflags); 4120 } 4121 EXPORT_SYMBOL(kmem_cache_charge); 4122 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki