From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99090C5472F for ; Tue, 27 Aug 2024 13:41:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 143816B0083; Tue, 27 Aug 2024 09:41:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CC176B0085; Tue, 27 Aug 2024 09:41:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAE8E6B0088; Tue, 27 Aug 2024 09:41:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CAF7C6B0083 for ; Tue, 27 Aug 2024 09:41:34 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3DD9C819F9 for ; Tue, 27 Aug 2024 13:41:34 +0000 (UTC) X-FDA: 82498137708.26.CF21CC8 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf02.hostedemail.com (Postfix) with ESMTP id 2239680011 for ; Tue, 27 Aug 2024 13:41:30 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BCt2lN84; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724766023; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SJBoqc4v/D4DmmZbA8VXEX+6xxqVFKOrbHTjVv1cRJ4=; b=MN3cLgBJ1mZTkMbof0PkVFdWjCjxh9kvp3HcCiPzJ4lq0TcryiZlzpXRfZWTzNWkeNhrBv Pq9dtHMaprSrcFTVNpo2MLvxXx8wmMkygqfJn5rkiEdNAtMfvc+1oJe8fj5sHU8qTUQtNC r5nNiciaPOEdUuV2MedlooWG6ULrXsw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BCt2lN84; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724766023; a=rsa-sha256; cv=none; b=yMlRm2aIC29FSJmt1ObdGa2xXoawZEGvVfONaICZwCnBI86ujyz7R7FszhzRwcboA+oe/+ 3fxvEghf+PVkwcODGPaFAYi26ifu1A+TFSgbYDMnO/4xgqEMK96z04KZSPdcUPhrjp0qq/ IntmSv9DPNylaN6eDlQdCgCARW1txKE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724766091; x=1756302091; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=U7jlPpHqXBl4HV4XuzMC0RMz+LSPT7aClOWD+Th3CoE=; b=BCt2lN84PwAbd9cLhjp3W/CvnuWIgegwlmufj+3xB6jC82tFYPM2F7Mm a+8c5eNDHWURuE7I+AYjiYrSCrkvR01PiGjy1VBEdy5wCqJNmVMF6yhHl ijmyfospnRymsDB3AYLqepwwJ9XRHvv196ojWykJVGV0gbA4fJWNPNWL8 JstdJnekSpujL/LzgRyjO9uDqjtD2wLx/RSIVgupuY34BHdeq1ptiwF8k 3sZ8pEyNcUYiubZjBFcUMB7J7IDaGHfDlC+Ne+J3ZbZys2cyyKOd+6cv7 LpTtk2LeGZoqOXkrGiRHYOgbm9XjbvqPWd0gT3UAtmrf9AirUv2ZpebuZ Q==; X-CSE-ConnectionGUID: s6TW5ixzQb6X+w5f7aTxDg== X-CSE-MsgGUID: VVHsRBHuT+KAlN524QrUSQ== X-IronPort-AV: E=McAfee;i="6700,10204,11177"; a="23419550" X-IronPort-AV: E=Sophos;i="6.10,180,1719903600"; d="scan'208";a="23419550" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2024 06:41:25 -0700 X-CSE-ConnectionGUID: W1apEhwKSGmNNLyQayeLSQ== X-CSE-MsgGUID: Z0N4/UqFQ1C3dS2rbcQ+hw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,180,1719903600"; d="scan'208";a="67727828" Received: from lkp-server01.sh.intel.com (HELO 9a732dc145d3) ([10.239.97.150]) by orviesa005.jf.intel.com with ESMTP; 27 Aug 2024 06:41:21 -0700 Received: from kbuild by 9a732dc145d3 with local (Exim 4.96) (envelope-from ) id 1siwRj-000Ih8-0F; Tue, 27 Aug 2024 13:41:19 +0000 Date: Tue, 27 Aug 2024 21:40:19 +0800 From: kernel test robot To: Shakeel Butt , Andrew Morton Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , David Rientjes , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Eric Dumazet , "David S . Miller" , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v1] memcg: add charging of already allocated slab objects Message-ID: <202408272111.T6bMZmU9-lkp@intel.com> References: <20240826232908.4076417-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240826232908.4076417-1-shakeel.butt@linux.dev> X-Stat-Signature: ke9t77916wx5133wdc6awmospr81di8x X-Rspam-User: X-Rspamd-Queue-Id: 2239680011 X-Rspamd-Server: rspam02 X-HE-Tag: 1724766090-268791 X-HE-Meta: U2FsdGVkX1++PwcVQiePpJFjknsWVHLhI5gVi0EO7GUp0v/WcVJ1zZQ+zKMSJPWD/XIHplmA4hLw+dmA475YhhC4HvJxur9ECmQX+aRhAtgJLeY+TNp+OlkOFm1GkybFhzI0tMZRTku2FuFFftTKrN7wHkJvFIUf07+Eh9e7yAHMExBO54QZ09RC+43shheX+wdaiZrfQK1mrZWgDlrjDq9qH3B0Eps/g/th9MkEMK9MIs1MBPDx7VqhzcJ924A3gDrCYW3jv4iSXWDIQahF1SqNtFYyWjjZnmgT4pb7VCk+Ohc/BJNRSwCdhIJhi8jlI8VOcWzFIlSsVlkOPCyhq0xiQLZGfh4jG4MMQ4NBp5kzrsVxXxYhZHtiO1UyLt+cnXDl6DR4R5u/rSSmJJfmqJlBBuwFeOiRsx1pwm1VxpbuJFPLlSzs1nauCAaW1MmycmHXLEkpICeF03yi5XfxqrA3PL8p4SFchmj3pOqA/a1u+siLUZ86qyhQLfySs0+1/yQ42s13dAqyLWekRcx/cd4lAgAHNYN7EdRt8+wQEXYmtLZmfyK/zliE7IAmNn9nfwLfW03VNldGW3o1iycJAROIGalb+PKvpvs+ZJCKF5OmJGAraxF8ckGzRhqtUtdBgaOwr7U2IvXWyGH/25ROvgMD3T+2UdWy+NX0jdvr5QFpLn16D/fvKZW/ibZqIws4MO1JNzm6dxvhLQm5NLJxK/Lg6ASbaEB84EUHp4wbKqq5so4oW9fqe7wOSat/iIL4zQqWqyZa60R3YSkNgl+/AScFb52jMXRKr0eS+zMpjte0bG6wH+OS+qU3PJrdwIUUPbg4IGmQV64x/5uda6lC62LZnYc5CwYSFBpzKJRSXin/g3Yxqeitou0u/l0Nu7ME7uotqr3NA3KfYIrJ/PUQDO3Hg4iMoQWHKWU6KthCTaJD2ecNwHprvhZnelfuq7Ni24e3lR2zdeTOf+rBBJH 3Xi9bTW7 w2bCY6uEFeuMJrNntIzNS69/NuuBwb55ZviZNLE1dpTK12fnX9hh9m4G5/JTf7Ku1LDhnKvmaI6abolamLzM+fRqaL4BZxbb2pwGVrngBB5KP8xCdofDZkpfH9Z0yBwpd46CMTfOLp5b5qyk2KHo/vPcD+UBjI8x/AbwRuaO/zgn4vhb45skUezHTpjLTpO2hxFzbWZyLPGtkvFMUHxS03ISgA6NEmAn1/AtcK98AhdSbJdE2knASVyaADaCT+fM5OcJ0v8ziNkZkiTLWS5hLoSmaF8hRVY3t/jKV1UHEFdg5Tr7phC263VWUe0JvygqR/gluELF3Kd4QkXfxIpcityP2kK5oJzdi34Y/3Jix//zxZFTh9+wLFUxvVzQgLGJAbzPYN0dmhF4zaXjLs5ir93TGkV9/dUVM5pCB2E0WPSbV7uXe0G6uzC40jr1A7HdB+Tf827DjhCeaBEOsog42zZUt32UfP0tgq5ak X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Shakeel, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master v6.11-rc5 next-20240827] [cannot apply to vbabka-slab/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Shakeel-Butt/memcg-add-charging-of-already-allocated-slab-objects/20240827-073150 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20240826232908.4076417-1-shakeel.butt%40linux.dev patch subject: [PATCH v1] memcg: add charging of already allocated slab objects config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20240827/202408272111.T6bMZmU9-lkp@intel.com/config) compiler: or1k-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240827/202408272111.T6bMZmU9-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202408272111.T6bMZmU9-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from include/asm-generic/bug.h:5, from arch/openrisc/include/asm/bug.h:5, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/mm.h:6, from mm/slub.c:13: mm/slub.c: In function 'kmem_cache_charge': >> mm/slub.c:4115:44: error: 'struct slabobj_ext' has no member named 'objcg' 4115 | if (unlikely(slab_exts[off].objcg)) | ^ include/linux/compiler.h:77:45: note: in definition of macro 'unlikely' 77 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ vim +4115 mm/slub.c 4085 4086 #define KMALLOC_TYPE (SLAB_KMALLOC | SLAB_CACHE_DMA | \ 4087 SLAB_ACCOUNT | SLAB_RECLAIM_ACCOUNT) 4088 4089 bool kmem_cache_charge(void *objp, gfp_t gfpflags) 4090 { 4091 struct slabobj_ext *slab_exts; 4092 struct kmem_cache *s; 4093 struct folio *folio; 4094 struct slab *slab; 4095 unsigned long off; 4096 4097 if (!memcg_kmem_online()) 4098 return true; 4099 4100 folio = virt_to_folio(objp); 4101 if (unlikely(!folio_test_slab(folio))) 4102 return false; 4103 4104 slab = folio_slab(folio); 4105 s = slab->slab_cache; 4106 4107 /* Ignore KMALLOC_NORMAL cache to avoid circular dependency. */ 4108 if ((s->flags & KMALLOC_TYPE) == SLAB_KMALLOC) 4109 return true; 4110 4111 /* Ignore already charged objects. */ 4112 slab_exts = slab_obj_exts(slab); 4113 if (slab_exts) { 4114 off = obj_to_index(s, slab, objp); > 4115 if (unlikely(slab_exts[off].objcg)) 4116 return true; 4117 } 4118 4119 return memcg_slab_post_charge(s, objp, gfpflags); 4120 } 4121 EXPORT_SYMBOL(kmem_cache_charge); 4122 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki