From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE59AC5474A for ; Wed, 28 Aug 2024 03:22:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61D346B0089; Tue, 27 Aug 2024 23:22:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CC886B008A; Tue, 27 Aug 2024 23:22:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BB236B0096; Tue, 27 Aug 2024 23:22:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2E9996B0089 for ; Tue, 27 Aug 2024 23:22:12 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CA2B2A1C1B for ; Wed, 28 Aug 2024 03:22:11 +0000 (UTC) X-FDA: 82500205662.16.54D27EF Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf13.hostedemail.com (Postfix) with ESMTP id 8E2512001D for ; Wed, 28 Aug 2024 03:22:09 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=VDLLivFs; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724815259; a=rsa-sha256; cv=none; b=aO6Y3kBwUB2CoOIeX8EorZQALDSOmEnWb+pX15dry0rVtVmVi/1kTYM013Zuv/wlpj5ivV /i3SaL267YfUoeDgI094w+ppeiqyVVwMFT3CnwKcW4IIGCqiyXZT7btINIRsI7J7gwxMGn Vu7tNSEgiV4nJk/zqlOXB+Y9JU/MQsI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=VDLLivFs; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724815259; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RKOnGvSQF1xCIGi1XZm5ainTLQw4ZzHRvOq0hD7VW6U=; b=50iB5Ds5O/rVHRFTCqAID5yS3G90/UCvfGJLcogjBTFPwu577hKtUameHRS/lnA10a6eS7 aNGsSp0b+lJIWl30TmrqJ9ndA8qDMchF1TQO5s22ZIVwVU/3Vzq05n7GDenQ5yFg4HljEK Q6YmY7y6tCqmsdwOVbMmRWxqAjvFk+w= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 09DD9CE1751; Wed, 28 Aug 2024 03:22:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C0E6C4AF0F; Wed, 28 Aug 2024 03:22:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1724815324; bh=fHlyJ35eZVClM0QqaCWAspv3ePgLlC9CUj+DFPnZ10o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VDLLivFsVLVyHuaPTqL7XSbOAh8R1qdmYIA5oCA71qf1zrjWwgfwMDY0cOnLC+4Mo XrlkuR70OeBoI3b+2E1+afWj0JQkSEECIMSkxW2OZ/ZFNZqNVC85UMTQEQqUfRU5IZ iQ7lFQKzsg8G0p7QJNTua/Gv4Hs3mDBxgav9YqRs= Date: Tue, 27 Aug 2024 20:22:04 -0700 From: Andrew Morton To: Hongbo Li Cc: , , , , , , , Subject: Re: [PATCH -next v3 1/3] lib/string_choices: Add str_true_false()/str_false_true() helper Message-Id: <20240827202204.b76c0510bf44cdfb6d3a74bd@linux-foundation.org> In-Reply-To: <8d19aece-3a33-4667-8bcf-635a3a861d1d@huawei.com> References: <20240827024517.914100-1-lihongbo22@huawei.com> <20240827024517.914100-2-lihongbo22@huawei.com> <20240827164218.c45407bf2f2ef828975c1eff@linux-foundation.org> <8d19aece-3a33-4667-8bcf-635a3a861d1d@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8E2512001D X-Stat-Signature: be4ndhedim6opaw951dnehwz6gfsweeb X-Rspam-User: X-HE-Tag: 1724815329-44049 X-HE-Meta: U2FsdGVkX18f1qcgGG78FAHfaoR5zFnEtMrnmyUW8sFqaHAawtYWDBuaBMjHMaX7FjCdiS2viPHKfteaCopqKAL44HJGGqKTa8HiRur14RCb/52p+8iU6arFfJ0Ioa1SyoHtPWJpSggfydDuwFbG1LVws0MooZkxCupQttCpoqXzHa6D/R3sSCDxldFvzINDLFf95lgO3n2l7kN32Tb7QEQtuz0qjvEUXtTUczMDkADTQE890WLYULABo8mmVBDVTDdn1n74v64rrnBD5+/x8k2W5o7eYp3aqse+/hKzuFnlvhk44fMbdwVQbT0Z0Dt0oa/7zykW1e9MU2EL4HO4p4pE1H/bKSTihIpHNIUCbTYdKMzq7qRthL4vSNm/fO2sbfZvOeGC6y5yE8cncTyUvzUECjuZH6UxNQDHfWgT/Id45HGLmoD7FBw1Ov/mQuLqWEZQNb4gIsZAeAQEYXkbgtiK7538Wes9iERupVTK3VYp1FlYaU2EUl3bxvSb585aPpH4CC8IuAZEv578XGvav2vt5IlxuLCKO+rnb7RFs7qw8hIf7L4fEVHTrh2TXpFz93ZijIkaAhYAvAnT8xQKsxmJHUWKCVK/XVChn7rZXVaJCLYq5fWzAECZ7rtLXMWaBctXzhGW1C1qoj/oHDa299cD8qCMlIBvaPyHED1Uql5N7TLOCf0Hr/tKJt0qilqliwANoukVtjCMZxd0il5mlFqGQZgCL8ZORfM2Ay6vOcwLg0D0HTThjxX+gm4KFoCTzX8B8w5+UjokIMbLDKRTLdUz8DSZUSBiPoOU6tsNfcnRI3/W0IZx6ZzuuxMy+Bzhf0qhxKe53wBIP6uf0DUh38WNOjOCtOVQgIZLH6dBz+KaXwdA+8EsC9UzLb3kb/q9GsvgOALCHtwnPE3jE8zEAKNVeXEvhYyynPbSYYQeiBEjk6X1rN5HLKJF+Gby3ownF7sSiYgYm+3D6InnwQl rMy4vOf7 e/aucjJkdsVdXXOBCa35Kk7/1dLvML/62xB9Vlf4Yit/0arh3XyZ6FFdbtoC1uRRgo/LpYqoYjABedWw4/5BET78VWlt3mR8Sb6bSJOk5hQk8hRtXNIkKyuBHHNj6W22LzIO79KpCFKZYT8FJ3pY7yxmZuLqcemCoHs+UZfGwAAdo52Qntqconp6AQioCYKjGwLiIjwA69xbKbRHVhChjMxiyZqH3UkBKcX2Vw1kKq++NpjTD1bAfDuqp22Hw0y6co5gsDR5iCcyn3Noe11LkTYvcyfNrZaPIBCFUuPSzQ7suQhq+5HlNLID9YVsEqRicdXuTR9IoqvQwDFvt/wYpEcHoSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 28 Aug 2024 09:48:21 +0800 Hongbo Li wrote: > > This might result in copies of the strings "true" and "false" being > > generated for every .c file which uses this function, resulting in > > unnecessary bloat. > > > > It's possible that the compiler/linker can eliminate this duplication. > > If not, I suggest that every function in string_choices.h be uninlined. > The inline function is in header file, it will cause code expansion. It > should avoid the the copies of the strings. Sorry, I don't understand your reply. Anything which is calling these functions is not performance-sensitive, so optimizing for space is preferred. An out-of-line function which returns a const char * will achieve this?