From: Andrew Morton <akpm@linux-foundation.org>
To: Hongbo Li <lihongbo22@huawei.com>
Cc: <kees@kernel.org>, <andy@kernel.org>, <trondmy@kernel.org>,
<anna@kernel.org>, <gregkh@linuxfoundation.org>,
<linux-hardening@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-nfs@vger.kernel.org>
Subject: Re: [PATCH -next v3 1/3] lib/string_choices: Add str_true_false()/str_false_true() helper
Date: Tue, 27 Aug 2024 20:22:04 -0700 [thread overview]
Message-ID: <20240827202204.b76c0510bf44cdfb6d3a74bd@linux-foundation.org> (raw)
In-Reply-To: <8d19aece-3a33-4667-8bcf-635a3a861d1d@huawei.com>
On Wed, 28 Aug 2024 09:48:21 +0800 Hongbo Li <lihongbo22@huawei.com> wrote:
> > This might result in copies of the strings "true" and "false" being
> > generated for every .c file which uses this function, resulting in
> > unnecessary bloat.
> >
> > It's possible that the compiler/linker can eliminate this duplication.
> > If not, I suggest that every function in string_choices.h be uninlined.
> The inline function is in header file, it will cause code expansion. It
> should avoid the the copies of the strings.
Sorry, I don't understand your reply.
Anything which is calling these functions is not performance-sensitive,
so optimizing for space is preferred. An out-of-line function which
returns a const char * will achieve this?
next prev parent reply other threads:[~2024-08-28 3:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 2:45 [PATCH -next v3 0/3] " Hongbo Li
2024-08-27 2:45 ` [PATCH -next v3 1/3] lib/string_choices: " Hongbo Li
2024-08-27 23:42 ` Andrew Morton
2024-08-28 1:48 ` Hongbo Li
2024-08-28 3:22 ` Andrew Morton [this message]
2024-08-28 3:49 ` Hongbo Li
2024-08-28 20:25 ` Andrew Morton
2024-08-29 1:12 ` Hongbo Li
2024-09-05 16:51 ` (subset) " Kees Cook
2024-08-28 12:59 ` Andy Shevchenko
2024-08-27 2:45 ` [PATCH -next v3 2/3] mm: make use of str_true_false helper Hongbo Li
2024-08-27 2:45 ` [PATCH -next v3 3/3] nfs make use of str_false_true helper Hongbo Li
2024-08-27 3:33 ` Matthew Wilcox
2024-08-27 6:15 ` Hongbo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827202204.b76c0510bf44cdfb6d3a74bd@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=anna@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kees@kernel.org \
--cc=lihongbo22@huawei.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox