From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE9CAC5474A for ; Wed, 28 Aug 2024 02:32:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 201306B0082; Tue, 27 Aug 2024 22:32:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B1C96B0083; Tue, 27 Aug 2024 22:32:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 078D16B0085; Tue, 27 Aug 2024 22:32:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E0D076B0082 for ; Tue, 27 Aug 2024 22:32:33 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6148D81C0E for ; Wed, 28 Aug 2024 02:32:33 +0000 (UTC) X-FDA: 82500080586.08.9BB3144 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf08.hostedemail.com (Postfix) with ESMTP id 18EBF160007 for ; Wed, 28 Aug 2024 02:32:30 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=b9Bmt1JR; spf=pass (imf08.hostedemail.com: domain of kuba@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724812331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xzop3t2uvnUlI9ZQSnHgbrCseaUZIRoZiSDd4kmb30M=; b=ta83Sk3rFVv5J2agOqZeANEulgN0mfTIfTj6FK/DvL2UtznSRbLtfo+jxDeGH7EOkD6rVr mMd8RFEx+UDwtJHQq1l8K7Vi6K87rzNazel6jXkjSblflnT+bNGfpMHuVKtTPeFsOhZKZm JXY/SecLn35dTZtXgXJMRqsZe/L4ga4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=b9Bmt1JR; spf=pass (imf08.hostedemail.com: domain of kuba@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724812331; a=rsa-sha256; cv=none; b=htzardZghf+GTkUPyeOTL+G7Ma0RHY9tK2P2lPvOh8ukiU9coGz0etss0rfOtQ9BHu8EK9 lZpPx5z7KEMMgjZfQc82AL6zFF19rjjb2yovbjIoQfEEelb58/rwvnkumP0PYqKbrLschE m2TwuUrv20uj0vWc6eFVt7cUIPXRqU4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2D776CE1712; Wed, 28 Aug 2024 02:32:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E784C4FEE9; Wed, 28 Aug 2024 02:24:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724811874; bh=tbhzQ1da3mBVV060Og29QANn1s4vz5Vd4ovZ/NNJcUg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=b9Bmt1JRKFBCrnIFqkRTsrtV2UxALLlwq9vjsa8mb6ADifsmdWpQkF6hV/RYp8vQA KnlrsUZWHHrZTtadELynyygYzNgxIL5XjiYXqvsDF4WjDbVNdoVWcjeJP/CMV5jE+5 zHY1WzE7dhEgfg1nYdKdE+Kss/9anIAQAvEtqTsmXn5d1UFI9SFv6kPJc99SCMRNQM e5zmbEEJvj2B7cIjhKHtljG3nSZ00UtlbSdrVtBkmpzbQotM4l2h2mL+SWEBBmpQt7 JSmguwlN4ydS894ghDp569iFgNhfAjPbkNp3FHOMAwrnt4gmuwMvVn9FUd04rX88Ko f0IMC8yARB4lw== Date: Tue, 27 Aug 2024 19:24:31 -0700 From: Jakub Kicinski To: Mina Almasry Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , "=?UTF-8?B?QmrDtnJuIFTDtnBl?= =?UTF-8?B?bA==?=" , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Sumit Semwal , "Christian =?UTF-8?B?S8O2bmln?=" , Pavel Begunkov , David Wei , Jason Gunthorpe , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , Bagas Sanjaya , Christoph Hellwig , Nikolay Aleksandrov , Taehee Yoo , linux-mm@kvack.org, Matthew Wilcox Subject: Re: [PATCH net-next v22 05/13] page_pool: devmem support Message-ID: <20240827192431.7145b06e@kernel.org> In-Reply-To: <20240825041511.324452-6-almasrymina@google.com> References: <20240825041511.324452-1-almasrymina@google.com> <20240825041511.324452-6-almasrymina@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: dc9ucz8tzt63z67seajydz16ss4d8jes X-Rspamd-Queue-Id: 18EBF160007 X-Rspamd-Server: rspam11 X-HE-Tag: 1724812350-17314 X-HE-Meta: U2FsdGVkX1/Bdec7H2E0PaJSzG58mhlOXA0RjG7NW1NbMjkTtOqo8RUNyDBJ0Lt0xEzvJ23VCLStIYua4VKhU3yd5knPQS+ZuIxE7h6hkZ5Ko+w1dxQyPZbyRmGktkrLErKNzwhbWx6/BD39xx9man0pZ4GjUDHuwuggoKN2mM64QtVXhwbo8JWqyIyOwOz6Kc6zgONEtGGx1NPPJUFitmzrGrMoDvnlsLTnEJWbltOQZqMYGBc/bxSk0vaQ3vVkIpLSjw7kk3QrhOgGx2JJ6yFNjSARDxgzBzM5ZNVoTR3+HP2wADep6JN/8kz7XxuVyC8Qkiwb0LxbfD8iOiz2q1Nxe6k8ji++762kZOQA9bgwoA8tNy+d0tscx4o3b8WT4JYR3U0Bexy0UhE2fG+SiIZyQtGL5NfGtYZ74o9QYF4bsmlg3v3WV0cqB2VxOqrhudNIRXNsz3ZQrzrUauowTTxxKYIWbe4exhDmclXg2K1fl5zh4NyKyd/C4F1pwebOOb4xtqP8OMmH5i6cxqGp/xaOys1e0fDIVLV8mJFC2gykQ6j2Vtr2RdKA3YktOZ4Pnogx9AuQAU4Kj7aVj3jLwF0eAfMv9FOFkYMo2oi+GB1qSYT11UPel3Q9X2ZOQ9uo41/0oGJfJ6EZDqIvQvLGfj5zsZR7MSSWH7kHACWRz4b34Afe6yx2qzOBJZQiMfwDbXJScSUtDdaOc52zHsixYCcycqgRsJkBfwMC1sRNA3/1n7TLG3ahNumxO7nrH6V/wkmm+3+cUEeR0oQ7RdiGoZ86kVxie9Erwx82MEC9/KuGSDGYfBIicGiFv0wcH5r5uFTf27VW7W7b43jOwQOuB1halcbEN5VHLaTTeu6sGcmrnqqAfMWQayGQ4sR+LrzRNA4r4jDHpwVmgMfzISn0t6tfnIwqRsJtgRQvouumYhQJWRwJXPuLQlZV0y6sq+wBO1hW6CVDQN+fte9Ca+9 88MAKXVn BNZ80bkW6GhkwgdTxtI7TVyoCH87yCBl+UK8EKJk5Sb7I+viF/kUxHjdliR/QxHh66cOAarBy03tiChTGkXGtTi5CB9bSxuc5hPgdkFC/EUeRlnry1BP2VxkgGIYVKMADFLA6kcKw9JGkJHynR5icO6meargMvCsDDfo2agvDvBVFvs7K4xTqChk/U1YKqUhxfoUMnSnao82Wbqb38ud2RihTBacm8WZ1YeOn0s863CDKFfd3zDw4i0HJbLo+/uT8xrBm/0i0rG1SColGOALKgTdbl3XF5HJhtn3VCWibOufiarUhL+aOHBCIaSemhKSCXCGeHIcc4anUrReoLr2ap4K0SCg8MoX0JNdmSyjt4ANLmwpwhk4U1AjGmpW8BO7EFPLcRUJzb2F0UAL/7GJcIvlGKjClNXEooHcbG2+rGDhUq3M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 25 Aug 2024 04:15:03 +0000 Mina Almasry wrote: > + /* Assume net_iov are on the preferred node without actually > + * checking... > + * > + * This check is only used to check for recycling memory in the page > + * pool's fast paths. Currently the only implementation of net_iov > + * is dmabuf device memory. It's a deliberate decision by the user to > + * bind a certain dmabuf to a certain netdev, and the netdev rx queue > + * would not be able to reallocate memory from another dmabuf that > + * exists on the preferred node, so, this check doesn't make much sense > + * in this case. Assume all net_iovs can be recycled for now. > + */ This is probably a bit too verbose, and we shouldn't talk about dmabuf specifically: /* NUMA node preference only makes sense if we're allocating * system memory. Memory providers (which give us net_iovs) * choose for us. */ Some of the code moves could be a separate patch, but either way: Acked-by: Jakub Kicinski