From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E190C54747 for ; Wed, 28 Aug 2024 01:22:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9497E6B0085; Tue, 27 Aug 2024 21:22:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F93B6B0088; Tue, 27 Aug 2024 21:22:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E74C6B0089; Tue, 27 Aug 2024 21:22:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5F7DD6B0085 for ; Tue, 27 Aug 2024 21:22:25 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1516A141B6D for ; Wed, 28 Aug 2024 01:22:25 +0000 (UTC) X-FDA: 82499903850.25.C267C8E Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf22.hostedemail.com (Postfix) with ESMTP id 78C1AC0007 for ; Wed, 28 Aug 2024 01:22:23 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=SrZlKHGz; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724808072; a=rsa-sha256; cv=none; b=DDM1kMqqwP34nY15foi8Vbljae5H3Fv/biDEGYpqjRw/snj7FK5UOtWhUfX7jG+VWJrezr vrJWe+8opfQhGYei/IA/nxSoHj+LDuMcchDYZGKPVqZ2gppJzqW/+rqKMlRP7Xiwc4J3Mq 2oY+iknRaEmH35COXEmb0YRTy+dsKYk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=SrZlKHGz; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724808072; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lJcUdcKHriIrI3p95tX9idsT8ug0XA4WAxmcJ5LYgHc=; b=sXNwh1GxU5Fmoo2Gj+0hN+8r9TuGiomaVR3si6Fp+k0vMKqa+uH7lCd7Nw0NzL+6NklZr8 6ap4VVev/IYIgumKvroIYMFMHMykM1xJWfz0IIQsWoPLWpQMMGt9nNtRmB3+HMQBbDeT6x +UMXl2nvgIPZYX7veu1XPJTBuAlFJzE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B7053A404DF; Wed, 28 Aug 2024 01:22:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 797EFC4FDF2; Wed, 28 Aug 2024 01:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1724807679; bh=m3ylbqn0KmJHpZpFlM8uLhb9/jxBXw8JzU/9v90T5+M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SrZlKHGzHHJOWZL5PPGTMYPN4ws/bz3Yl4wME+4ukzceAxpYOsY3EwqM5E6dSnbXF mWaX9U56gvtL1A/FPpQxrcijUu2DwhH0A9okK7CtkAvI7Q5x22rIVSV149JJVA0aJb i7VqlM//N2shcnHR2qOJMMc3xVs/Yl10Hsq5xLiI= Date: Tue, 27 Aug 2024 18:14:38 -0700 From: Andrew Morton To: Kefeng Wang Cc: David Hildenbrand , Matthew Wilcox , Baolin Wang , Zi Yan , Subject: Re: [PATCH 1/4] mm: migrate: add folio_isolate_movable() Message-Id: <20240827181438.d8b7100c015306e5f2b19504@linux-foundation.org> In-Reply-To: <20240826040132.1202297-2-wangkefeng.wang@huawei.com> References: <20240826040132.1202297-1-wangkefeng.wang@huawei.com> <20240826040132.1202297-2-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 78C1AC0007 X-Stat-Signature: 6754y5tjnfd7a6g9jnhs1gwtsfnrwb9o X-Rspam-User: X-HE-Tag: 1724808143-441293 X-HE-Meta: U2FsdGVkX195Xkaot68XC8CQzpJoIeFatglEDWWTOxLELJo69gszoKGKOijP6264wE6uzE8AVAMsJwTcFyLshDwClyqcfi0OXmNvAw5utcpW4VeR40SMAQzdxSz39Ob3YKGWu9fWRUqcOoHnPyhmSAqgFUq6jvEj0/SELZNgXsnyYGCpiH+Pr2r/5UtYZmavtL6BoLtdkhskVVh6+0eAV/nr3wYMTFAX/UGs/i6bQE+wh3PO4LcvIy0zO2PxZCXLSHa/PcweJyzdHbGkSmDGu6YNzZNsdRctIzxOYGtiWhI+57h2g/61hwIMTFpsWeswj6yBD4APQWobgMk72AudZIjPH26FLwwJhjZ0UTOpSMjdBlAafBHFzHzk2cuJgtv6vx6t8qrLy4Ro0217zhCLoHsU9IQbt9dKs2BsE08aiapmo+3KJ1aQ++4K58ZnG38Hv7ZEKmrCs3swiW5S+4DCDV704SWz3GsMiJsh0YlAx1Of7RhIzEdTswS74JdjOCFEK97Pvom+CZyKbtKZ0nwBXejj6SFnEcDUXzILU8tioTeqM/l5XxqXnK9vx8oDUd3wBvJdq6M51IqRKdO7uw+NqEw1L6pk3YKyakSzEJZl+OJgh3hR+t+WO2wfnO3c/2xranB9QW+OMxcyWtNlSizSZAaG7R9vP7MNo/O+R2afYqvWFyIgVIZ5nYSgFY1JhP5/AnWgtq3GERjqEImxq9oKv0ZsZGxjJkdhu0EOXyZckpPhmEbRVmPpsefyr5LUZQ+lL3dFTG44zmZ7bqxiZKVBaCasxFERD30uCDlyVFyK2ujofJViRm9ZPZcinFrLZ9M4c8snMviAa7lTFyTIuaUhxoU7Fbq7CEp1XuFkY1IWBmSqvOoW4c32dYH4lY6S52Wz5Fldd4zg6UMOP/H8xpkxM2YDbGAHXcazQ7ZTT2wMimY46IBJwbe+Q14BsUSId6JZQN5+b1FRW8X9U0sGezA SH9Fn2iv vjmTlCggAOvuKkR3pxQg+GQ9Ts3CZpvxwbKFsu1ovFq/zBlXwrwK8XZrPoLEFi3lGXM82ZxEFsjqeMjazQVjzwKVh1tollaxf1iSfU/YJKlh2AApk4izxn58ok/TVDASowxvqiXLdQXxpdlyvh/Ut83Wt6oraz3cm1qzwqTSwD8xijJrrHC9wnXPDUumKeV6v1/gTB4j6yPW7lWY0kR/K9yBAXtnwTva8w41dpH7Yximl3dKJvO0aIbE0DN8Ie/JXPbMxx/xGn7LJ8MA4x24jzBqC7niol2JCBGzmk7hQkOf3PXJWX0iIxKlTvPpQ14zTVHD0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 26 Aug 2024 12:01:29 +0800 Kefeng Wang wrote: > Like isolate_lru_page(), make isolate_movable_page() as a wrapper > around folio_isolate_movable(), since isolate_movable_page() always > fails on a tail page, return immediately for a tail page in the warpper, > and the wrapper will be removed once all callers are converted to > folio_isolate_movable(). > > ... > > +bool isolate_movable_page(struct page *page, isolate_mode_t mode) > +{ > + if (PageTail(page)) > + return false; > + > + return folio_isolate_movable((struct folio *)page, mode); > +} Use page_folio() here?