From: Andrew Morton <akpm@linux-foundation.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: David Hildenbrand <david@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Zi Yan <ziy@nvidia.com>, <linux-mm@kvack.org>
Subject: Re: [PATCH 1/4] mm: migrate: add folio_isolate_movable()
Date: Tue, 27 Aug 2024 18:14:38 -0700 [thread overview]
Message-ID: <20240827181438.d8b7100c015306e5f2b19504@linux-foundation.org> (raw)
In-Reply-To: <20240826040132.1202297-2-wangkefeng.wang@huawei.com>
On Mon, 26 Aug 2024 12:01:29 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> Like isolate_lru_page(), make isolate_movable_page() as a wrapper
> around folio_isolate_movable(), since isolate_movable_page() always
> fails on a tail page, return immediately for a tail page in the warpper,
> and the wrapper will be removed once all callers are converted to
> folio_isolate_movable().
>
> ...
>
> +bool isolate_movable_page(struct page *page, isolate_mode_t mode)
> +{
> + if (PageTail(page))
> + return false;
> +
> + return folio_isolate_movable((struct folio *)page, mode);
> +}
Use page_folio() here?
next prev parent reply other threads:[~2024-08-28 1:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 4:01 [PATCH 0/4] mm: convert to folio_isolate_movable() Kefeng Wang
2024-08-26 4:01 ` [PATCH 1/4] mm: migrate: add folio_isolate_movable() Kefeng Wang
2024-08-28 1:14 ` Andrew Morton [this message]
2024-08-28 6:37 ` Kefeng Wang
2024-08-26 4:01 ` [PATCH 2/4] mm: compaction: convert to folio_isolate_movable() Kefeng Wang
2024-08-28 10:04 ` Baolin Wang
2024-08-28 12:36 ` Kefeng Wang
2024-08-28 19:54 ` Andrew Morton
2024-08-28 23:37 ` Vishal Moola
2024-08-29 1:11 ` Baolin Wang
2024-08-29 1:34 ` Kefeng Wang
2024-08-26 4:01 ` [PATCH 3/4] mm: migrate: " Kefeng Wang
2024-08-26 4:01 ` [PATCH 4/4] mm: migrate: remove isolate_movable_page() Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827181438.d8b7100c015306e5f2b19504@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox