From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A957C54747 for ; Wed, 28 Aug 2024 01:00:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A49176B0082; Tue, 27 Aug 2024 21:00:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F8ED6B0083; Tue, 27 Aug 2024 21:00:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E79A6B0085; Tue, 27 Aug 2024 21:00:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 719256B0082 for ; Tue, 27 Aug 2024 21:00:03 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 168AEAA591 for ; Wed, 28 Aug 2024 01:00:03 +0000 (UTC) X-FDA: 82499847486.08.B4F944E Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf23.hostedemail.com (Postfix) with ESMTP id 5B17A14000B for ; Wed, 28 Aug 2024 01:00:01 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=W6nMf6yv; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724806715; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gKx+MoL+Wq9dHzRJ39znt90oP42f4eDOqC4KQ0UGtso=; b=YoA1SbfPeXMF18Qy7GdbISw7kpumIk4GaH9dnTJsYNHAN5WfvWN9Pw2ILCheixXORmq5ob VhVNevfWNj4AC5Q/D9AFVqcpgMgisHtROUonyrwlcxE8l754us0vZTb6sizs7dt1bdKvBb YmKu0BjaWmziPASz4h6wO5rf3+T9PFs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724806715; a=rsa-sha256; cv=none; b=Y1g7V/wHSLEj6BbE1DTPXFACajlXVhIU7eEVbQEVWsSYnHNrl+PBhZEs4M2wGdW2Ms+YEW 4vwdc/O9f72hxU85O0A+mOcCVLnwKef7Hu+rzDSfEfXftdm6VfOEGV/+tJrqqa/SPVS97v 6eVyJU4uagyBRYcRsQBsJZZ+nbmsBVw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=W6nMf6yv; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 9715FA41F2B; Wed, 28 Aug 2024 00:59:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10B4AC4AF0F; Wed, 28 Aug 2024 01:00:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1724806800; bh=i65raoFdcOG1ThmM7NP2MtO1wtjOxTudquKF99DFxE0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=W6nMf6yvaF/Ss4uvCF9sl474TR1KOW+120H0q1OblTfh4stJgLzJ4GV+S4v9H4WND LhO8iAfg2b1PLboCFBHR8t1Q6ry8tZDg++BznCB6+1F301OIXyJ7lf5qdDN0b/gf1a jfC4rJWI7FtM63bwAK/2o8ggtt2JuV2bkPFvkP8o= Date: Tue, 27 Aug 2024 17:59:59 -0700 From: Andrew Morton To: Huan Yang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH] mm: page_alloc: simpify page del and expand Message-Id: <20240827175959.8f0e9a228407a7be16b328c1@linux-foundation.org> In-Reply-To: <20240826064048.187790-1-link@vivo.com> References: <20240826064048.187790-1-link@vivo.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5B17A14000B X-Stat-Signature: 138dbpyzhncmizci58wq54fpbuf9dh1d X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724806801-693674 X-HE-Meta: U2FsdGVkX1+WlGukyhtqlN9Ukq1PQvGld8n5pDriiQ5FC8qOLQ8ObOfV/nKSg1EISJfDmkggl2ivOA15gsEANQ7oVk1x0XWXPCR1EI5v1JBFxAWNyX/yKIK2kV6Z7+d2QyADHdXBNHcjBZKjDpf/dBaoo/Iaql8fB9CBrKN9dZUkrkQjuJaCWv8YI6lAAXjQo4T6yGwzxYlbXr02pETSfPHM7w7eroQOAwYCAJZv0cuG4ueftnJvWACr0CanVvkL6kaAyb9xkakS7UFPl96Zjo83H0+MxNsjTF8XYvBGIkcHWZWdD3mpRRhFDxdS9N4kQys40lfYUJJYHjWyitwINJHGpL+9izDaLh2t8WTojxHuXZ/l1DlmddRlJEc89hVo4LMDjrnjQO0xUyncbneaABDVzoRW7s9WRINLhKYtVdewNAdF21bf2p+/MnnrGldCQpJcNUxLjoMIyYQSv3oGuyWkhgAN4Xc8Gjbv7pRjSzzEbCtSPxxHHYlQGQLpTVLuiSQawahvhaiszjtx04MncvvbolgSeSgcwJbHlLOk6M6637DqUoVgHogNIpq+RFM/B0i4QUab1GStKG0au/4XF4htvlgodOqP3oE45jfDsHoNtwBZzmNESmeL4FuPpzcjrDZLdud0eQmhTTozNBuAr/EE0ilbIJ3gBrj+7fQHJgneFLbuuUTd6VHBbJvbcYmVLMxFxyWK5JlS+AxP9MJ0H/edTENppwyoJ3gkCcrQhC0Mkqopux/nHIg+eCYn3iteaRub1qoBA2k38rZhIXm1Jrz06FtAyPMWkfr/Yc5hVvAeY7n1AFir6OyXMBgFF4Nv+SU2W4ngjvEweX/twzDNLb3Ga+siUGMcNwbOfu9QFwj6s8u0Q8s/hqQ2zBoiO6TUN92+JHEmcUMSh0bSb8ZAkSgnsLbj5QZTzONp+uZqkVJ0Y+D8DrYviTv4qDhAMHspGnrFeGIqm9CGcCEImpC skCgjKe5 n7qMneFqasPB6sjlDdAlC9SXdBqQW6ujh2kecfFKhqg806VTVZF77lyjqGxZi27xc5+VlGVPwVMHYi12eG6J4XKLLVu+a4WDouF7rwpfJkleHcE68fCz+E66WwwoedYIghsp5NaO0YD6LYCSRYq0NF6biiWL2AIZrtpmThbdJjpgetAQ0mb45ixDEyjhYrOG/5ijNwNw5XAdS0vf8cL7S97ev8SJg3AdnCZiTc0AGYqXlpEAiBUDSycY3Bf5LR903wOXyqlHgGyCg1L+GGE3QAH72taW/XXsY4W1zvtqD3XLMEsASMdtvMi1AwNyX8i3nXSonWHoamJynvbUY/yl0skZ/Zlv858X/yGxyHNt8d5fJCF0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 26 Aug 2024 14:40:48 +0800 Huan Yang wrote: > When page del from buddy and need expand, it will account free_pages > in zone's migratetype. > > The current way is to subtract the page number of the current order > when deleting, and then add it back when expanding. > > This is unnecessary, as when migrating the same type, we can directly > record the difference between the high-order pages and the expand > added, and then subtract it directly. > > This patch merge that, only when del and expand done, then account > free_pages. It isn't obvious to me that this is a significant improvement. Am I missing something?