From: Hongbo Li <lihongbo22@huawei.com>
To: <kees@kernel.org>, <andy@kernel.org>, <akpm@linux-foundation.org>,
<trondmy@kernel.org>, <anna@kernel.org>,
<gregkh@linuxfoundation.org>
Cc: <linux-hardening@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-nfs@vger.kernel.org>, <lihongbo22@huawei.com>
Subject: [PATCH -next v3 3/3] nfs make use of str_false_true helper
Date: Tue, 27 Aug 2024 10:45:17 +0800 [thread overview]
Message-ID: <20240827024517.914100-4-lihongbo22@huawei.com> (raw)
In-Reply-To: <20240827024517.914100-1-lihongbo22@huawei.com>
The helper str_false_true is introduced to reback "false/true"
string literal. We can simplify this format by str_false_true.
Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
---
fs/nfs/nfs4xdr.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
index 7704a4509676..61190d6a5a77 100644
--- a/fs/nfs/nfs4xdr.c
+++ b/fs/nfs/nfs4xdr.c
@@ -3447,7 +3447,7 @@ static int decode_attr_link_support(struct xdr_stream *xdr, uint32_t *bitmap, ui
*res = be32_to_cpup(p);
bitmap[0] &= ~FATTR4_WORD0_LINK_SUPPORT;
}
- dprintk("%s: link support=%s\n", __func__, *res == 0 ? "false" : "true");
+ dprintk("%s: link support=%s\n", __func__, str_false_true(*res == 0));
return 0;
}
@@ -3465,7 +3465,7 @@ static int decode_attr_symlink_support(struct xdr_stream *xdr, uint32_t *bitmap,
*res = be32_to_cpup(p);
bitmap[0] &= ~FATTR4_WORD0_SYMLINK_SUPPORT;
}
- dprintk("%s: symlink support=%s\n", __func__, *res == 0 ? "false" : "true");
+ dprintk("%s: symlink support=%s\n", __func__, str_false_true(*res == 0));
return 0;
}
@@ -3607,7 +3607,7 @@ static int decode_attr_case_insensitive(struct xdr_stream *xdr, uint32_t *bitmap
*res = be32_to_cpup(p);
bitmap[0] &= ~FATTR4_WORD0_CASE_INSENSITIVE;
}
- dprintk("%s: case_insensitive=%s\n", __func__, *res == 0 ? "false" : "true");
+ dprintk("%s: case_insensitive=%s\n", __func__, str_false_true(*res == 0));
return 0;
}
@@ -3625,7 +3625,7 @@ static int decode_attr_case_preserving(struct xdr_stream *xdr, uint32_t *bitmap,
*res = be32_to_cpup(p);
bitmap[0] &= ~FATTR4_WORD0_CASE_PRESERVING;
}
- dprintk("%s: case_preserving=%s\n", __func__, *res == 0 ? "false" : "true");
+ dprintk("%s: case_preserving=%s\n", __func__, str_false_true(*res == 0));
return 0;
}
@@ -4333,8 +4333,7 @@ static int decode_attr_xattrsupport(struct xdr_stream *xdr, uint32_t *bitmap,
*res = be32_to_cpup(p);
bitmap[2] &= ~FATTR4_WORD2_XATTR_SUPPORT;
}
- dprintk("%s: XATTR support=%s\n", __func__,
- *res == 0 ? "false" : "true");
+ dprintk("%s: XATTR support=%s\n", __func__, str_false_true(*res == 0));
return 0;
}
--
2.34.1
next prev parent reply other threads:[~2024-08-27 2:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 2:45 [PATCH -next v3 0/3] Add str_true_false()/str_false_true() helper Hongbo Li
2024-08-27 2:45 ` [PATCH -next v3 1/3] lib/string_choices: " Hongbo Li
2024-08-27 23:42 ` Andrew Morton
2024-08-28 1:48 ` Hongbo Li
2024-08-28 3:22 ` Andrew Morton
2024-08-28 3:49 ` Hongbo Li
2024-08-28 20:25 ` Andrew Morton
2024-08-29 1:12 ` Hongbo Li
2024-09-05 16:51 ` (subset) " Kees Cook
2024-08-28 12:59 ` Andy Shevchenko
2024-08-27 2:45 ` [PATCH -next v3 2/3] mm: make use of str_true_false helper Hongbo Li
2024-08-27 2:45 ` Hongbo Li [this message]
2024-08-27 3:33 ` [PATCH -next v3 3/3] nfs make use of str_false_true helper Matthew Wilcox
2024-08-27 6:15 ` Hongbo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827024517.914100-4-lihongbo22@huawei.com \
--to=lihongbo22@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=anna@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox