From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFBBBC5321D for ; Tue, 27 Aug 2024 02:14:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B4D86B0085; Mon, 26 Aug 2024 22:14:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 164C26B0088; Mon, 26 Aug 2024 22:14:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0053E6B0089; Mon, 26 Aug 2024 22:14:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D785E6B0085 for ; Mon, 26 Aug 2024 22:14:06 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3E219C14C4 for ; Tue, 27 Aug 2024 02:14:06 +0000 (UTC) X-FDA: 82496405292.14.853985F Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2076.outbound.protection.outlook.com [40.107.215.76]) by imf28.hostedemail.com (Postfix) with ESMTP id 297B4C0018 for ; Tue, 27 Aug 2024 02:14:02 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=fnwMsC7B; dmarc=pass (policy=quarantine) header.from=oppo.com; spf=pass (imf28.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.215.76 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724724747; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/AvP2WKSDYEqSDapoqvh/wm9RaEvT+0lwLcrf+461Ns=; b=ySnQx4Zj+/CnnB/2UZVbBermzBccguVVgOy2mJKOV1HY0wYMVwIMIC2AvOQyLzKccwOTXq LCJnzQrsDbw1tap4KqKCVp8s9oEe0KhnjIC8orzi1r5zC+aGtlLd0zp5jTwApdceo2LwHH M5NkUqWqsi/k3Q+j/XZ9JhcOcaGuyqI= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1724724747; a=rsa-sha256; cv=pass; b=xt1/c4C6EHi1y0iA1sNNRZCSLOsiNG7EpI3l/3U8fxHG6iH+Dz9FV1XmuktAYJ/kEaWh0h PSYoWZYbyaHBDaQSuf09oKHcDcVjOKOswG4WB45csGjmDYGsbO/h3vw6SrMpvYf0drywry Pezda6Ygz4rhgDZYSvC8uQ823n0MVkA= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=fnwMsC7B; dmarc=pass (policy=quarantine) header.from=oppo.com; spf=pass (imf28.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.215.76 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nERmyyUFaurwqToJN707iFHGosncMpjkuHTwSGM6dytzQeJor/sSI+SQC2WdVD05QiTD653XFL1Yw/Ljq7kiYMJuUV0zfShNSYT8N+TGPZaNeMM7vAVtjENZVytGut0wQ5Y4KPrxiOXmxjuTHF1znBueIDkSY4G7NglKzjdO2YFc9OP/uFMeWZo1RYWZefn7ZjS6+JM7NBQ+/kK5Xso2tFbswGYqETCLroSNvLvjM1jD5c3Tx7tPt+CcWTuvAW0o74ZuF5BUZBvD1MGKSayg0lLeOguX6hG2TxAZFXXjP0kGBSl3JqtcOfeRgzWQAaeRUEeJ6Y0FLHLw+gw/Ua+QbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/AvP2WKSDYEqSDapoqvh/wm9RaEvT+0lwLcrf+461Ns=; b=XwAbdkBQ+yQJVRlt8V+nZrKBOwKvkqp62nGAy6e93x4ZvyJugwmRTLGVfWfaGH5Ircs+JYG5wpnzTFPiDpr0rA159XXFmbhgWhTgSfUVDB5YUGtcRT8lM79mFZ93yE9UP4xdUGLROVhxkZcPOxZpSoS7Vj3Uhibw16FN9ff0A8DE1L0+Dg+a6iCxNm1CzuYjUrKQ6nbKNyB+7gw3ulkRhoKaNC415UBfUi1MvqVC3dhyGsuasgaYHirBo89jCcAXmaukA/eN4Yh5+dtDOFGNP1wTpQGzQnSHBKu9Ik4I9meOY+4K7PLZjv8lvd5VCDNo4URyYMB/FPPDGgb07sibuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 58.252.5.68) smtp.rcpttodomain=google.com smtp.mailfrom=oppo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=oppo.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/AvP2WKSDYEqSDapoqvh/wm9RaEvT+0lwLcrf+461Ns=; b=fnwMsC7B9vZbXv78k6EHgRgt46JZBsCZK6k24yPoo7k+bkqLwhIAe7KvpLkPBa4XY520/AAUyz68iRGuYhWdgozYf94cUtKb7w4IB3EWweGM5xEeDZCwLsYRkw1nu2jxjdqMsw4OT7JYKkrk9ZR3N1GlRV3qH87x7JqXtwsP1F0= Received: from SG2PR06CA0223.apcprd06.prod.outlook.com (2603:1096:4:68::31) by SEYPR02MB7097.apcprd02.prod.outlook.com (2603:1096:101:1a3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.25; Tue, 27 Aug 2024 02:13:53 +0000 Received: from SG2PEPF000B66D0.apcprd03.prod.outlook.com (2603:1096:4:68:cafe::23) by SG2PR06CA0223.outlook.office365.com (2603:1096:4:68::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.25 via Frontend Transport; Tue, 27 Aug 2024 02:13:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 58.252.5.68) smtp.mailfrom=oppo.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=oppo.com; Received-SPF: Pass (protection.outlook.com: domain of oppo.com designates 58.252.5.68 as permitted sender) receiver=protection.outlook.com; client-ip=58.252.5.68; helo=mail.oppo.com; pr=C Received: from mail.oppo.com (58.252.5.68) by SG2PEPF000B66D0.mail.protection.outlook.com (10.167.240.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7918.13 via Frontend Transport; Tue, 27 Aug 2024 02:13:52 +0000 Received: from oppo.com (172.16.40.118) by mailappw31.adc.com (172.16.56.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 27 Aug 2024 10:13:51 +0800 Date: Tue, 27 Aug 2024 10:13:51 +0800 From: Hailong Liu To: Lokesh Gidra CC: Suren Baghdasaryan , Nicolas Geoffray , Barry Song <21cnbao@gmail.com>, Michal Hocko , gaoxu , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Shaohua Li , yipengxiang , fengbaopeng , Kalesh Singh Subject: Re: [PATCH v2] mm: add lazyfree folio to lru tail Message-ID: <20240827021351.iq6i7zkwm32xili3@oppo.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [172.16.40.118] X-ClientProxiedBy: mailappw30.adc.com (172.16.56.197) To mailappw31.adc.com (172.16.56.198) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG2PEPF000B66D0:EE_|SEYPR02MB7097:EE_ X-MS-Office365-Filtering-Correlation-Id: 25631ec3-8cad-416e-7993-08dcc63de594 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|1800799024|7416014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LCJpBo7td+/Pu/4bpDsXXzeLU4t7hdg6jrNMhR7P4LEEvx5wTFpyxm7LONX0?= =?us-ascii?Q?Zj+YarXP6MTBOUgvxnbRI24UsD3kaicCK2wrQ39QJ5rlK9wjd7XSJGZSh2+V?= =?us-ascii?Q?VjGDHQurghWXnAKqYmfseS3ZLWp84CYCacC8DnOMOGYrvEpLY6RnZBJypMnE?= =?us-ascii?Q?ZaAoiZgJ8q06/4lo3u8cEKnl/wk1hAvJOcH/gy4HCJExojbSSOvTH+dMN7AN?= =?us-ascii?Q?zqcLDp1cKrGO3LHSH8T4v93zjGcsOEQGaMAMz1SdkDyM6teLF6rWkvrQfk/U?= =?us-ascii?Q?Mwpl1VB4vY9GUa1/6XmSPhhFAXFpwIPHsUu5M/cBfNLGlFBlOJEtI5ColSsR?= =?us-ascii?Q?0iTPEzCtFjXdSwajzQqJGtWjCS8gz49gMojq5bj9XVeE6ggEKEp/tO3CukxY?= =?us-ascii?Q?4tQq+/89o9mh901FAkGZoJ0b8kpdjZQc2kRm6yHBwMTQmGOgAFAvuzpSIve6?= =?us-ascii?Q?bbcXcjdjsU+mCKjVJf1KNTsHQw5EuXT6sxdyAHRJQGvMFWyLiSnR1FY9XQeo?= =?us-ascii?Q?SAyy1af5CV9+YAQp/nh+FV35IJjRwmdC6jTotCOV+c8JpJoE5NG2lbIkiQLh?= =?us-ascii?Q?3T0o0vxLCLtkwWTJ7qM/wJBBtz3rzY1qhoGpxu0BFLQdgzU3wjVXfX2Ag+VK?= =?us-ascii?Q?yYoT94zug37TE9jyJQ5R/LXyi8hIaTueCoSYbHS/uPSapKv+OFsdW2fRXPim?= =?us-ascii?Q?4YBW2FrbQpuLhKRx0S13cns3YeLb3VedqNCaizZ6RfjFoV06ZXVejiU1D/wA?= =?us-ascii?Q?0Ptao/ZzSEakR2V6uIYYrHdVqmhrsJS/1e8t37ugTQusapAnFyODL0YMf4K+?= =?us-ascii?Q?NlrxM3PO5pmd5CWwQvpqkwUIwtxGDiJ+yqCixMRKaR5h+VZlU+Ud2qK/V9+f?= =?us-ascii?Q?+B5FYWvDlcnmlEf2KdBfcedjrvV1F/cBhzuUOptUSGB6NW5eulOQ9T5g0gPW?= =?us-ascii?Q?nBKmjtbrHg/MJljlbljwip1tMFnGqzaAx55UrEZlB6yQsxCzAsK4o2W7CBzB?= =?us-ascii?Q?AkPnXstOhe+FQRj+m+rV/qaMQbCBUo4tc8s0zPKBjcbL+vr1HU/tZeS4Wz2Q?= =?us-ascii?Q?EdUOTljT2/82cd29n2CDCakk8Y/gMPGlaD5No25nlP7E2OYVurMnmtmuULSz?= =?us-ascii?Q?gXWGcwVuzRaub2wJYXAa9VD8OKajAknT7egxyJP2wfXjK+R6qzG6D788dN6f?= =?us-ascii?Q?qzdAJpFvXTBAqg8+IMHQpPFNSMeefyQlI4tBTcboGxi5e47lajBbITLXHOvp?= =?us-ascii?Q?wyMrPxVrod5AKPWdVWsuEMBRqJ++bzfgmoBGLQuul87NZbBsQ2N6aYgCDjIZ?= =?us-ascii?Q?e6Qx1exLDewoGNPI8P+T/Jgy7v0NyuSHyWKDYrzjwSy7lMQ27LFoKwzkgCgN?= =?us-ascii?Q?aLeA40MAOuW05AF/K65ydnSdi9WfLhvU2lDy39FXa7A/Omhc99KRgOKl3LqR?= =?us-ascii?Q?sAG+9n4He8MeEzXqfEuQ8XU/oPVCENzc?= X-Forefront-Antispam-Report: CIP:58.252.5.68;CTRY:CN;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.oppo.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(1800799024)(7416014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2024 02:13:52.5847 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25631ec3-8cad-416e-7993-08dcc63de594 X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f1905eb1-c353-41c5-9516-62b4a54b5ee6;Ip=[58.252.5.68];Helo=[mail.oppo.com] X-MS-Exchange-CrossTenant-AuthSource: SG2PEPF000B66D0.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR02MB7097 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 297B4C0018 X-Stat-Signature: 63hoki15pgs9xya4h3ywqaguscbxmd9r X-Rspam-User: X-HE-Tag: 1724724842-86595 X-HE-Meta: U2FsdGVkX1/c4/KXHejIM79oOlZdHPSVkcHoLrCeHk1xfKEGuUf3onyfbQorWmEnfyMSofwkunukhjpzvmyZKtRfYV31nbckJeiEkM7Ki1g8P8Ux/eJbQ6yTo3kEoFdRil+K9oHwZdZ11qjzFcEBbAIG1C+X3ZuRxLSbnXmehsTwye3TcXyhR6UqWMNP/Ll1k9iFf2F8ZKANiED9IxgI3o9SeeUfZy43b8P8e0lT/P4lbnMD5fellhgg231IAatmJnSxYo62SnB9fZHQneYerVaSlZd6cYjbhDsR8PmrJFdZsOUh86fzTguQ5e1zvP/KRndaYxxxytjh47cDge1JDP9Aj//tBotgLpjPsiWnZqjXEoxcvK95iu7AC0idoCmwjnUYxhxf24oNKolBH7FYy9CxI0n/AHyACzHyJtbH/K94auLBZ5b4nHM1C8NigIWHuCtQkiDFjT2j/roSTUwuOMavnUI4n9/b172PdhZgIj2+S6htKKKs2HzlzThheyssuXiO/V3w6gsBoCpIuNsGJ7m4Z4CUy1QXOn34cfir9VNtOV2kBFwRSZ8L7taz1nYfTSxztzT3OCRjjuyR7iq2GhXd6K6QpxWRW0YoqMayatB0lYU/Pg07ZHePBdaa1wyv5IwDUaF2MpFDaA9vcZZZvY5s6qse6J9Cq8C6jilJTwXLZlWgAacQzSmjZMoVr7EVGP9AD4OrieQAc3/sPbk7kqafTgt0Mse19N56mYRCG+5bf0NPFAlkx3ri/6LeLiBHlrNpQkrzXotA7qi58cdG34Lg6e9FS4rQBpWDZXg9mIYH2lJzpj20UQZgLlaF0vM4vA/AGlAe3twOMVQOAZ0/SKU9JoaLlPRGe6LsfybUESfM8fYb7LMO73omAXl0tCk0RWp67fN0VVNW4UlwH6ah9HThPoPMOurbCH8Sa4QccpqObkGFl4TFBlFbdJs6kGBtZ9Iwm5ra0V8lT9OsnHx lSymgbYX aGvIbX13EWMlBXsvM27ssVQx22sI2xTHkevqLBZj8qr7sVTuP+iyRox5rLWWGJkF8wFg+5gzbyCl7WA0OIIo8IoHMou7YPXUBdH8U4nIeQZh/TJLYXDx/VG2nb1Wpo0Adwu6kQ/Ga9KV2Q0MhtywQ7WUsf7W3Uz3k9ZlG19SD5vv95GoMlMEvTkyOoUDLhL+6k5ewXu4lE7wvrQrzqzh3u8MUeM/zEUt+3wiKvZXTqEB/I7UVa9JLLLVH17WTCliJmnO8XAWT4kq7G8L7MHGWqzGcizr71vkoYdSqMQvvLa1Sv4n4QYhbuFolNOBmE78PgUV/gtyhGSg99tzuY7kvPUPjTRNQWx8uVTXM5knwJg53CPkJ98PCAkJdgyN/7Mg3nUj5r2k+70EvNjIAUEwEWbsw+W91+d6Bo23sJvXvZ++qHySt0kt32zTx0xeCX1Rf7gzIi42zF/EBt/ymvSUbxG2PpvLOsYMRFzuH09e3T1jCS+c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 26. Aug 09:37, Lokesh Gidra wrote: > > IMHO, within LRU_INACTIVE_FILE, MADV_FREE'ed pages should be > prioritized for reclamation over file ones. > > > > Adding Lokesh. > > Lokesh, could you please comment on the reasoning behind the above > > mentioned change? > > Adding Nicolas as well, in case he wants to add something. IMHO, lruvec_add_folio is enough. if lruvec_add_folio_tail why not use MADV_DONTNEED instead? In MM the reclaim policy prefer to reclaim file cache, if MADV_FREE'd pages directly add to the tail, they might be reclaimed instantly. Also the benefit of workingset_refault_file cannot be convinced for me. So we should know the reasons and the benefits of the changes. page faults or ? > > > > > > > > > > > > > -- > > > > Michal Hocko > > > > SUSE Labs > > > > > > > > > > Thanks > > > Barry > -- Help you, Help me, Hailong.