From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1975BC5321E for ; Mon, 26 Aug 2024 15:01:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86C736B0088; Mon, 26 Aug 2024 11:01:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81D1D6B008C; Mon, 26 Aug 2024 11:01:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70B146B0092; Mon, 26 Aug 2024 11:01:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 52BDD6B0088 for ; Mon, 26 Aug 2024 11:01:52 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B584C412A5 for ; Mon, 26 Aug 2024 15:01:51 +0000 (UTC) X-FDA: 82494711222.12.F0C1397 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf03.hostedemail.com (Postfix) with ESMTP id 4C0DD20038 for ; Mon, 26 Aug 2024 15:01:47 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=VkXBgwvi; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf03.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724684413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5yXLWDQCZ5TK80/zWFIY2TSxF4QwKlkw5RXpKLYOLgM=; b=SaFqP3+k1o8d1P0MO6Zc5eswb5dD3g4T7Qlhj2Gt2Bg8+IMgsEa8J46JCVDPBRe3XpnVes ZlX3KLAllb0bVo2Y4tBJpeBJNfIdb45fDUROzQisXYkBp9wUp5uEedlSx6n1JRe+07oQnk DvBroN0d5Z0T0WV236hgow3E5ALT2QE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724684413; a=rsa-sha256; cv=none; b=OiIFUytu3n07yilxFANmDEyTSP+7MmojdKefs8SVWCUziTMp1PB59TOTJ6yOdBLiXS2hBK CH2vgw0L9MAH4KQGWFQZWbMZX6I+fsK/vjRQkQFVZHVLVJJ8xMWun2EQL13rMgaIWR7WrW xLT61THzmlN1+0lrIIhbNHIyJjyizVI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=VkXBgwvi; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf03.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4Wsv5g1cLsz9svW; Mon, 26 Aug 2024 17:01:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1724684503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5yXLWDQCZ5TK80/zWFIY2TSxF4QwKlkw5RXpKLYOLgM=; b=VkXBgwvizjFv4gZcT25+rPkj6gmAtxLp9+dGtSIvUOs1NoI3Ea84US7yl7RS/exadB9d68 wHeXj+UUQhGFzkVW1xW7Q+utTSuxkm8imagvFVFOuWPwypxlH8S1ASL9g7SeID6ePFzG/G +nlxzhHZGezrnPmFBawnhAjukn7+/5kgoVyfDEnDe/e3dVlf9YjBmGwrS9wFfbyfy+n64w It3bMogpdAyYK3D5i1eHg5soC8YsGKp9NxBJgITLRI4za36o5ss4Wl9mtkY2mEsJCFyqP8 cN9shsFq8hvV2pX4bCO2G8SyJa6B4Tef2IadQUW5ReMnrWhXdXc23TIW2+KtYg== Date: Mon, 26 Aug 2024 15:01:38 +0000 From: "Pankaj Raghav (Samsung)" To: Zi Yan Cc: Shuah Khan , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, mcgrof@kernel.org, gost.dev@samsung.com, linux-kselftest@vger.kernel.org, Pankaj Raghav Subject: Re: [PATCH] selftests/mm: do not try to split below filesystem block size Message-ID: <20240826150138.xi3jmtylcej2m6ff@quentin> References: <20240826145344.33665-1-kernel@pankajraghav.com> <340DCD7C-8456-4F5B-B503-9DF5903C16DA@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <340DCD7C-8456-4F5B-B503-9DF5903C16DA@nvidia.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4C0DD20038 X-Stat-Signature: ew5ph86njcdkmzkw6wghk8gg8ia4k8s9 X-Rspam-User: X-HE-Tag: 1724684507-238957 X-HE-Meta: U2FsdGVkX1/fPoj1sCfPxC1VqE9uBQmMTbHZnrE/kZIdndWpbmM9grpwOR5pHFJgOqEdx+qB5UGA/fObzBB7q4fkdp6kvolc4LTz0e/X0M4HsAnPXZqsuU4ja69HguSIsUZA7r5/j2GD06dj94l9J5zBa6d6xBGgmYpvA6cExCUsnIymXVe4RKZRICtnco+dVKWg66GDzuzFLCkpdl5DXkRDpg9T/9N5aF5Eax/eRLuiIJvtg95UUzLMB4FoLPZGt9toDnFlo3TAPNfml7xkHmRlVGNOIGDIcs9MvVu9ZYqaTDXXrkFIJcohDCRMkJN4WNE4M5jLOt8/3iMAlVQ9VGVvr9tmuKJmDK7tebuO9ll6N/VixAop8cgesJjr6yWDTNXxPBKgy9b6TJaTVoDgL4kaDJTD+LHXcyh6tGTzm5/tMv/SXndEP6Y6Bbc2Q1v1ffFeRLcRPcFfGCwkvyi9f9nBWE3lyje1SkqUA5B4pk1KH+o7+gkTo62ScCv6Mj6SB2T1xX1RUj2IYEPYfC4PIaMaJq3q3Fx+IdlAZo7Ld1kUTC5NLrOfgPIaZ2+elDAAu1UjyinGWGywdEQa3dx2V7/d2lYQ5MloNa2OkSXDJXuy2RkrlrDFN7OoWGQGjwwSS5cYRYWn/IQp/k2IcgFzfZ8BHF8mv3KdqN+XkIIfDdMrrgkReWjJMQk0Hdx/nTdgIk6xDmLswH+yKrMaCypObAUs0vys5yeLcfCbRP1239AJbYHVwib6tttqTcdROMZN1NmDvTUzLIN/X02kpg4htIR/9arSNiP3LSMddbIdXbI1jt6zgqZDhNjj9RR/V/kWV2QVyp+6dPUSgi1xGbXJP8wLE+FU8esri8sKlcLm56+0nkkk6MQSV5KrvixG5f+kae05bprH5fh32/77P7yit4mObKx0RhyCmVsvmyN7Vuw4q/0DxMV1iXBeH0mv4l1AhuaYM1l2XZdsyF4zL/E FKYpyY4Z rmYWmrb6ngLntniG0CrsgItz30BWAyDOIV7PgMUwIr0YxiKzFL8k8LMHU5/zmBN5W5xJy393Yh6Q1owl7dilw7Fv3B7nbrpcKlvPVZU/GLFTIZafzfN6IqQRZxrkk5PlHVNC7byz5UR0N9XPPH56cS+LfR9WIN3wcnZ9RZbpwxViVOrT7q93tgG4+0UPaf9bqVoJWphnyAzLAfV3yk5N6AYivagTL5X1VuBMMRVkZIIKWFh+EKh2kaZOWN7vVDYsQcvpAEepsVs3nSvnKbmAVW3Ui8ARGezCoD9HvnxUc4cPnBiDWaBJobm5txtEB2NiyYRFGINxnsQm/7jLGEeijO25PcTxyWu/YvkYMpI9pbG1nCPwFLGkZXn4/MviSgNix2UybGwttDFZ5H3c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 26, 2024 at 10:59:16AM -0400, Zi Yan wrote: > On 26 Aug 2024, at 10:53, Pankaj Raghav (Samsung) wrote: > > > From: Pankaj Raghav > > > > There is no point trying to split pagecache thp below the blocksize of > > the filesystem as that is the minimum order that pagecache needs to > > maintain to support blocksizes greater than pagesize [1]. > > But the purpose of the tests is to make sure all cases are properly handled, > right? If we do not test splitting pagecache large folio below the > block size, we will never know if a kernel change breaks the handling. > > Just my two cents. That is a fair point. Let's ignore this patch then :) > > > > > Set the lower limit for the splitting order to be the fs blocksize > > order. > > > > As the number of tests will now depend on the minimum splitting order, > > move the file preparation before calling ksft_set_plan(). > > > > [1] https://lore.kernel.org/linux-fsdevel/20240822135018.1931258-1-kernel@pankajraghav.com/ > > > > Signed-off-by: Pankaj Raghav > > --- > > .../selftests/mm/split_huge_page_test.c | 19 +++++++++++++------ > > 1 file changed, 13 insertions(+), 6 deletions(-) > > > -- > Best Regards, > Yan, Zi -- Pankaj Raghav