From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80957C5321D for ; Mon, 26 Aug 2024 17:28:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF2CE6B0082; Mon, 26 Aug 2024 13:28:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA3276B0083; Mon, 26 Aug 2024 13:28:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6AC36B0085; Mon, 26 Aug 2024 13:28:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B75CD6B0082 for ; Mon, 26 Aug 2024 13:28:40 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5B8471C4821 for ; Mon, 26 Aug 2024 17:28:40 +0000 (UTC) X-FDA: 82495081200.20.4FCA6BF Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf24.hostedemail.com (Postfix) with ESMTP id B057618001A for ; Mon, 26 Aug 2024 17:28:38 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of "SRS0=3PKx=PZ=goodmis.org=rostedt@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=3PKx=PZ=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724693204; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ZWLg5+gQ2MC14u4w9y/ExKKPt6x5L9tkEAX3YeiJo0=; b=gh442oWoWwW7cTeoKetNLTuez1P4Eyr2bOS7QHW4C5vQmJVyxHo3FCHB3Rz9M3baoaFMVs RdTs/tZM6bbVPX7qHryoXm1FO/muXf/7auKEauRrgxmK6O+tueYdIgryyuJr/1+8zS2efl o/zP2TQ/23+GV+YizyTCXWrZv7M1ecU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of "SRS0=3PKx=PZ=goodmis.org=rostedt@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=3PKx=PZ=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724693204; a=rsa-sha256; cv=none; b=YCuRqQBJa6YIcGEnNz5WDRcMrvkELaNGtQebskXKTNUOGSPEJTDJzQPrdKTQ4ZJ6CjlswU 3Qdffxfk1TtpvparfX3Le7/mZOKJcj+yFwQmNx31m+84UKLOKPM1PdiwJlRYFlhSpakWxf wXdGKQTwShMM+Fr98sqF57g/fof5MuI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B3469A40480; Mon, 26 Aug 2024 17:28:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0E6AC8B7B5; Mon, 26 Aug 2024 17:28:29 +0000 (UTC) Date: Mon, 26 Aug 2024 13:29:09 -0400 From: Steven Rostedt To: Mike Rapoport Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 5/8] ftrace: Add swap_func to ftrace_process_locs() Message-ID: <20240826132909.306b08fc@gandalf.local.home> In-Reply-To: <20240826065532.2618273-6-rppt@kernel.org> References: <20240826065532.2618273-1-rppt@kernel.org> <20240826065532.2618273-6-rppt@kernel.org> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B057618001A X-Stat-Signature: ytdpibqys5zc9zj7wbe94cuieu4tgn8a X-Rspam-User: X-HE-Tag: 1724693318-289746 X-HE-Meta: U2FsdGVkX19lS2tWkbuZTvA/wjcSgRLZcpnJIfjUWqzP/15TlUoQ1a2tckG+9LWvAeIsRItSIJDfrIkspurlRvB0Nv53TTEPSOZWY0TsOracC4wsHVUL1GxiGxs15xKnnGistDuJOH8iI0GZ9RiOni31GTqbNN3hNwwKTemk8X2a1c3PGKuwZtfz9ntgICsZ5cRj/VycX9xB5WKm2LQ78gl8qboizVblEJWpFynxMT+WJ0k6zLwXtMuM/EOUCNVZRs8knfoOgyXQKhXFFUr2eEEVXm3af+ueZJosVub/kwzTxc8PEWqG8zU2YcVdRyGIv/iIkNFFO9JlU4TeNEQDuMAam7RAh8cQLyyk9X/Mo7/czVNxPCJan1KPg2w12+Ma1frD2adwUN3hndIFAENTDqzhcmlPwCB/x0o4DpyVi8j4pj1lL+jJg6Yno3XAw9+l2qpCu6C0HghDv9irNOa0vaegSpL5fCKkiZzucHrdDUmechDBVVGf2wNo8g5tcRjBK8U8aKApSmDWV/69mfqNmpRJqWV8X+SRIO96cSlVR43V+GZba963+WwUgvzPYFYHxMK938QWvMFTgzRLeUeL4MsyUjj7dDeyv6RCTT+uWmrmHByQ2EbZUGy+qQBex/oKN09lc4Idnt98vqV3tLIxxWYWKUazUFsCufN53ay9q4SvSjB5PoUHLH41S2nK55vKZn5bvNxKxtYhYP1I5fpjxP4k4hdDSA6GRquWW+/HHohYPW8rv8Y9U3BORxvzogH2dAJUmcMoHjIoVnXrjJM53DDCcbCD7bj9st0HtBih612Nu29WHwuaRVs3aDhj/H9J8fZtNQKGjg0i1jhrl+XYwbwLBFSfkD/dAXIBCZ2CzhFYeTpzLYKWadvzY9rkPZFuxDXcZ/V2y/WHRlVwfnzSWBx8Cb+HfCQBM378CC9As3OxZz7Yuw5rAowS6dUezXZbgtG51FPzEA7iX0ivQaS CxMlmDp0 07BP2aPD60EQX722VS2lanY4GLaTZxaErFUGRt9PhIjFOR7GPTXxpPTHbiuNFG/MHA/tBRHi7Ym2v2YYAlKBq7zlYD7uvNHVy+PwKKOCF8Y93MguD4MTZO/THf5oqDby7QzVD68zbfyTzXxOxZHmaw3ila0u6noZ5C9i4xdSfDMplXZpJRHoFLob+E6QYkeVc6EfhzRwkkoYkf3ClL6Vlr61Dk9AjWNZjKPm5uXSBNdCDufbihUxgCcZyPbl5CLxhS4c8DGSdW+ysBt5tfAo7mOY6S5iJP4Bc+2ys14UHhdjl27u+SjzPEW7N2kX6BTdzt9G/i5YjCzknc793BNceZDlwOqUHrvDDIyca X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 26 Aug 2024 09:55:29 +0300 Mike Rapoport wrote: > From: Song Liu > > ftrace_process_locs sorts module mcount, which is inside RO memory. Add a > ftrace_swap_func so that archs can use RO-memory-poke function to do the > sorting. Can you add the above as a comment above the ftrace_swap_func() function? Thanks, -- Steve > > Signed-off-by: Song Liu > Signed-off-by: Mike Rapoport (Microsoft) > --- > include/linux/ftrace.h | 2 ++ > kernel/trace/ftrace.c | 13 ++++++++++++- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > index fd5e84d0ec47..b794dcb7cae8 100644 > --- a/include/linux/ftrace.h > +++ b/include/linux/ftrace.h > @@ -1188,4 +1188,6 @@ unsigned long arch_syscall_addr(int nr); > > #endif /* CONFIG_FTRACE_SYSCALLS */ > > +void ftrace_swap_func(void *a, void *b, int n); > + > #endif /* _LINUX_FTRACE_H */ > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index 4c28dd177ca6..9829979f3a46 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -6989,6 +6989,17 @@ static void test_is_sorted(unsigned long *start, > unsigned long count) } > #endif > > +void __weak ftrace_swap_func(void *a, void *b, int n) > +{ > + unsigned long t; > + > + WARN_ON_ONCE(n != sizeof(t)); > + > + t = *((unsigned long *)a); > + *(unsigned long *)a = *(unsigned long *)b; > + *(unsigned long *)b = t; > +} > + > static int ftrace_process_locs(struct module *mod, > unsigned long *start, > unsigned long *end) > @@ -7016,7 +7027,7 @@ static int ftrace_process_locs(struct module *mod, > */ > if (!IS_ENABLED(CONFIG_BUILDTIME_MCOUNT_SORT) || mod) { > sort(start, count, sizeof(*start), > - ftrace_cmp_ips, NULL); > + ftrace_cmp_ips, ftrace_swap_func); > } else { > test_is_sorted(start, count); > }