From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 715D6C5472E for ; Mon, 26 Aug 2024 19:56:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B9316B007B; Mon, 26 Aug 2024 15:56:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0695D6B0082; Mon, 26 Aug 2024 15:56:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4BD86B008C; Mon, 26 Aug 2024 15:56:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CD4A86B007B for ; Mon, 26 Aug 2024 15:56:04 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 80C061C5068 for ; Mon, 26 Aug 2024 19:56:04 +0000 (UTC) X-FDA: 82495452648.13.0108AD2 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf03.hostedemail.com (Postfix) with ESMTP id E73AA20006 for ; Mon, 26 Aug 2024 19:56:01 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HXaV5LWE; spf=pass (imf03.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724702076; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E15D2Mknh1QyQDi3ZTIQmOrmVZKTA/fw3Y41vjsYxkQ=; b=SqQpTXMT/gaju5/I62LhM8bxW48H70DU5n+kBiu2miPPJNDPhDGsAkdIZAvNoJX9iud4tp CarAt41ovkTCiPoM+DlN6whrk5q5EjXEqdnUvkHYSHddQ9zls0R1Ei3F3+rFnCw4+K56+a k4basM983EGlOR1/ueDERoHbEgD1sv0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724702076; a=rsa-sha256; cv=none; b=vQ+GYwHcvYLPGlsUJtAr3dly0oYN6TeEeOpbicS77aB/gA6P00XRK6xUsFlRmmu9HR5CB3 Tj06hCfFPhUmzUMYLCRfgCa8xpLyQGh9Uw+e84KFbM7ty7W/TZvjRtYGtmU/GARX5mAL1L Qtm8p9T1rrMygUr9G7R4C9+GBZecLSg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HXaV5LWE; spf=pass (imf03.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3D687A40B23; Mon, 26 Aug 2024 19:55:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC7F3C4FE89; Mon, 26 Aug 2024 19:56:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724702161; bh=wGxjIAFTwaejtggHWXZuDgCwxLBZTkCB+uUES7gFwb8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HXaV5LWEmT/LQFxPV7jriO64KkTHVHIDB+Kh84aqyOUbOqdBKinLhWxW7v30qsDfi T1XDZPsseN1rThL7/E6jaosenWAA941LR77fR1KqQSBL7C6sy9olEfqnDDVUBND/Xu qbtrUfkB/B0RVU5r96622EogXGyMd6kHDIdGGPCWKXmiK3hz8J83yXiG+m+CLsF0IO fHMMNJUru2Lzj0DGZKkW71Pt0K+Z4XHFz1qG079OoRWkmU2EzpPlbQnUR2g+nB2mnX sYPXL7gCe9ZdWxuDBNve0okHBMc7z9hIGnFaPMOXnULU1tNDg1eMBG5GM4mZ24K9jZ P/ZDbLRuoCqQw== Date: Mon, 26 Aug 2024 12:56:00 -0700 From: Kees Cook To: Kaixiong Yu Cc: akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, paul@paul-moore.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, wangkefeng.wang@huawei.com Subject: Re: [PATCH -next 12/15] fs: dcache: move the sysctl into its own file Message-ID: <202408261253.D155EA0@keescook> References: <20240826120449.1666461-1-yukaixiong@huawei.com> <20240826120449.1666461-13-yukaixiong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240826120449.1666461-13-yukaixiong@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E73AA20006 X-Stat-Signature: ksugjrbrrfiakkoy5u9xuduspsb7wuhj X-HE-Tag: 1724702161-306879 X-HE-Meta: U2FsdGVkX18kljM5Ks3x+CW6xYh3ps7ItXtdrYmG3SdwM4rVJOMNk88/0rCee2N7STSO15q2mvxhyS/lheHKpPVraFzRlKJ6FP9H+rGEFiMZCU1O0diNvlCsz2l860g5KUn26m/RVtI/V6e+XTszcnrOkUNa4c/yKxd1WeXVYGfSSoglh8pY0AKEpE0502jx85D7d/h3tqneunJ2l9R4A3tMx+N6B1ROoDrYtYdPS7kJJ2nAAfuusQkEIvWDML7G5GxXY7y7q6rqajQX5szgrmMr1ngyo4fTmj81skP22Tx0idNhGOab0e9cQUMFyWN3sZO7PHK0qZX0aZDdZpScvriMCghFBkZPTZf3jagGaXplo+prY3nCGOUVFyZAh4PHCjzzvN9k7MS3kpDvRqSNQtCDobjVPmxuRHAF7cu4lMOJsDpuFYf+HLYS7Q+Q813ZBhcTBedijmnm1gPEfEeZQnICm720ZOUFjklqk7uQfKPOtltRrOMlVGBcJkZPuvp6/VFN4AxWD6sRZ3lXr9x8A5f1r4hDgFMTgdN8yckINAti7B7yLn4YcNUvhgFsowSDJthwZHWREDu2Rd5is5XgSgHCzRqn0ypJww94q0q+Mi97e1V6ocTBrPyTNzLT18cUy7fxiCY0+Akfxq4YbdUZ3GVeE0gfDdXLWk84IJyR9v/031DsqWOmg+q9vzKuwkOlR3XpLuclGKtKupzxagVCcGnPh1GFNs8Lo4RIN+aGqBiqUpE2FuENzk5x3Mkl+OHxYr9omXQSXg0EU61FPF6o5yv0BLQqA/0idckYqGSFFBtN33msB+skia0PBM0r8N+eMPpNpl80nnLOjLqy75mQ3+DPJNubRrC8XY4pd1/UqcfvN5Spl+RhGhOsP0//K+Z7SwQYwRYtx3DaFoafw96RlwIyo0aCpETEeBzouGTdlqqEoy3yhrP5mbJjDzt5UlfwXWSRnR0lA8g7nS7Ji66 DGqGiM2t XENAbQ7bbNL8FjFDXtUFs9D3v9cSFkAFcxWU4wXWZZ950Eetj5OPM7Q9plBWsfO9Npr6jkA99zj65onuAKzEuIbHdC/0FLpO7UtSxUsV9RPjErPtcZuhiVSSGSDOXnB/QwB5YqgMrAd1WGm4DCAN+aI5g7PQ3qGB+VEA/3rNWSBkWmyK9XWB/4S4qTj/8gt6m1/npQuDbhaqgqRIVKGOEdlxsYGVyex17X2ZByihMv5QjuiwbVp/warTpExLpf/nGg54d X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 26, 2024 at 08:04:46PM +0800, Kaixiong Yu wrote: > The sysctl_vfs_cache_pressure belongs to fs/dcache.c, move it to > its own file from kernel/sysctl.c. As a part of fs/dcache.c cleaning, > sysctl_vfs_cache_pressure is changed to a static variable, and export > vfs_pressure_ratio with EXPORT_SYMBOL_GPL to be used by other files. > And move the unneeded include(linux/dcache.h). > > Signed-off-by: Kaixiong Yu > --- > fs/dcache.c | 21 +++++++++++++++++++-- > include/linux/dcache.h | 7 +------ > kernel/sysctl.c | 9 --------- > 3 files changed, 20 insertions(+), 17 deletions(-) > > diff --git a/fs/dcache.c b/fs/dcache.c > index 1af75fa68638..8717d5026cda 100644 > --- a/fs/dcache.c > +++ b/fs/dcache.c > @@ -73,8 +73,13 @@ > * If no ancestor relationship: > * arbitrary, since it's serialized on rename_lock > */ > -int sysctl_vfs_cache_pressure __read_mostly = 100; > -EXPORT_SYMBOL_GPL(sysctl_vfs_cache_pressure); > +static int sysctl_vfs_cache_pressure __read_mostly = 100; > + > +unsigned long vfs_pressure_ratio(unsigned long val) > +{ > + return mult_frac(val, sysctl_vfs_cache_pressure, 100); > +} > +EXPORT_SYMBOL_GPL(vfs_pressure_ratio); This was a static inline, but AFAICT it's only called through alloc_super() which is hardly "fast path". If this series gets another version it may be worth calling out this inline->out-of-line change in the commit log. I don't think it's a blocker, but I'm not a VFS maintainer. :) -- Kees Cook