From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C209AC52D6F for ; Sat, 24 Aug 2024 05:36:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18BBE800DF; Sat, 24 Aug 2024 01:36:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0ED5A800D4; Sat, 24 Aug 2024 01:36:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECFDF800DF; Sat, 24 Aug 2024 01:36:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C7C77800D4 for ; Sat, 24 Aug 2024 01:36:08 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3A1AA140372 for ; Sat, 24 Aug 2024 05:36:08 +0000 (UTC) X-FDA: 82486028016.16.E8389A1 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf22.hostedemail.com (Postfix) with ESMTP id 20298C0008 for ; Sat, 24 Aug 2024 05:36:05 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pLTM6v2V; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724477705; a=rsa-sha256; cv=none; b=y1ar9fXtCVhLIZpgdhQI/D90L7RtU+MccZhrUz6hA2OtfOa3BkKC7q6AE514/zTVkWPAWa N6rbpW066nCz13NHqwNUnDwloKLQyoY9HyBZ1dzlYya5el8pegoc8Ya+fj5jQ5HZaI5KL+ kEApHfJmGbfhRe+RcXxt150HgElfeG4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pLTM6v2V; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724477705; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4U0v60aO4rejTgBJGz/q69NNLi4cX41CrlHkeSC5BdE=; b=Q1O8lEb4cIP3wlixSFWGjqRKI3Cu9ptC1d2vZcF8hGbzKJPDEEu89WDy8cunIVxsKQFfCv LmifKhbLC6oiOM5cm09i/sQ+Z7qbB6CifYUcQdgRHlQQrKnM4T1aek0h+6xjDuatKuPoCA Nv74EYcw7mQuB1TYnYgeuIpdomU5+SM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8063CCE10E3; Sat, 24 Aug 2024 05:36:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79CBCC32781; Sat, 24 Aug 2024 05:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1724477760; bh=vtXQXw/8L9O0i6cAOddVaHqj3PWX+5FxjtO9SYBADHU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pLTM6v2V+3RtGsuAPNGUUwzYB5ZIshkeajozAWlPTfe3uD9vsCRuYp/Av+2dJ9mgt gQvT4ZkPw5zXkwV98+dvxt5fFrEUVAjlOQ8JjqGjFkyIXjBLmvvBMO32v0BYRPRL0R EP2FXdptBA1kFuWBKOzEosKqQ9/lxzTYxX2R11B4= Date: Fri, 23 Aug 2024 22:35:59 -0700 From: Andrew Morton To: Zhiguo Jiang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, oe-lkp@lists.linux.dev, lkp@intel.com, opensource.kernel@vivo.com Subject: Re: [PATCH v2] vma remove the unneeded avc bound with non-CoWed folio Message-Id: <20240823223559.942b53cea16d5cfc6b70bf2d@linux-foundation.org> In-Reply-To: <20240823150206.565-1-justinjiang@vivo.com> References: <20240823150206.565-1-justinjiang@vivo.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 20298C0008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: x4rafqgan443ejiomauhpi7ygz9zfts1 X-HE-Tag: 1724477765-329277 X-HE-Meta: U2FsdGVkX1/sJm9TiNXP1pE/1ltc9BO/Ejh/JzpECGUDR7ROqUQ/Fy9RbSNemlExDAW+IBgG0gRjJcvVu4OHMIfNm/8xTqG/Pnv0eAsW1ORDqT5Z9HPYMNYM3LQxjGE6ECRc3q/7vlLXU3PWBxRiCbaN/XXP0ZeeFiviFD5ce00IxJrQWxuHAGC042GoxhoyCFhZEyTZ+FSTOYxvm0vrj672yAfqxHLrKnF64KXGrjE1hn2Pt/hvq+pdpVYN61CnbLIZMDDtt0lNFKtRWRsVMQ7YVqT7zcp4qKYasne6Fh5iI5yndYv44JOpshIPXWXNMAVG7nLT6F++GH2LbsWDm9zKHNBrM7OxG59nMo9gf9YnPVs+ixjptBsdg3+il36/ertlpLi1tLGK6eqdpUho+GP1datzsrYm/cDTbMhziY+dV0jW5fPUuc2GWEDeXlwMLYxbhR4Tu8AW1XnsXojfwbnlnh23jqiZsEreIbVMzB3e2W67m6d1DzqrqZ3n+jQNmfY2Q4fv6gBvoVUCszCrq45Tb/Xqp6dU6xJipMrdENR+AFqHls+jnJIXTpy9djm3hFDQA/5+EehRSXrMcMdvv9WloKZ0hrp6j19dOXmsJzlzyALDhcWZJ8qQvB/9L/UooPaWQHZmbqoTDlyYZdCTGSLq6HtoF/juI+hHU2Y4dATLSSl2/jXOt0xcZf3ACs/WmBuewCTVF3rUhnRMv92OgYcme3bln/+k+BrL4d+0Eu3UBhS+Db2lWOfpludmVyUav7bRXa1ihFyG+QMIXrYs4N9bX8RyHG+HjLta6ZGFazt2A+iFzF+krIys2WIybv/tRjE58rJeRU5b2QlbuI6zW+9I8mQpSyc9P2LmbSWFGwGtcTWOhxykvcdpM8xGiB0IvsWXUPnDtSt8nHmdjEjAE0IYo0FFhWEGtMo3BzLfvmAz7sJKq4XkuYxoCrZwsn/+cPuuhU0AkwHh0Rpt88A EqPtvt+G RjTcjtui1kx3HoaOWso2FObhIEm3KEQ3WAnv6y6f4NK/rguA5Shd2mbtLSI8M2ozvfjgaI8kYMo06n+jQ4nIn+CwkFCGHSujkW8PpPuGd93WRYHqfmiU9ReNRAKv5JEcaA6dVRGrUx6OqbMH0VAOBgfYvuzmXmhaFnZ4etDvvwH7YzvLZbGZ/WQQnqedzDCk0EJIjrIZp1IvTyivihrPCxV/SZSBuwJ7Lbv/35JRBCfKaYM4sWInD61qq7D3fCCLpPvUTiOpAhW7cSqxPhLPyRrOVhA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 23 Aug 2024 23:02:06 +0800 Zhiguo Jiang wrote: > After CoWed by do_wp_page, the vma established a new mapping relationship > with the CoWed folio instead of the non-CoWed folio. However, regarding > the situation where vma->anon_vma and the non-CoWed folio's anon_vma are > not same, the avc binding relationship between them will no longer be > needed, so it is issue for the avc binding relationship still existing > between them. > > This patch will remove the avc binding relationship between vma and the > non-CoWed folio's anon_vma, which each has their own independent > anon_vma. It can also alleviates rmap overhead simultaneously. I assume any performance benefits are unmeasurable? I'll queue it for testing and shall await reviewer input. > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1522,6 +1522,59 @@ void folio_add_file_rmap_pmd(struct folio *folio, struct page *page, > #endif > } > > +/** > + * folio_remove_anon_avc - remove the avc binding relationship between > + * folio and vma with different anon_vmas. > + * @folio: The folio with anon_vma to remove the binded avc from > + * @vma: The vm area to remove the binded avc with folio's anon_vma > + * > + * The caller is currently used for CoWed scene. > + */ > +void folio_remove_anon_avc(struct folio *folio, > + struct vm_area_struct *vma) > +{ > > ... > In mm-unstable a lot of vma functions have been moved into the new file mm/vma.c. I suspect folio_remove_anon_avc() should be there also?