From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2687C531DC for ; Fri, 23 Aug 2024 17:08:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E4576B0162; Fri, 23 Aug 2024 13:08:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06E6B6B0165; Fri, 23 Aug 2024 13:08:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E28D66B0163; Fri, 23 Aug 2024 13:08:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C0522800B4 for ; Fri, 23 Aug 2024 13:08:47 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6299A1216AC for ; Fri, 23 Aug 2024 17:08:47 +0000 (UTC) X-FDA: 82484144694.01.E561962 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 8088240009 for ; Fri, 23 Aug 2024 17:08:45 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fMDDMyCO; spf=pass (imf01.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724432908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ln8zCAp2BKtK4D9ABYeu9MpiwqvQQYwtrKiCWQN+Q4w=; b=sOzXOld8fIZZwibpXf8Ws/AWKxG55etTHUk9inkaEfphy023cQa/j4ZDb13/eRlLWFDIV3 sz9PMKIoEPRvO+QDOsYqwGygoZ8bIcUkePEPzluHnQyPYEWbQKIJAwRYCdrAourNz0V44L CY262+z4XM9pHBTe4CrUkdxT+JaejBE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fMDDMyCO; spf=pass (imf01.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724432908; a=rsa-sha256; cv=none; b=3I8efZApWoOStt+QhsyQkDJ0G58WxWUUWmVMC+fPSvbcN081cwJNfeMrVCacqENkFNTQhR rxhbdaw+F60d10UvOAb7/IrEJ4t1MI4NOD0bR5yGW4bfnfBxt5ENK3DLAKUBkvfywoX+H+ JWPfMvDHyuSYyKR9jvdloHskM0E0F3Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7646860B54; Fri, 23 Aug 2024 17:08:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D713C32786; Fri, 23 Aug 2024 17:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724432924; bh=RihPOGh9p93UyuuiwT2FCbCPYyy1oUyaWOUKpt8j+K4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fMDDMyCOPVaR0lNY9h3NbsHg2Bdt69cwbY79/e6UXmXBU5kM9OfPR8wvBL7llF20P 4DAQH9IlKKaP662nLGdhQeBT15sTV8EuWxAkbewdCzRnX7moXjhl60oy28w6PIN1up M7u16xXP7PxQzHcK6CmgYx/mbU0XxD2Rr9ABpZeQk193rmnHV78uERlqK0Pf1QkoFl 9rgDnGWcKdC7M8DMgdfRQxN/+zEZ6xOhtnKDPlPHghDbwwXH6FqIsjlhqeTEBYFNKC WIyQSGTSRuHjVeYzUziQ0SMR09W61Qn6ZfAQfwsVYOzqdgMYpfHJLnU3hc/S0GKZCX AgsBhEuIYFm/A== Date: Fri, 23 Aug 2024 18:08:36 +0100 From: Will Deacon To: Catalin Marinas Cc: Joey Gouly , linux-arm-kernel@lists.infradead.org, nd@arm.com, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, anshuman.khandual@arm.com, bp@alien8.de, broonie@kernel.org, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, skhan@linuxfoundation.org, szabolcs.nagy@arm.com, tglx@linutronix.de, x86@kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 06/30] arm64: context switch POR_EL0 register Message-ID: <20240823170835.GA1181@willie-the-truck> References: <20240822151113.1479789-1-joey.gouly@arm.com> <20240822151113.1479789-7-joey.gouly@arm.com> <20240823144531.GH32156@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Stat-Signature: cjck5xfpnppdy5pxjqc5i3quxhpqx4mf X-Rspamd-Queue-Id: 8088240009 X-Rspamd-Server: rspam11 X-HE-Tag: 1724432925-745651 X-HE-Meta: U2FsdGVkX19HyKeMVSw+OGy6LUNtH/o2oDao0xdHxNtvW4XqgzfMU+ytnaHrPF1en7R4dChHmPwpeZK09Iy3tAylP9Y26wwKNYC9VBTw9u+3I95JCBrOtEWseZhfGwipvq5Q+2fbEOGGr7JL/z2HZAIQcKRrsDf6/LeAebXIY3f8LGagGtNFQsx7UZ4XnYGEyRdXLZSoUfwDbwvJkP2wVIxzZUgerLiD+TNDNB3IlMyzCe3SSm9Ce2BtjumKct26aujE5lHe4zGNOxhvbICnL2udh6JIugLbFGIifAVseIGxSbWfNVYst1R74FXQNl3e/JimZp7dxK+vnznSUveXMXOn8J6qi9CamXOGHySEDM5tFMRUAkf/SDLi3mCagLOP1mx/r4XX0/tzUtofL1k0O8+Bq7H1kd6YjrXKAJ5mlpQk2d+gRq21DZX4nO3YSKues/JXzHHz4uFeNUhEFu4MwYAfoo4j24PJFQ6zab1vWgwGn+nkeMj+MjxruWg2NPbpKxiOw2QvYYoJMe2kvZGRfxjy3hNVROwf+sJ2UIU11iXBuPAyKNSK1aVOScdevhZ9rJ7nFzJlNSIWrA8+fQAKDe4jtX+BLJFm6mhw7qQpbmFYQ6zz1QrAyBczRESOco4waAw6/Mp51+LEuOxJAgcoPsC9yxkbFnkcDImYMByHckJPxLy5tP0K7lm1CMGOqfbd41VZw1tRK0Q7wro1ZEot9ECmzNHsiovGZKgPzvzz83n7JzILDlOjYL6wHQ6mdR8bK33Hk1Con7hM0fqcUCjEBuxfr8vxtx5jG2KNgllsL9XFDEGz/fMLjM7eGTtaMxQpbxJHgJCmT36o3LravYCEZThpUkecLA0avi1iFFShDh7Z7CcvEqqltPZAJcshU9SzRIHZxXGyRP35cUxCIAWgs9Qt0375roMZKXJNAiOTPqiR05/HlPWctMmwinJOgxEtVyt3IpQNlJx8TP9zfnI D0muY+s9 Q6sYIxN7NwLXFFoAkiH0TVakelQAbP7eicqXofNKgMV79i3Un7TrRtow0zahyIpgYM7/kZ6r+3Ji6gPXIkpv+JEKXsanWDUGO7TgCmbqrzuhrpuuRt6n0WvjoF1X0c55yAso7ADHrLDLuEe/oRKwJ4Dwf5dQCg7pFYBTMj+j3uc9aIn4xY9UMfWXucWVbxrmnh9LVBurJsyKHWRSc/8F7tU95d6QTcz6l7WHCc0djw9Ev9JpY3oYzNKsBAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 23, 2024 at 05:41:06PM +0100, Catalin Marinas wrote: > On Fri, Aug 23, 2024 at 03:45:32PM +0100, Will Deacon wrote: > > On Thu, Aug 22, 2024 at 04:10:49PM +0100, Joey Gouly wrote: > > > +static void permission_overlay_switch(struct task_struct *next) > > > +{ > > > + if (!system_supports_poe()) > > > + return; > > > + > > > + current->thread.por_el0 = read_sysreg_s(SYS_POR_EL0); > > > + if (current->thread.por_el0 != next->thread.por_el0) { > > > + write_sysreg_s(next->thread.por_el0, SYS_POR_EL0); > > > + /* ISB required for kernel uaccess routines when chaning POR_EL0 */ > > > > nit: typo "chaning". > > > > But more substantially, is this just to prevent spurious faults in the > > context of a new thread using a stale value for POR_EL0? > > Not just prevent faults but enforce the permissions from the new > thread's POR_EL0. The kernel may continue with a uaccess routine from > here, we can't tell. Hmm, I wondered if that was the case. It's a bit weird though, because: - There's a window between switch_mm() and switch_to() where you might reasonably expect to be able to execute uaccess routines - kthread_use_mm() doesn't/can't look at this at all - GUP obviously doesn't care So what do we actually gain by having the uaccess routines honour this? Will