From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 681ACC5321E for ; Fri, 23 Aug 2024 13:42:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE1E280099; Fri, 23 Aug 2024 09:42:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB98480084; Fri, 23 Aug 2024 09:42:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A811780099; Fri, 23 Aug 2024 09:42:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8B00680084 for ; Fri, 23 Aug 2024 09:42:24 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 308B41C6121 for ; Fri, 23 Aug 2024 13:42:24 +0000 (UTC) X-FDA: 82483624608.07.E1C825B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 65F3A40033 for ; Fri, 23 Aug 2024 13:42:21 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=diJF9KTv; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724420474; a=rsa-sha256; cv=none; b=SM5lsdJZQrlrGV9SGobf3kBS1+BV8tdL9JAnhDzTRcPoGgOMv8O9V8nvdI78HBNI9KLWqQ Ci3ldpKfJfrCa5fwNEWZ55KAt9V3O++jeuuJiWWDh/itAeBp2m5Ge0/bPFzBPuXn19rLpq DYewyiYqRxAh/ADT4+eSTbzwPBc0MGs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=diJF9KTv; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724420474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u3GeGGhXiV3KCU8ZkHlXhZAwaxW+4u7XF67wakKYoRs=; b=1701LUm2B2CmNeMECka32AFAf+IKOYPbRm2jKt1Ilk07S2/d7NUUw6STDepLoMgaeeJm5a bFKvJG5+y1fDwn776jEo/TZ+uLSIFWTasjHnju57bgG42flhEMVnTFL3jEsnety6iWLtCo ia2H9kBCpkrcPHJ4ysw+F/cf6bAGWKA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 77010602E2; Fri, 23 Aug 2024 13:42:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56E33C32786; Fri, 23 Aug 2024 13:42:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724420540; bh=p7ZIANVfDlXfoD29LXtd0evBx7y2j+mvpMRvoiijjDI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=diJF9KTvNtOkFxSbJXKbytkFAtignBqhPmYEolOHprLDUViiVjuKDHUVvblLiJoQK cYAq2OFQ1lC4Ob4pfq5sgJpfMW0nC0GYloyNujsF8966uVxZOtpAfbh+JXp4NFAXi6 zGYX9PXuywc/Nn2EaTGKd9Kg3OUZAfcHhEG+bSe3hFweisJRBzWLqXIhMjTnOFsE0k BYfyDcsS8zmIES3CMBMtscVY670iajmo99zrDiLGTOeSpVKhmRvfeA06Kvp3uAINuA cgeKenNlP7lid7lc7d1aVOD3AdNXVJOFk/vBTQVF0s7Q5L+YUfHHd/MdBxMETD+T+T +SkkSJYuyEi6A== Date: Fri, 23 Aug 2024 14:42:12 +0100 From: Will Deacon To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, nd@arm.com, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, anshuman.khandual@arm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, skhan@linuxfoundation.org, szabolcs.nagy@arm.com, tglx@linutronix.de, x86@kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 04/30] arm64: disable trapping of POR_EL0 to EL2 Message-ID: <20240823134211.GF32156@willie-the-truck> References: <20240822151113.1479789-1-joey.gouly@arm.com> <20240822151113.1479789-5-joey.gouly@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240822151113.1479789-5-joey.gouly@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 65F3A40033 X-Stat-Signature: 89y7pxdsxw6frbnbd5rcaoeuj6egqw83 X-Rspam-User: X-HE-Tag: 1724420541-755188 X-HE-Meta: U2FsdGVkX1+nLnDpy1Ko/mSRrE06tZPH3Z8YghEgRaa0ce7oRllvXSb9MtpfC3DHj9M2ATc68zgCqzVu6EPb3BZfx6dVES4uEklZbKTEYQ3YsI6Nv2SiLMQ1U5NLx2mifuCLONcMWD4xWRLnYFHHNnOqdBWcbs20KAzEVVCK/PD726TuywHMbfYeL7HTmk8QuBCxFqCmL7sPzd1sfxbxK9DeJKcI480JsZw/4rAZxhTl4GXUzbBfqeAPcsj0NhsuIo/kDLntNsYGwoMQ+tN9QiXk23/0P0VsgimheEziTGph4NwEmLwOSP/N4AgRTz6HEzyXjaec1gG5uYu01tv9ZPcmNiDiTG1eMmga/QsXgNFdPo9c6dRJZPwyogzWviQOT6GejvTAUAwibp1BPgC0QVcwlgbTR1nC5ck+3STfbafWOyABTYM6iIxeB9lSh8mNB6QstXMVglAPn2XdRaH+FjCBgZ+1Hzxyd/S9//o0Rk+cHU1okzeP89yLsLT3SYFMCXlAQiyAUSBRO67lc4xea6TO7X2hGB8Wjqnm6eVn097ERQelrRwwmlct6irBo99AP4Gv1MYo7Ee6sOSZLSz1x7mtBXWvMts+u00zsn5Caweh+XA709a9TZBU4ctPUhB/2PFum+lOeAOPYc2iCIq4dZNQ7W5SPduuOYJTTBFxfhl6hKay5PMas+pJGbv/lCn7BgWtVkRcKgl2fpzRcymTXeM7pRVb9CKoWgqLSHuIiVEfCXKnLAqEpCx89jL8lr8Vx+OvVrj0BzfClrdgrW6+VYKx4DIc33ra820tfb/r9Fw7a9p6bgroy3IRMY2VXgPc83iPeCgbtl9JAXeVp+eCqxO3tpqIeZHQ1Ww4LUVJoq4EwTSu3Rp1iSub2XvomIg+eEMyzsQ7woLHVP7Wlm/L3ZcuAoXHaTCIwY4XXi77gUuAJlXME7aEoN3HVs0NjMzNhR5bG//q7zw5hEjRQQA QI7/2v0x MT/Y7OaZXyROB6w/Hb/9a33QX7ih5XEg/S/c0hgKbaNFzV2gehtnUv+WGeivYgcxTxXQQLz7ncnfvHOIlYaDFm9rwFN6LtmuwhMhzLfIAOGTzGd0ulYBWKMIOmIKl675BU2rk9Jw5zyHjmWpSjrDHal1QCI54UygJRdWLvdai3ZdJkO03tVPVHEqtT8KyrTEBrKRyJ7PfQYHplNlEq2DywGzZE0k/0PcFjFqlVUx7gYyqsVOZGKDQKh/miveMpCRIxnLtoKi2oK19h7NSiqOcroPLu5H2Yu0m7YD18rMezAU5pEDmRwCIX8bwwbksfKTcLu+NS1HGSuhRxnYT///g5h1VEiOpAAmk3s0/kXazyNKUZ9Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 22, 2024 at 04:10:47PM +0100, Joey Gouly wrote: > Allow EL0 or EL1 to access POR_EL0 without being trapped to EL2. > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon > Acked-by: Catalin Marinas > Reviewed-by: Anshuman Khandual > --- > arch/arm64/include/asm/el2_setup.h | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git arch/arm64/include/asm/el2_setup.h arch/arm64/include/asm/el2_setup.h > index fd87c4b8f984..212191ecad40 100644 > --- arch/arm64/include/asm/el2_setup.h > +++ arch/arm64/include/asm/el2_setup.h > @@ -185,12 +185,20 @@ > .Lset_pie_fgt_\@: > mrs_s x1, SYS_ID_AA64MMFR3_EL1 > ubfx x1, x1, #ID_AA64MMFR3_EL1_S1PIE_SHIFT, #4 > - cbz x1, .Lset_fgt_\@ > + cbz x1, .Lset_poe_fgt_\@ > > /* Disable trapping of PIR_EL1 / PIRE0_EL1 */ > orr x0, x0, #HFGxTR_EL2_nPIR_EL1 > orr x0, x0, #HFGxTR_EL2_nPIRE0_EL1 > > +.Lset_poe_fgt_\@: > + mrs_s x1, SYS_ID_AA64MMFR3_EL1 > + ubfx x1, x1, #ID_AA64MMFR3_EL1_S1POE_SHIFT, #4 > + cbz x1, .Lset_fgt_\@ > + > + /* Disable trapping of POR_EL0 */ > + orr x0, x0, #HFGxTR_EL2_nPOR_EL0 Dave's reworking the labels here on for-next/misc: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?h=for-next/misc&id=5b39db6037e7cba1659f2149aef76934370aa6d5 Please can you follow that new style for the new label so that we don't end up with an immediate inconsistency? Leave the '.Lset_fgt' label as-is and I'll fix it when we merge the branches. Cheers, Will