From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D1BC531DC for ; Fri, 23 Aug 2024 12:39:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19B0A6B0150; Fri, 23 Aug 2024 08:39:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14B156B0151; Fri, 23 Aug 2024 08:39:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0120C80084; Fri, 23 Aug 2024 08:39:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D6AD26B0150 for ; Fri, 23 Aug 2024 08:39:56 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 818511C61F4 for ; Fri, 23 Aug 2024 12:39:56 +0000 (UTC) X-FDA: 82483467192.05.8DA5F98 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf30.hostedemail.com (Postfix) with ESMTP id 4636B80020 for ; Fri, 23 Aug 2024 12:39:53 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Tqr7a4k+; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724416777; a=rsa-sha256; cv=none; b=AsGAU83Gts5LVyE60C6I25aedoxRAImTfoXTwjdToI4O/aRCqRrHj0ieVNxoPSRDtEfxmr 5Qy5E1CNCLPwXboXrZA5seqiSNl3xEJgmDwwkerDKC9cME4zLx49euPnnRhhb+bvU/TY8j Ekv9SOJrbQzqWLBwKWNNOxutkwGpq2Y= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Tqr7a4k+; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724416777; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fkSO6JL8PT/t58c13PbpvvWXwVCAr2TOUzEK6SQmUmE=; b=rRnbry1hcn7zGpE6U8odSF+lJ7mFxxoBxrazf5Sw+rBzDBCTFe5/d1yfgcrIqin6zs1raT IzHEFF8OjFxcySLApO4iLkca22KEj5c67wpbMayoKzPvo6Ap4YJ3pMJLRx4Nzg0ZyX5HND nkp7dOSR6cB9pBW5W0KXN+FCzJLCbt8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5F62DCE115A; Fri, 23 Aug 2024 12:39:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 292C2C32786; Fri, 23 Aug 2024 12:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724416788; bh=OQN7Mf7HQDUQaFApg1+V9RgbCzXwyxIPK7zuLgztQ10=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Tqr7a4k+ccRM4DsoOY2ydy+JCEJZDrohUYfQJAvlzdh5t8ixJwsUBY0DES6Rl/oKr VbmP+9k+07wMjNk+o+6XDCeUoaTgI+jsXsnIn3Y+JR/tF5scYDamudVnGlgnKYE1Zj B9eyNR1aQwtl8u76hHA5tLSIpbqRml4b4IBNw3J2On5pNEYSKjCjIZVWrKKwFhcMIR 5IgtarUhZ2Zksg/LALvyQdsi9YCec95qCJzNSZySlA/dzymJPqm59ggAOXaNvY7Q9R cr1VJYKZNJqn/sTSV9L9HnTyWNLdfrm5bUTvSFNM9zUDFDpMCtQLsWpMFM+lFU02tB ay6weNJME3dSA== From: Christian Brauner To: David Howells Cc: Christian Brauner , Pankaj Raghav , Jeff Layton , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] netfs, cifs: DIO read and read-retry fixes Date: Fri, 23 Aug 2024 14:39:34 +0200 Message-ID: <20240823-relation-offiziell-fda6c4626508@brauner> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240822220650.318774-1-dhowells@redhat.com> References: <20240822220650.318774-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1333; i=brauner@kernel.org; h=from:subject:message-id; bh=OQN7Mf7HQDUQaFApg1+V9RgbCzXwyxIPK7zuLgztQ10=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaSdaOZRKjvtxCkjtZRpcoliflzLrNA9yto3dz9n4D2cN mNb+YKqjlIWBjEuBlkxRRaHdpNwueU8FZuNMjVg5rAygQxh4OIUgIl8bGFkmKibfHdXY2p8D2P7 gt4dxrZNMYKPfzS8Mpxuoqb24KpAIiPD/M//2mKuxJza36Alxn+QTc3k9y63rq8fDFb8+Hsssus eOwA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 4636B80020 X-Rspamd-Server: rspam01 X-Stat-Signature: tt8zbd667e5mja5hymcjq4di193ike1m X-HE-Tag: 1724416793-408917 X-HE-Meta: U2FsdGVkX1+7TZlt8/QSWXly8PdZMONzp2cGkIaX2eYp9j5UYhgYDwOVor399ARZ/KkH7p5WRvxmmscVVXbh4OxEPJyKKK+mUiPaqIOZO5iDrYYtP1VjtV75L2c+SSipZ5ZsDQndY5HdAc7LcV5ipmJj2HO+HYynHf0BDN50fMDm+xCDIov55CW2uzApYpSRJ4Mb0HXilRI6rGcLvcFBOGCfGBp0PG1mlKIN6XMlPTp9BxOoAY6OsFtqZtchjXsFyiVCKe5cKLkvwHOO/M1FWYOaHtDAjpNDlQ2R0QTdnC7imijoHqLBFYS6vsHokmvm0VFN1N6yA6Leuqw5mWnRHXc/4VcnxPPBEtcBZdgnMmZFamYi2X+3mSaUa2BHfb+rw4/Cipt7Lc8ueOtTPJHVK3TKPBHkIyjT9kqTtQSHBfLUDyr/AO9b+sQ/9tEMx79fSD2kNY0BPh4JcjHPfM/UaVvq5rJ9KqD86cC6pO3T8UsJ9zVrtqkMJFD7Qoh4zwQ9zUqk04fhEUruf/l7i7IjLOqcMuVjxCE1wXj5TBMd8IaKQnivk9aEJU3xJVPaPgzJNBqvMSEmwN1fe7f9s0ClkniY8T4ApJ8zPZjXFLHgHnl36iJR7tKfeS++i5zUniDP9ESpDDndsXAAXIgt4doPmb6r8cP2tAmidJM7olsG9tXG/CEe+ZqA8ePnGU0y7fRAtvr9AivY1ZE7E4SIYm+X3nO60A3x0xc1Jf8nBizH35nGr3lQ1eF2KZFDl95lndbCMGjIRxBXkBkCBcw3mEEfCrAeZmVq3x9lZca7t4ZNcCreUm3piy+az0m2cxScXOCl69j+F43CmQk5610sJMaaNryng/61DNyMoR2uO0lZ3y0eqRvyrXrC+6tcUBGhOqH2XE3wneOx9gMYolFdwOA6ofLz0lmKKmzpW2WcSC0iO3lo4rPuhyShVoNpWZTvhmbWW6MaR4I+YVA4umZ9Hsq dl9vv2/E HFzKJlp1/j7hVNQCPbNuaH4Qz8UHy6HM5mpL65S0GG7EkcSBMNQHquB73Ld9uu83TObr9J96WasiVG58WVZaRO7lYO4zmKJxij75snUMFAeMeH6WvmyvCy47MUQL/MOp3niP2mrxVwy89BaFvXQkBSaacPS96V413MeBNvAceIr0S9tCpeUWC8n3Amuk7nHdUXsfXvtWi6zEhGLEMYxEjl8UabtkD78uy6rcswuHO1XTDdkBgYwEMGGNfRs4r4zEI1pJZy8WwEnrRteCTx8x6JDACkou7jPBJCY18TQwA0WWSK7I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 22 Aug 2024 23:06:47 +0100, David Howells wrote: > Here are a couple of fixes to DIO read handling and the retrying of reads, > particularly in relation to cifs. > > (1) Fix the missing credit renegotiation in cifs on the retrying of reads. > The credits we had ended with the original read (or the last retry) > and to perform a new read we need more credits otherwise the server > can reject our read with EINVAL. > > [...] Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/2] cifs: Fix lack of credit renegotiation on read retry https://git.kernel.org/vfs/vfs/c/82d55e76bf2f [2/2] netfs, cifs: Fix handling of short DIO read https://git.kernel.org/vfs/vfs/c/942ad91e2956