From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01D8FC52D7C for ; Thu, 22 Aug 2024 11:10:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6246D6B02C3; Thu, 22 Aug 2024 07:10:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AD096B02C7; Thu, 22 Aug 2024 07:10:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FFBB6B02C8; Thu, 22 Aug 2024 07:10:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1F2AC6B02C3 for ; Thu, 22 Aug 2024 07:10:09 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 87C8EA4140 for ; Thu, 22 Aug 2024 11:10:08 +0000 (UTC) X-FDA: 82479612096.09.FC13E01 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf20.hostedemail.com (Postfix) with ESMTP id 57DE21C000C for ; Thu, 22 Aug 2024 11:10:05 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=i8E8TY9J; spf=pass (imf20.hostedemail.com: domain of lkp@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724324989; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=ZKPc/EEBQYcV+l2b4qAOQWV5zYqHXruqFJvkkC3/xck=; b=viNSweIoKNI6AVrwrUFc5P3EPO1YAfhX8gfdY2+NiyJuJUkaGAe0H56knVySqH8OT2/v// vaYt5SzwYkrZB2wo44IQ2VbFHxv+71KmkZXPGhOHmld9sY9ShuR/WdCKyoMrPgeYe0OqpH 9NrAi76bcM9f6ofjz7hu7aTaK8LIgFA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=i8E8TY9J; spf=pass (imf20.hostedemail.com: domain of lkp@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724324989; a=rsa-sha256; cv=none; b=aWnDp3WYSUdqtd82CGLpt2h6uwpsuJEmqtFVL6c1ZCY8pmUX3SoP4DRkDgC3ieZXdOi7wu qEbHJnb/GsthnRCVPgPiq74aB2/yLTuFGnctNMJADhRnq/f0EG7i7A5J8n8+SQJtMlyJjv EAY7cJhnf8gBT0Jm0j2d1m0k/lLaYwg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724325006; x=1755861006; h=date:from:to:cc:subject:message-id:mime-version; bh=b6DgUfhLDsbxBk89dE3abya17Vn5XYYg5hvD9Dxbirk=; b=i8E8TY9JG+5ETJK3R358amS7mTq8r2nwR1IjyyGt9rxaOoLKAHeYRmUl /jisaF/RmdqYorntMI8Qfp8a1A4vHwWs34U34J5T4b8Zww1dK/gAso5xh 9GAHEcQZMnukhSKhjf3tzpWN7p+/zsW6uH9o2QhDtC6z2An2QEp9iXGiq uaG+Aa0d6R7Dv4vn2N06CnTA0nRqeJJu9+yaqYteAWRIXwzBrv1hezybb 9GHlXuigVUpXqsLaXzXUtKSabi8tk/GDKitbQaUCc6ug9dV41Xw+Emvwm 7MXzfXdgSKFjtkBxVtdrufB6xSTmk3OfAj+LYTVuFdsy05WVUIIIpmWgf A==; X-CSE-ConnectionGUID: cHVQt705T0WFKHg7uOrYuA== X-CSE-MsgGUID: UcYKYFa8Tu+y8XSpFNCzjw== X-IronPort-AV: E=McAfee;i="6700,10204,11171"; a="22698017" X-IronPort-AV: E=Sophos;i="6.10,166,1719903600"; d="scan'208";a="22698017" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 04:10:04 -0700 X-CSE-ConnectionGUID: 31u6kT8PR5msuZqbdSBjJw== X-CSE-MsgGUID: fe2bu1uJQKu7mfHRLQ+0Jw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,166,1719903600"; d="scan'208";a="61123173" Received: from lkp-server01.sh.intel.com (HELO 9a732dc145d3) ([10.239.97.150]) by fmviesa007.fm.intel.com with ESMTP; 22 Aug 2024 04:10:02 -0700 Received: from kbuild by 9a732dc145d3 with local (Exim 4.96) (envelope-from ) id 1sh5hY-000Cgu-0g; Thu, 22 Aug 2024 11:10:00 +0000 Date: Thu, 22 Aug 2024 19:09:15 +0800 From: kernel test robot To: Thomas Richter Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Vasily Gorbik Subject: [linux-next:master 5751/6069] arch/s390/kernel/perf_cpum_sf.c:1460:43: warning: variable 'idx_old' set but not used Message-ID: <202408221933.w7zzVrjB-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Stat-Signature: xjen4o4ikq9cjdppabae66cgkpqcz8xz X-Rspamd-Queue-Id: 57DE21C000C X-Rspamd-Server: rspam11 X-HE-Tag: 1724325005-238407 X-HE-Meta: U2FsdGVkX185sD+xP6K3Ukuuo0lGL1+Kq+vrvapaXEZd9y4BkkVRYpiqEdqykPJkmGFgJAtm2Qrw/usoWa1vvaJ1AL0iVM/klv986GkxO55b3r1yJnYO5Hx6QTiAc3kgP5cvO+79Nfxy1yRJ8ic8Bdy8HwGV+K2k/KDyk5YIVfEqZ+5Zjt7/ELUgd+2oz5iLCsEZlNbTVIxr0LU11XD9W8a1JeExoC5ss5Unr1kq8M70rtGlDQKd5ymL4iUsPFnH4KwHPqwvkM4YNPGXiHoeYIbtGSKA02QWQ3fn56lDJBffNsFT3atiIYohNREQY45tDOhccLaQ9Fmvg8F9Pdh+UDqCI6bLw7UJopj9UaBixQfhXGvwiitgjfLodmKrc+4Dl3QyWsWvxPh5i1jhXpchqqJFUpiAOK4i0yj4+ToPTQh2FJAbU0AdUV6pcBH5vOHMKSveTEBQwpsQ26aYpzC1kfxz5qpboymf5+Oc5wl/Exw3Us3LXUBPtCsTnzHCWYOaK0SbvlwAIJgxvon4vqdfnSXKfaCrVv3zRhR4F/awgYwZJZ4opmdK7dl4h+yvO8jI/udSFIrBkZU4UVwDvg/aoIQ+6tY+o1dOaPt3rUnk5+ZKiJpReNH7q+MohK/qCkuuqaJT6AZPABWCioQEm6UaO6YfjLUTmyFxGxz3qDvsu8OEtlwZ1bzH3ek9O1erDqnqIYiINGuxrEU7gFOvhmcPF8YNkenLCDOHmoauR02FItF/+dfWpDNDjgDgV1A/GOCJvR1srupPAAGomYG+OnJHOrWug0gESw1TBjIO0PbH4EruVRE+3cob1hnnRM8xLpHcEAV2gcdfZ3AooIrMnshrMPBj/GAsf+W3aDaxPEkI9Y8TR3XGAXvT3hja3+dDP8g8O72clq3KLQs5kWkWVPl9W2mgxrS+WwNlPA0AMBnfSnNjot6HL9hpHqkea7Id+L08PWjh/9OVkNxvXf4FG4W iJJpHYI1 B4zXabPllUay4Pr/esyBjwVuqDy9kT3Nb799KQQWH01i8dp50iR4V8/RYDSS8AAztZ86AVCNWMIhTBc/X8Fv55gNsc+Oqb6SvvhsZPn1ehAgxyK3k4Rn1YaBJI2lSJHPcLa/K9wnKXbHcR3mosDYmWhnmMmB/z+xwRHv/UxHPLSkg0fRF+qc49+ymMjSP51lhAv8VX7MNCZLQvNSBl1xtuIJt7zsNiIlfKddqeyOpSp+m7+BN2FfBLey29ul+lt8TZBSn6rOGZ+M7SXR/cJz+/tMxyhDGWuBDbIipKEMK7src/MK7x72qGihEjiOlruZPAryNtVIAQOzo9+Qq3BlyRtn8sarzhzOj8M6wKFSRcJRmmjN3T0GZPGFaROajx0em4LioBlGYq1ocCkmaNNiDLSfbfA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 6a7917c89f219f09b1d88d09f376000914a52763 commit: 7b3e01be8455386a664a68fad0abb5a7611d2664 [5751/6069] s390/cpum_sf: Rework debug_sprintf_event() messages config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20240822/202408221933.w7zzVrjB-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240822/202408221933.w7zzVrjB-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202408221933.w7zzVrjB-lkp@intel.com/ All warnings (new ones prefixed by >>): arch/s390/kernel/perf_cpum_sf.c: In function 'aux_reset_buffer': >> arch/s390/kernel/perf_cpum_sf.c:1460:43: warning: variable 'idx_old' set but not used [-Wunused-but-set-variable] 1460 | unsigned long i, range_scan, idx, idx_old; | ^~~~~~~ vim +/idx_old +1460 arch/s390/kernel/perf_cpum_sf.c ca5955cdeae744 Pu Hou 2016-11-11 1434 ca5955cdeae744 Pu Hou 2016-11-11 1435 /* ca5955cdeae744 Pu Hou 2016-11-11 1436 * aux_reset_buffer() - Scan and setup SDBs for new samples ca5955cdeae744 Pu Hou 2016-11-11 1437 * @aux: The AUX buffer to set ca5955cdeae744 Pu Hou 2016-11-11 1438 * @range: The range of SDBs to scan started from aux->head ca5955cdeae744 Pu Hou 2016-11-11 1439 * @overflow: Set to overflow count ca5955cdeae744 Pu Hou 2016-11-11 1440 * ca5955cdeae744 Pu Hou 2016-11-11 1441 * Set alert indicator on the SDB at index of aux->alert_mark. If this SDB is ca5955cdeae744 Pu Hou 2016-11-11 1442 * marked as empty, check if it is already set full by the hardware sampler. ca5955cdeae744 Pu Hou 2016-11-11 1443 * If yes, that means new data is already there before we can set an alert ca5955cdeae744 Pu Hou 2016-11-11 1444 * indicator. Caller should try to set alert indicator to some position behind. ca5955cdeae744 Pu Hou 2016-11-11 1445 * ca5955cdeae744 Pu Hou 2016-11-11 1446 * Scan the SDBs in AUX buffer from behind aux->empty_mark. They are used ca5955cdeae744 Pu Hou 2016-11-11 1447 * previously and have already been consumed by user space. Reset these SDBs ca5955cdeae744 Pu Hou 2016-11-11 1448 * (clear full indicator and alert indicator) for new data. ca5955cdeae744 Pu Hou 2016-11-11 1449 * If aux->alert_mark fall in this area, just set it. Overflow count is ca5955cdeae744 Pu Hou 2016-11-11 1450 * recorded while scanning. ca5955cdeae744 Pu Hou 2016-11-11 1451 * ca5955cdeae744 Pu Hou 2016-11-11 1452 * SDBs between aux->head and aux->empty_mark are already reset at last time. ca5955cdeae744 Pu Hou 2016-11-11 1453 * and ready for new samples. So scanning on this area could be skipped. ca5955cdeae744 Pu Hou 2016-11-11 1454 * ca5955cdeae744 Pu Hou 2016-11-11 1455 * Return true if alert indicator is set successfully and false if not. ca5955cdeae744 Pu Hou 2016-11-11 1456 */ ca5955cdeae744 Pu Hou 2016-11-11 1457 static bool aux_reset_buffer(struct aux_buffer *aux, unsigned long range, ca5955cdeae744 Pu Hou 2016-11-11 1458 unsigned long long *overflow) ca5955cdeae744 Pu Hou 2016-11-11 1459 { ee5c4ccfd51d5d Thomas Richter 2019-12-17 @1460 unsigned long i, range_scan, idx, idx_old; 82d3edb50a11bf Heiko Carstens 2023-01-05 1461 union hws_trailer_header old, prev, new; 82d3edb50a11bf Heiko Carstens 2023-01-05 1462 unsigned long long orig_overflow; ca5955cdeae744 Pu Hou 2016-11-11 1463 struct hws_trailer_entry *te; ca5955cdeae744 Pu Hou 2016-11-11 1464 78157b4791a3e3 Thomas Richter 2023-01-13 1465 if (range <= aux_sdb_num_empty(aux)) ca5955cdeae744 Pu Hou 2016-11-11 1466 /* ca5955cdeae744 Pu Hou 2016-11-11 1467 * No need to scan. All SDBs in range are marked as empty. ca5955cdeae744 Pu Hou 2016-11-11 1468 * Just set alert indicator. Should check race with hardware ca5955cdeae744 Pu Hou 2016-11-11 1469 * sampler. ca5955cdeae744 Pu Hou 2016-11-11 1470 */ ca5955cdeae744 Pu Hou 2016-11-11 1471 return aux_set_alert(aux, aux->alert_mark, overflow); ca5955cdeae744 Pu Hou 2016-11-11 1472 ca5955cdeae744 Pu Hou 2016-11-11 1473 if (aux->alert_mark <= aux->empty_mark) ca5955cdeae744 Pu Hou 2016-11-11 1474 /* ca5955cdeae744 Pu Hou 2016-11-11 1475 * Set alert indicator on empty SDB. Should check race ca5955cdeae744 Pu Hou 2016-11-11 1476 * with hardware sampler. ca5955cdeae744 Pu Hou 2016-11-11 1477 */ ca5955cdeae744 Pu Hou 2016-11-11 1478 if (!aux_set_alert(aux, aux->alert_mark, overflow)) ca5955cdeae744 Pu Hou 2016-11-11 1479 return false; ca5955cdeae744 Pu Hou 2016-11-11 1480 ca5955cdeae744 Pu Hou 2016-11-11 1481 /* ca5955cdeae744 Pu Hou 2016-11-11 1482 * Scan the SDBs to clear full and alert indicator used previously. ca5955cdeae744 Pu Hou 2016-11-11 1483 * Start scanning from one SDB behind empty_mark. If the new alert ca5955cdeae744 Pu Hou 2016-11-11 1484 * indicator fall into this range, set it. ca5955cdeae744 Pu Hou 2016-11-11 1485 */ 78157b4791a3e3 Thomas Richter 2023-01-13 1486 range_scan = range - aux_sdb_num_empty(aux); ee5c4ccfd51d5d Thomas Richter 2019-12-17 1487 idx_old = idx = aux->empty_mark + 1; ca5955cdeae744 Pu Hou 2016-11-11 1488 for (i = 0; i < range_scan; i++, idx++) { ca5955cdeae744 Pu Hou 2016-11-11 1489 te = aux_sdb_trailer(aux, idx); 5e02c74905cb00 Heiko Carstens 2023-02-24 1490 prev.val = READ_ONCE_ALIGNED_128(te->header.val); ca5955cdeae744 Pu Hou 2016-11-11 1491 do { 82d3edb50a11bf Heiko Carstens 2023-01-05 1492 old.val = prev.val; 82d3edb50a11bf Heiko Carstens 2023-01-05 1493 new.val = prev.val; 82d3edb50a11bf Heiko Carstens 2023-01-05 1494 orig_overflow = old.overflow; 82d3edb50a11bf Heiko Carstens 2023-01-05 1495 new.f = 0; 82d3edb50a11bf Heiko Carstens 2023-01-05 1496 new.overflow = 0; ca5955cdeae744 Pu Hou 2016-11-11 1497 if (idx == aux->alert_mark) 82d3edb50a11bf Heiko Carstens 2023-01-05 1498 new.a = 1; ca5955cdeae744 Pu Hou 2016-11-11 1499 else 82d3edb50a11bf Heiko Carstens 2023-01-05 1500 new.a = 0; 497cc42bf53b55 Peter Zijlstra 2023-05-31 1501 prev.val = cmpxchg128(&te->header.val, old.val, new.val); 82d3edb50a11bf Heiko Carstens 2023-01-05 1502 } while (prev.val != old.val); ca5955cdeae744 Pu Hou 2016-11-11 1503 *overflow += orig_overflow; ca5955cdeae744 Pu Hou 2016-11-11 1504 } ca5955cdeae744 Pu Hou 2016-11-11 1505 ca5955cdeae744 Pu Hou 2016-11-11 1506 /* Update empty_mark to new position */ ca5955cdeae744 Pu Hou 2016-11-11 1507 aux->empty_mark = aux->head + range - 1; ca5955cdeae744 Pu Hou 2016-11-11 1508 ca5955cdeae744 Pu Hou 2016-11-11 1509 return true; ca5955cdeae744 Pu Hou 2016-11-11 1510 } ca5955cdeae744 Pu Hou 2016-11-11 1511 :::::: The code at line 1460 was first introduced by commit :::::: ee5c4ccfd51d5dbaa9b9ddeed97c8d5526e55f17 s390/cpum_sf: Convert debug trace to common layout :::::: TO: Thomas Richter :::::: CC: Vasily Gorbik -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki