From: Andrew Morton <akpm@linux-foundation.org>
To: Yu Liao <liaoyu15@huawei.com>
Cc: Yu Zhao <yuzhao@google.com>, Muchun Song <muchun.song@linux.dev>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Zi Yan <ziy@nvidia.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH mm-unstable v2 1/3] mm/contig_alloc: support __GFP_COMP
Date: Thu, 22 Aug 2024 11:36:34 -0700 [thread overview]
Message-ID: <20240822113634.1aaf99c506796ecc233cb472@linux-foundation.org> (raw)
In-Reply-To: <2d418463-1458-5361-86c4-a07908fc114d@huawei.com>
On Thu, 22 Aug 2024 16:21:27 +0800 Yu Liao <liaoyu15@huawei.com> wrote:
> > +#ifdef CONFIG_CONTIG_ALLOC
> > +static inline struct folio *folio_alloc_gigantic_noprof(int order, gfp_t gfp,
> > + int nid, nodemask_t *node)
> > +{
> > + struct page *page;
> > +
> > + if (WARN_ON(!order || !(gfp | __GFP_COMP)))
>
> It doesn't seem right, it should be !(gfp & __GFP_COMP).
Yup. Although I'm wondering why we're checking __GFP_COMP at all?
It's a gigantic page - we know it's compound, so why require that the
caller tell us something we already know?
--- a/include/linux/gfp.h~mm-contig_alloc-support-__gfp_comp-fix
+++ a/include/linux/gfp.h
@@ -452,7 +452,7 @@ static inline struct folio *folio_alloc_
{
struct page *page;
- if (WARN_ON(!order || !(gfp | __GFP_COMP)))
+ if (WARN_ON(!order || !(gfp & __GFP_COMP)))
return NULL;
page = alloc_contig_pages_noprof(1 << order, gfp, nid, node);
_
next prev parent reply other threads:[~2024-08-25 17:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 3:54 [PATCH mm-unstable v2 0/3] mm/hugetlb: alloc/free gigantic folios Yu Zhao
2024-08-14 3:54 ` [PATCH mm-unstable v2 1/3] mm/contig_alloc: support __GFP_COMP Yu Zhao
2024-08-22 8:21 ` Yu Liao
2024-08-22 17:25 ` Yu Zhao
2024-08-22 18:36 ` Andrew Morton [this message]
2024-08-22 17:23 ` Yu Zhao
2024-08-22 18:42 ` Matthew Wilcox
2024-09-02 17:02 ` Yu Zhao
2024-11-19 15:29 ` David Hildenbrand
2024-11-19 16:12 ` Zi Yan
2024-11-19 16:25 ` David Hildenbrand
2024-11-19 16:31 ` David Hildenbrand
2024-11-19 16:41 ` Zi Yan
2024-11-19 16:49 ` David Hildenbrand
2024-11-19 16:52 ` David Hildenbrand
2024-11-20 15:55 ` Zi Yan
2024-11-20 16:13 ` David Hildenbrand
2024-11-20 16:46 ` Zi Yan
2024-08-14 3:54 ` [PATCH mm-unstable v2 2/3] mm/cma: add cma_{alloc,free}_folio() Yu Zhao
2024-08-22 17:24 ` Yu Zhao
2024-09-02 17:04 ` Yu Zhao
2024-08-14 3:54 ` [PATCH mm-unstable v2 3/3] mm/hugetlb: use __GFP_COMP for gigantic folios Yu Zhao
2024-08-16 15:23 ` Zi Yan
2024-08-16 16:02 ` Yu Zhao
2024-08-16 16:30 ` Zi Yan
2024-08-30 17:55 ` [PATCH mm-unstable v2 0/3] mm/hugetlb: alloc/free " jane.chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822113634.1aaf99c506796ecc233cb472@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=liaoyu15@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox