From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10318C5320E for ; Sun, 25 Aug 2024 18:16:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D9428D0026; Sun, 25 Aug 2024 14:16:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 787A38D0022; Sun, 25 Aug 2024 14:16:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 676148D0026; Sun, 25 Aug 2024 14:16:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4200C8D0022 for ; Sun, 25 Aug 2024 14:16:51 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EF3AB1407EB for ; Sun, 25 Aug 2024 18:16:50 +0000 (UTC) X-FDA: 82491573780.25.59B940F Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf08.hostedemail.com (Postfix) with ESMTP id 3CCC7160009 for ; Sun, 25 Aug 2024 18:16:48 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=msg14e4d; spf=pass (imf08.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724609766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z66Onzfy5+scLyiJJfQpukkANgz5AhR0g4oXWWx8rNo=; b=O3BF9v/XfD8u6yq7cokWz4Zf9EA8xxa7Nmq0YnYlUqUmsdv9qpuY5PkBJ++L7LswOmg4Ut N8njQHjFHasaGKqR5YOkWpCKSvHs9zAdlKsoi9BgePAWrJjpMBL5wsAk2ZnfW0ODygkikj mSkUutpuDeTrsvqu87P30E5dSrvNZ7g= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=msg14e4d; spf=pass (imf08.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724609766; a=rsa-sha256; cv=none; b=fRkYn0d8dv+xSFW0tDaQ/kaxT/AvTz7wiPn9fZgGXAgcs67yTTlW7fQW9U2M5Rlrc+qnl8 cOltgRkEyRAYCCPmSEd+e1cXZenOBNobW+XjFSxEQPoGB6MLOst9gsqyt+Sjs8dM54j2eG gPN8h2U4CrvLLHLCUaEokIyYI8XyGeA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 32EB2A40E51; Thu, 22 Aug 2024 17:47:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EA2BC32782; Thu, 22 Aug 2024 17:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724348856; bh=ZouLq/8pIc7NL+u1I+/tJejA2tHWdm7Eju6gVChwW7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=msg14e4dBoOafgRZOQLJtri9GIzzLAjE4gYBSa0vsNow1AgY8EWoFGYqDkXhgpHno nd4RQVEugGo4Z5ngysg38vftiVVt/kBfz/+xJGLm5/G6HVHyRKM9A9fT3hCZ23ONAN 5HUcn9/XfoHa/V7O7LE99EljsIzy/O3cxBNjd9HXWWpNsWWj3JFNxd0txkJKjNfpDX Jvv6FeKzf0dNW+OdsdyP9aEeeOEt0k29cwSTV0/jE+atQHdMrIq6TP8UnL96xSFWqy DHbP8OmmSHFf2LuOqFtcmjhm3kgGSrxamTYwaVOykr38HaUHenqmEirH4bb272mSHS 6zqbO5OFxWFDA== Date: Thu, 22 Aug 2024 10:47:36 -0700 From: Kees Cook To: Xiu Jianfeng Cc: Vlastimil Babka , Suren Baghdasaryan , Kent Overstreet , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, "GONG, Ruiqi" , Jann Horn , Matteo Rizzo , jvoisin , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 5/5] slab: Allocate and use per-call-site caches Message-ID: <202408221046.808356D202@keescook> References: <20240809072532.work.266-kees@kernel.org> <20240809073309.2134488-5-kees@kernel.org> <1ddb539a-79ed-d992-76cf-061acb4df11e@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1ddb539a-79ed-d992-76cf-061acb4df11e@huaweicloud.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 3CCC7160009 X-Stat-Signature: g7ew6e3ectmcyizimiosm7q4jb8igw5z X-HE-Tag: 1724609808-523167 X-HE-Meta: U2FsdGVkX1+bwLzvNCvKI2nTvrhHGllgeaGFLHBXWpdevhPCwpAP2MQ4PEk537VOjiPqLxxKhEaEIo3hGaTqX2VlIrQGeNIKH6XmGWuNQ626bN1VexaPLttthS16BBTiCCTmaWGvthMlXwaTZTfsS/pmWCQ+jqt5GQ8gLXjmJoiIpfLrkX+CtKYCHCI9N8QADFC7kpT4waEjIb8UZBRMu8FXANtFw7u66M/yY/kiJwPOdXx9KqPjKYcGJMF/NuDU7TjLrkwAIguIEzfWw0Sxw3TbQSYkMev2ryqEj2/YVCxDAVf83m9T2nipOsVTs5wvEepdX4prdhqZC2Jux0E8ToZBEC34mdUoDFDndME00IfwhbA/RgJKdeRpdIsntwGUfny17v9iLsCHioL2ECVorXpdp3lcKImMjFeGexiJsZyI225if72fBguRnjX4RO3jAUKiZMhRDKEE/u0O5AC+fPb41Y+sTJ0zBJx9o7DYQMnC12zgnbBCaL/JNnkLCcYWrTzUa4mp5qNny47FG4XtAaxP3fwJEeigK6GTrS2wCZrCGcLEYbFbEmsQJJfpVDYKEDa4qvCjFlagpcf7psKLcEwzJPRbvVBPMxekB8dGDOFJT3ttGjr8gn7D1R2IGD0PiJsjSv9nbFdI3ui3GEy1+TR+8RgL5tbfbXBn6VKP62OKckcjmHIVc6HFh84LxH6ECu69gOHxVFcdjPjhfjAzXX5P7zuT8+3DpYnjd6n1YaUuRzysQ2UIC3wBBjOJ84aW4078OmK+HZJNITyn5pHnrYrWhGR0G7HGGk1LBrfPER5CTtY3zFAIqilypEbVQgBVr6rsrMYhF00zWZWrckblpScH2Hze4Wmd0HtoqD1LPpA76EuSxaAeM5g+zpdw8yNQsxKIhXB7gaGoLODPZpzOrgYZ6f25OhXnXIxnU+dfcfdcQ8Ja+i8IKnFGUro5WWKpre6o9yoJfrQWRLUx6cZ 4uusEsUB ybjSGGbtEFbCWEVcdwJS198gtShseX8tve24JvnvsfLMs1sRX67UDJqqhICyerILqF0AsxXzSkXAg89M8fINP4UAJoviS1N0BDv6cZYKYnJxL1xwUK60qiyRG4unoCJZ8U+Ug8C6nnrnC48B2ah7s0wjT+CrJdP6NKVjnFYFNiCLT0nkfJXOpbN4i4y7BpmjMBkvtHYmgnV0u3qN2Q49cNxyCsPlPa23i5Z+4NTka4DaoPSMMkiGmjs29dhlwjmEp0t0lEgGJtDeybi8Q2FOUOHH81zlxqTEcbDIpLMgOJkyGbDT8wPnf0RMKxVT0pe0oXTgMEjTkM/7Fpc457Lem7XvRzoCu0k4jVy2iDvymZhywTs7TmdhgPht6yRqUg3o/4Se+qgAnPEl5OBtngQpKs2ltr1PWEnH4g+zDkhVZhInu0J/x4w2XqxBj/fPlaJ1ANl5FX12btWlH25akoX0GYuEk1w1pu0KJd/9rN5Ie9BvTttNSKL0XlJ3Oo8rwviccPiAwDjywGNofJ10PLsfHv9tK+NLeb+DEOE2eIOre6RR2TvHcPMa5v9rFoRPjsZ+Ud0T3u9jprXwuwN4ax9av6j2qPOnYMhyMaqNfSGWWTtXIDrZXoRMksiIKBf6iVk+Drj5H/v4UYvHp3GNfSkxX4+hHmsmqQKOwiQt/oTRkx6QgYm8VAJNtKFE1SjGsH8OB4bHLBBQZkeJ6lG4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Aug 17, 2024 at 09:30:58AM +0800, Xiu Jianfeng wrote: > Hi Kees, > > On 2024/8/9 15:33, Kees Cook wrote: > > Use separate per-call-site kmem_cache or kmem_buckets. These are > > allocated on demand to avoid wasting memory for unused caches. > > > > A few caches need to be allocated very early to support allocating the > > caches themselves: kstrdup(), kvasprintf(), and pcpu_mem_zalloc(). Any > > GFP_ATOMIC allocations are currently left to be allocated from > > KMALLOC_NORMAL. > > > > With a distro config, /proc/slabinfo grows from ~400 entries to ~2200. > > > > Since this feature (CONFIG_SLAB_PER_SITE) is redundant to > > CONFIG_RANDOM_KMALLOC_CACHES, mark it a incompatible. Add Kconfig help > > text that compares the features. > > > > Improvements needed: > > - Retain call site gfp flags in alloc_tag meta field to: > > - pre-allocate all GFP_ATOMIC caches (since their caches cannot > > be allocated on demand unless we want them to be GFP_ATOMIC > > themselves...) > > - Separate MEMCG allocations as well > > - Allocate individual caches within kmem_buckets on demand to > > further reduce memory usage overhead. > > > > Signed-off-by: Kees Cook > > --- > > Cc: Suren Baghdasaryan > > Cc: Kent Overstreet > > Cc: Vlastimil Babka > > Cc: Christoph Lameter > > Cc: Pekka Enberg > > Cc: David Rientjes > > Cc: Joonsoo Kim > > Cc: Andrew Morton > > Cc: Roman Gushchin > > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > Cc: linux-mm@kvack.org > > --- > > include/linux/alloc_tag.h | 8 +++ > > lib/alloc_tag.c | 121 +++++++++++++++++++++++++++++++++++--- > > mm/Kconfig | 19 +++++- > > mm/slab_common.c | 1 + > > mm/slub.c | 31 +++++++++- > > 5 files changed, 170 insertions(+), 10 deletions(-) > > > > [...] > > > diff --git a/mm/slub.c b/mm/slub.c > > index 3520acaf9afa..d14102c4b4d7 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -4135,6 +4135,35 @@ void *__kmalloc_large_node_noprof(size_t size, gfp_t flags, int node) > > } > > EXPORT_SYMBOL(__kmalloc_large_node_noprof); > > > > +static __always_inline > > +struct kmem_cache *choose_slab(size_t size, kmem_buckets *b, gfp_t flags, > > + unsigned long caller) > > +{ > > +#ifdef CONFIG_SLAB_PER_SITE > > + struct alloc_tag *tag = current->alloc_tag; > > There is a compile error here if CONFIG_MEM_ALLOC_PROFILING is disabled > when I test this patchset. > > mm/slub.c: In function ‘choose_slab’: > mm/slub.c:4187:40: error: ‘struct task_struct’ has no member named > ‘alloc_tag’ > 4187 | struct alloc_tag *tag = current->alloc_tag; > | ^~ > CC mm/page_reporting.o > > maybe CONFIG_SLAB_PER_SITE should depend on CONFIG_MEM_ALLOC_PROFILING Thanks! I tried to make the Kconfig use the right dependencies, but I clearly missed something. There is also some weird behavior between "depends" and "select". I will get this fixed for the next version. -Kees -- Kees Cook