linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>,
	 Will Deacon <will@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	 Andrew Morton <akpm@linux-foundation.org>,
	Marc Zyngier <maz@kernel.org>,
	 Oliver Upton <oliver.upton@linux.dev>,
	James Morse <james.morse@arm.com>,
	 Suzuki K Poulose <suzuki.poulose@arm.com>,
	Arnd Bergmann <arnd@arndb.de>,  Oleg Nesterov <oleg@redhat.com>,
	Eric Biederman <ebiederm@xmission.com>,
	 Shuah Khan <shuah@kernel.org>,
	 "Rick P. Edgecombe" <rick.p.edgecombe@intel.com>,
	 Deepak Gupta <debug@rivosinc.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	 Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
	Kees Cook <kees@kernel.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Florian Weimer <fweimer@redhat.com>,
	Christian Brauner <brauner@kernel.org>,
	 Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
	 Ross Burton <ross.burton@arm.com>,
	 Yury Khrustalev <yury.khrustalev@arm.com>,
	 Wilco Dijkstra <wilco.dijkstra@arm.com>,
	 linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
	 kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org,
	 linux-arch@vger.kernel.org, linux-mm@kvack.org,
	 linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-riscv@lists.infradead.org, Mark Brown <broonie@kernel.org>
Subject: [PATCH v11 10/39] arm64/gcs: Provide basic EL2 setup to allow GCS usage at EL0 and EL1
Date: Thu, 22 Aug 2024 02:15:13 +0100	[thread overview]
Message-ID: <20240822-arm64-gcs-v11-10-41b81947ecb5@kernel.org> (raw)
In-Reply-To: <20240822-arm64-gcs-v11-0-41b81947ecb5@kernel.org>

There is a control HCRX_EL2.GCSEn which must be set to allow GCS
features to take effect at lower ELs and also fine grained traps for GCS
usage at EL0 and EL1.  Configure all these to allow GCS usage by EL0 and
EL1.

We also initialise GCSCR_EL1 and GCSCRE0_EL1 to ensure that we can
execute function call instructions without faulting regardless of the
state when the kernel is started.

Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/include/asm/el2_setup.h | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/arch/arm64/include/asm/el2_setup.h b/arch/arm64/include/asm/el2_setup.h
index fd87c4b8f984..09211aebcf03 100644
--- a/arch/arm64/include/asm/el2_setup.h
+++ b/arch/arm64/include/asm/el2_setup.h
@@ -27,6 +27,14 @@
 	ubfx	x0, x0, #ID_AA64MMFR1_EL1_HCX_SHIFT, #4
 	cbz	x0, .Lskip_hcrx_\@
 	mov_q	x0, HCRX_HOST_FLAGS
+
+        /* Enable GCS if supported */
+	mrs_s	x1, SYS_ID_AA64PFR1_EL1
+	ubfx	x1, x1, #ID_AA64PFR1_EL1_GCS_SHIFT, #4
+	cbz	x1, .Lset_hcrx_\@
+	orr	x0, x0, #HCRX_EL2_GCSEn
+
+.Lset_hcrx_\@:
 	msr_s	SYS_HCRX_EL2, x0
 .Lskip_hcrx_\@:
 .endm
@@ -191,6 +199,15 @@
 	orr	x0, x0, #HFGxTR_EL2_nPIR_EL1
 	orr	x0, x0, #HFGxTR_EL2_nPIRE0_EL1
 
+	/* GCS depends on PIE so we don't check it if PIE is absent */
+	mrs_s	x1, SYS_ID_AA64PFR1_EL1
+	ubfx	x1, x1, #ID_AA64PFR1_EL1_GCS_SHIFT, #4
+	cbz	x1, .Lset_fgt_\@
+
+	/* Disable traps of access to GCS registers at EL0 and EL1 */
+	orr	x0, x0, #HFGxTR_EL2_nGCS_EL1_MASK
+	orr	x0, x0, #HFGxTR_EL2_nGCS_EL0_MASK
+
 .Lset_fgt_\@:
 	msr_s	SYS_HFGRTR_EL2, x0
 	msr_s	SYS_HFGWTR_EL2, x0
@@ -204,6 +221,17 @@
 .Lskip_fgt_\@:
 .endm
 
+.macro __init_el2_gcs
+	mrs_s	x1, SYS_ID_AA64PFR1_EL1
+	ubfx	x1, x1, #ID_AA64PFR1_EL1_GCS_SHIFT, #4
+	cbz	x1, .Lskip_gcs_\@
+
+	/* Ensure GCS is not enabled when we start trying to do BLs */
+	msr_s	SYS_GCSCR_EL1, xzr
+	msr_s	SYS_GCSCRE0_EL1, xzr
+.Lskip_gcs_\@:
+.endm
+
 .macro __init_el2_nvhe_prepare_eret
 	mov	x0, #INIT_PSTATE_EL1
 	msr	spsr_el2, x0
@@ -229,6 +257,7 @@
 	__init_el2_nvhe_idregs
 	__init_el2_cptr
 	__init_el2_fgt
+        __init_el2_gcs
 .endm
 
 #ifndef __KVM_NVHE_HYPERVISOR__

-- 
2.39.2



  parent reply	other threads:[~2024-08-22  1:18 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-22  1:15 [PATCH v11 00/39] arm64/gcs: Provide support for GCS in userspace Mark Brown
2024-08-22  1:15 ` [PATCH v11 01/39] mm: Introduce ARCH_HAS_USER_SHADOW_STACK Mark Brown
2024-08-22  1:15 ` [PATCH v11 02/39] arm64/mm: Restructure arch_validate_flags() for extensibility Mark Brown
2024-08-22  1:15 ` [PATCH v11 03/39] prctl: arch-agnostic prctl for shadow stack Mark Brown
2024-08-22  1:15 ` [PATCH v11 04/39] mman: Add map_shadow_stack() flags Mark Brown
2024-08-22  1:15 ` [PATCH v11 05/39] arm64: Document boot requirements for Guarded Control Stacks Mark Brown
2024-08-22  8:58   ` Catalin Marinas
2024-08-22  1:15 ` [PATCH v11 06/39] arm64/gcs: Document the ABI " Mark Brown
2024-08-22 10:04   ` Catalin Marinas
2024-08-22  1:15 ` [PATCH v11 07/39] arm64/sysreg: Add definitions for architected GCS caps Mark Brown
2024-08-22  1:15 ` [PATCH v11 08/39] arm64/gcs: Add manual encodings of GCS instructions Mark Brown
2024-08-22  1:15 ` [PATCH v11 09/39] arm64/gcs: Provide put_user_gcs() Mark Brown
2024-08-22  1:15 ` Mark Brown [this message]
2024-08-22  1:15 ` [PATCH v11 11/39] arm64/cpufeature: Runtime detection of Guarded Control Stack (GCS) Mark Brown
2024-08-22  1:15 ` [PATCH v11 12/39] arm64/mm: Allocate PIE slots for EL0 guarded control stack Mark Brown
2024-08-22  1:15 ` [PATCH v11 13/39] mm: Define VM_SHADOW_STACK for arm64 when we support GCS Mark Brown
2024-08-22 10:14   ` Catalin Marinas
2024-08-22  1:15 ` [PATCH v11 14/39] arm64/mm: Map pages for guarded control stack Mark Brown
2024-08-22 10:19   ` Catalin Marinas
2024-08-22  1:15 ` [PATCH v11 15/39] KVM: arm64: Manage GCS access and registers for guests Mark Brown
2024-08-22  1:15 ` [PATCH v11 16/39] arm64/idreg: Add overrride for GCS Mark Brown
2024-08-22 11:30   ` Catalin Marinas
2024-08-22  1:15 ` [PATCH v11 17/39] arm64/hwcap: Add hwcap " Mark Brown
2024-08-22 11:31   ` Catalin Marinas
2024-08-22  1:15 ` [PATCH v11 18/39] arm64/traps: Handle GCS exceptions Mark Brown
2024-08-22 11:31   ` Catalin Marinas
2024-08-22 15:44   ` Catalin Marinas
2024-08-22 16:31     ` Mark Brown
2024-08-22  1:15 ` [PATCH v11 19/39] arm64/mm: Handle GCS data aborts Mark Brown
2024-08-22 16:12   ` Catalin Marinas
2024-08-22 16:44     ` Mark Brown
2024-08-22 17:19       ` Catalin Marinas
2024-08-22 17:30         ` Mark Brown
2024-08-22  1:15 ` [PATCH v11 20/39] arm64/gcs: Context switch GCS state for EL0 Mark Brown
2024-08-22 16:15   ` Catalin Marinas
2024-08-22  1:15 ` [PATCH v11 21/39] arm64/gcs: Ensure that new threads have a GCS Mark Brown
2024-08-22 16:17   ` Catalin Marinas
2024-08-22 16:24     ` Mark Brown
2024-08-22  1:15 ` [PATCH v11 22/39] arm64/gcs: Implement shadow stack prctl() interface Mark Brown
2024-08-22  1:15 ` [PATCH v11 23/39] arm64/mm: Implement map_shadow_stack() Mark Brown
2024-08-22  1:15 ` [PATCH v11 24/39] arm64/signal: Set up and restore the GCS context for signal handlers Mark Brown
2024-08-23  9:11   ` Catalin Marinas
2024-08-22  1:15 ` [PATCH v11 25/39] arm64/signal: Expose GCS state in signal frames Mark Brown
2024-08-23  9:37   ` Catalin Marinas
2024-08-23 10:25     ` Mark Brown
2024-08-23 15:59       ` Catalin Marinas
2024-08-23 22:01         ` Mark Brown
2024-08-26 10:00           ` Catalin Marinas
2024-08-28 17:32             ` Mark Brown
2024-08-22  1:15 ` [PATCH v11 26/39] arm64/ptrace: Expose GCS via ptrace and core files Mark Brown
2024-08-23  9:41   ` Catalin Marinas
2024-08-22  1:15 ` [PATCH v11 27/39] arm64: Add Kconfig for Guarded Control Stack (GCS) Mark Brown
2024-08-23  9:48   ` Catalin Marinas
2024-08-22  1:15 ` [PATCH v11 28/39] kselftest/arm64: Verify the GCS hwcap Mark Brown
2024-08-22  1:15 ` [PATCH v11 29/39] kselftest/arm64: Add GCS as a detected feature in the signal tests Mark Brown
2024-08-22  1:15 ` [PATCH v11 30/39] kselftest/arm64: Add framework support for GCS to signal handling tests Mark Brown
2024-08-22  1:15 ` [PATCH v11 31/39] kselftest/arm64: Allow signals tests to specify an expected si_code Mark Brown
2024-08-22  1:15 ` [PATCH v11 32/39] kselftest/arm64: Always run signals tests with GCS enabled Mark Brown
2024-08-22  1:15 ` [PATCH v11 33/39] kselftest/arm64: Add very basic GCS test program Mark Brown
2024-08-22  1:15 ` [PATCH v11 34/39] kselftest/arm64: Add a GCS test program built with the system libc Mark Brown
2024-08-22  1:15 ` [PATCH v11 35/39] kselftest/arm64: Add test coverage for GCS mode locking Mark Brown
2024-08-22  1:15 ` [PATCH v11 36/39] kselftest/arm64: Add GCS signal tests Mark Brown
2024-08-22  1:15 ` [PATCH v11 37/39] kselftest/arm64: Add a GCS stress test Mark Brown
2024-08-22  1:15 ` [PATCH v11 38/39] kselftest/arm64: Enable GCS for the FP stress tests Mark Brown
2024-08-22  1:15 ` [PATCH v11 39/39] KVM: selftests: arm64: Add GCS registers to get-reg-list Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240822-arm64-gcs-v11-10-41b81947ecb5@kernel.org \
    --to=broonie@kernel.org \
    --cc=Szabolcs.Nagy@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=brauner@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=debug@rivosinc.com \
    --cc=ebiederm@xmission.com \
    --cc=fweimer@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=james.morse@arm.com \
    --cc=kees@kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=oleg@redhat.com \
    --cc=oliver.upton@linux.dev \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=ross.burton@arm.com \
    --cc=shuah@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=thiago.bauermann@linaro.org \
    --cc=wilco.dijkstra@arm.com \
    --cc=will@kernel.org \
    --cc=yury.khrustalev@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox