From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07009C52D7C for ; Wed, 21 Aug 2024 11:28:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A88C6B00FF; Wed, 21 Aug 2024 07:28:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8567A6B0100; Wed, 21 Aug 2024 07:28:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71E0C6B0101; Wed, 21 Aug 2024 07:28:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4D1806B00FF for ; Wed, 21 Aug 2024 07:28:58 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E3CBDA7A63 for ; Wed, 21 Aug 2024 11:28:57 +0000 (UTC) X-FDA: 82476030714.18.62A5A68 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf04.hostedemail.com (Postfix) with ESMTP id CE02B40006 for ; Wed, 21 Aug 2024 11:28:54 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724239655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8IgB3cqcc8y1nLMTiYM3E62MxZj9PgYc9tYlOm2LpW8=; b=4VBP8d6dL6m0QAjCDDJGTjAG0JkR7ERBRN27UGXUsXMiNj0sRNvADnp9oQYx8XDxpEqiVe AHEfc8kmXtLUEiVx0DmU8V7Dsjp8eHZYOHmZhgXnrBPkMn0b8qdwxZdLg9nsAJVKxg1uxN XdR+TgMfb9JKYdPrAcdheCzHZsswmn0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724239655; a=rsa-sha256; cv=none; b=JrGsak/MVBgKXhN1Kv7+D0kkGPuTv6BuVBeWj2QnAAmUGav94aMyRHtec04UYWMU+4QLRZ a2EEO+TKqhhRTm2uuAL1i0NxkWIWMvwofaR4ODglAB3kiab200uBtNiPmZs36TTFyb5X+V /kEo4sLc9behQTFbkMUcUV4bb41NHLc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WpkXm5yH7z6D9Bh; Wed, 21 Aug 2024 19:25:44 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id A576D140B18; Wed, 21 Aug 2024 19:28:50 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 21 Aug 2024 12:28:49 +0100 Date: Wed, 21 Aug 2024 12:28:48 +0100 From: Jonathan Cameron To: Tong Tiangen CC: Mark Rutland , Catalin Marinas , Will Deacon , Andrew Morton , James Morse , "Robin Murphy" , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Michael Ellerman , Nicholas Piggin , Andrey Ryabinin , Alexander Potapenko , Christophe Leroy , Aneesh Kumar K.V , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , , , , , , Guohanjun Subject: Re: [PATCH v12 4/6] arm64: support copy_mc_[user]_highpage() Message-ID: <20240821122848.00004047@Huawei.com> In-Reply-To: <8257d76b-c700-89a6-0e29-f194d2e1cd61@huawei.com> References: <20240528085915.1955987-1-tongtiangen@huawei.com> <20240528085915.1955987-5-tongtiangen@huawei.com> <20240819125601.0000687b@Huawei.com> <8257d76b-c700-89a6-0e29-f194d2e1cd61@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CE02B40006 X-Stat-Signature: fhuhqmuuip8jdbix555gab9q4bzmfhhe X-HE-Tag: 1724239734-79940 X-HE-Meta: U2FsdGVkX18nKlTCxMx1G4x5deRiwR/gWbd2Hs+96GLGMt2BGkH1LTLNcdusSuROa27vMteROQPuagc/udLmN5GJezYbHPWsPhbGGGF23+YMszbPA1ZmqYIaOG2hthREIzipYSOihNLJMgAXNv7VuKfDzOAHbTdKs6vk6y8Pt3hUAJdb0BbIPOyz7uYqDCPh2X6VMjiD6beuzI6BfxrftlfJxM4spNtnv2R4ZPhtrz8Uu3lOkB0ibQTEBfx+lgImVTvRCikcoYgoG37Wbr2YAudCD0jgJfY+ypxLrLtOiOVXpBoGjItqq59RhTyfnhRMHfeq0pZXkwAR65QLQFmgyj//QZhnPDGqAzZNP4yHNdkb7W3eGjKZlY6eht8s3pCyNgmdbJJJEn1PWkcWxkANM3IS5gLqMMZGj+O0rJRdg5aaSf2BQsRYetGE9/dcR+p6aHiJpCyoKR4ohDIgkFHtejQYVNySOz+FTomNN4+t9OCbUktvwnZZ7WIm0rt+gz2I4513SBx1BFFgJ8dr28xQ2diiKV0gfWxPJ27fhlfqCNMX5Rn8I5SYn5ryH9FMs5vl+fMhuLjCswoCwlZ9L6wRtPsECppLZ4IqFLuRnfbwzce+1bDggqgN3g5qG+Plqhr6PGLf++n4JqV0AqLS1FybdJf50Q0/egj82/J3N5CTkmDKhNPTaAFB5erH9i4CORQg7ZQI9NkQIiVdO823lJvgmQamdq4GxnayEiZWvCK/S6hWB8OhMLobdYONuHm5NmYw95quz4zZ6MB911KP9jQgaTCcvJe/foghf5Hpw6Q+fZwY6pawyrYEReabWPToE5paLN1FTno4SldnFti969rGgVidOpJ72oRCw4hxgH5FA7u3nllp+RUmn5o0+uTB3Ow8cs5pIRiI24k0dxu43Rwq7G2Kwxh5Bobo8UFc9O0xQeLa8FP5yzQc5bOoqKMkjk542n6O39eroK9TY37tQUx aXxqgQ4v UZSxqZi2cpdoX+e19IDx7YJyFYLLoED9YnO8Bi4NKvOLWsGURNG7P/xNTC7jkFNh0+q4xNIoyuFZ867NZJEMe+l/Mob+QR8Egs/5aWwawWGxi3w7xki8qUwmizc5gc4xYAbcoUAWOAp2dk7NT8Yyj1G7GLuOugP1CRjJ59UDG5UeGJRTfyE7oXD9B9nKRJ65zQ3wd4qnDpTnkyQ/R64wvxpkYHP3EYI+l25ThKkke2Dp5LZ9BVf73JERL7TYZrAvtb256jCNh4l55aiG3lPrLP94MCZ94KB4FH6hWAbHr0StFfHDC7zNXxVwdI2inhr1kXzyexsEn2/Sr3TPBOTlrIrSXlR574Uvcx6h1nmDRPgC4aJ+e6deNN61dac64MSXpV3N2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 20 Aug 2024 11:02:05 +0800 Tong Tiangen wrote: > =E5=9C=A8 2024/8/19 19:56, Jonathan Cameron =E5=86=99=E9=81=93: > > On Tue, 28 May 2024 16:59:13 +0800 > > Tong Tiangen wrote: > > =20 > >> Currently, many scenarios that can tolerate memory errors when copying= page > >> have been supported in the kernel[1~5], all of which are implemented by > >> copy_mc_[user]_highpage(). arm64 should also support this mechanism. > >> > >> Due to mte, arm64 needs to have its own copy_mc_[user]_highpage() > >> architecture implementation, macros __HAVE_ARCH_COPY_MC_HIGHPAGE and > >> __HAVE_ARCH_COPY_MC_USER_HIGHPAGE have been added to control it. > >> > >> Add new helper copy_mc_page() which provide a page copy implementation= with > >> hardware memory error safe. The code logic of copy_mc_page() is the sa= me as > >> copy_page(), the main difference is that the ldp insn of copy_mc_page() > >> contains the fixup type EX_TYPE_KACCESS_ERR_ZERO_ME_SAFE, therefore, t= he > >> main logic is extracted to copy_page_template.S. > >> > >> [1] commit d302c2398ba2 ("mm, hwpoison: when copy-on-write hits poison= , take page offline") > >> [2] commit 1cb9dc4b475c ("mm: hwpoison: support recovery from HugePage= copy-on-write faults") > >> [3] commit 6b970599e807 ("mm: hwpoison: support recovery from ksm_migh= t_need_to_copy()") > >> [4] commit 98c76c9f1ef7 ("mm/khugepaged: recover from poisoned anonymo= us memory") > >> [5] commit 12904d953364 ("mm/khugepaged: recover from poisoned file-ba= cked memory") > >> > >> Signed-off-by: Tong Tiangen =20 > > Trivial stuff inline. > >=20 > > Jonathan =20 >=20 > I'm sorry, I may not have understood what you meant. Where is the better > place to do inline? :) Oops. All I meant was: My comments are inline - as in within the patch later in the email.