linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: <hanchuanhua@oppo.com>
To: <akpm@linux-foundation.org>, <linux-mm@kvack.org>
Cc: <baolin.wang@linux.alibaba.com>, <chrisl@kernel.org>,
	<david@redhat.com>, <hannes@cmpxchg.org>, <hughd@google.com>,
	<kaleshsingh@google.com>, <kasong@tencent.com>,
	<linux-kernel@vger.kernel.org>, <mhocko@suse.com>,
	<minchan@kernel.org>, <nphamcs@gmail.com>, <ryan.roberts@arm.com>,
	<senozhatsky@chromium.org>, <shakeel.butt@linux.dev>,
	<shy828301@gmail.com>, <surenb@google.com>,
	<v-songbaohua@oppo.com>, <willy@infradead.org>,
	<xiang@kernel.org>, <ying.huang@intel.com>,
	<yosryahmed@google.com>, <hch@infradead.org>, <ryncsn@gmail.com>,
	Chuanhua Han <hanchuanhua@oppo.com>
Subject: [PATCH v7 1/2] mm: add nr argument in mem_cgroup_swapin_uncharge_swap() helper to support large folios
Date: Wed, 21 Aug 2024 15:45:39 +0800	[thread overview]
Message-ID: <20240821074541.516249-2-hanchuanhua@oppo.com> (raw)
In-Reply-To: <20240821074541.516249-1-hanchuanhua@oppo.com>

From: Barry Song <v-songbaohua@oppo.com>

With large folios swap-in, we might need to uncharge multiple entries
all together, add nr argument in mem_cgroup_swapin_uncharge_swap().

For the existing two users, just pass nr=1.

Signed-off-by: Barry Song <v-songbaohua@oppo.com>
Signed-off-by: Chuanhua Han <hanchuanhua@oppo.com>
Acked-by: Chris Li <chrisl@kernel.org>
---
 include/linux/memcontrol.h | 5 +++--
 mm/memcontrol.c            | 7 ++++---
 mm/memory.c                | 2 +-
 mm/swap_state.c            | 2 +-
 4 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index fe05fdb92779..780120f7b9dd 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -699,7 +699,8 @@ int mem_cgroup_hugetlb_try_charge(struct mem_cgroup *memcg, gfp_t gfp,
 
 int mem_cgroup_swapin_charge_folio(struct folio *folio, struct mm_struct *mm,
 				  gfp_t gfp, swp_entry_t entry);
-void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry);
+
+void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry, unsigned int nr_pages);
 
 void __mem_cgroup_uncharge(struct folio *folio);
 
@@ -1206,7 +1207,7 @@ static inline int mem_cgroup_swapin_charge_folio(struct folio *folio,
 	return 0;
 }
 
-static inline void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry)
+static inline void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry, unsigned int nr)
 {
 }
 
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 42c826eec124..fd74a20f23a7 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4574,14 +4574,15 @@ int mem_cgroup_swapin_charge_folio(struct folio *folio, struct mm_struct *mm,
 
 /*
  * mem_cgroup_swapin_uncharge_swap - uncharge swap slot
- * @entry: swap entry for which the page is charged
+ * @entry: the first swap entry for which the pages are charged
+ * @nr_pages: number of pages which will be uncharged
  *
  * Call this function after successfully adding the charged page to swapcache.
  *
  * Note: This function assumes the page for which swap slot is being uncharged
  * is order 0 page.
  */
-void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry)
+void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry, unsigned int nr_pages)
 {
 	/*
 	 * Cgroup1's unified memory+swap counter has been charged with the
@@ -4601,7 +4602,7 @@ void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry)
 		 * let's not wait for it.  The page already received a
 		 * memory+swap charge, drop the swap entry duplicate.
 		 */
-		mem_cgroup_uncharge_swap(entry, 1);
+		mem_cgroup_uncharge_swap(entry, nr_pages);
 	}
 }
 
diff --git a/mm/memory.c b/mm/memory.c
index 93c0c25433d0..b9fe2f354878 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -4101,7 +4101,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf)
 					ret = VM_FAULT_OOM;
 					goto out_page;
 				}
-				mem_cgroup_swapin_uncharge_swap(entry);
+				mem_cgroup_swapin_uncharge_swap(entry, 1);
 
 				shadow = get_shadow_from_swap_cache(entry);
 				if (shadow)
diff --git a/mm/swap_state.c b/mm/swap_state.c
index a042720554a7..4669f29cf555 100644
--- a/mm/swap_state.c
+++ b/mm/swap_state.c
@@ -522,7 +522,7 @@ struct folio *__read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask,
 	if (add_to_swap_cache(new_folio, entry, gfp_mask & GFP_RECLAIM_MASK, &shadow))
 		goto fail_unlock;
 
-	mem_cgroup_swapin_uncharge_swap(entry);
+	mem_cgroup_swapin_uncharge_swap(entry, 1);
 
 	if (shadow)
 		workingset_refault(new_folio, shadow);
-- 
2.43.0



  reply	other threads:[~2024-08-21  7:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21  7:45 [PATCH v7 0/2] mm: Ignite large folios swap-in support hanchuanhua
2024-08-21  7:45 ` hanchuanhua [this message]
2024-08-21  7:45 ` [PATCH v7 2/2] mm: support large folios swap-in for sync io devices hanchuanhua
2024-08-21 17:31   ` Shakeel Butt
2024-08-21 21:13     ` Barry Song
2024-08-23 17:56       ` Shakeel Butt
2024-08-26 19:46         ` Barry Song
2024-08-29  1:01           ` Kanchana P Sridhar
2024-08-29  2:24             ` Barry Song
2024-08-29  2:38               ` Sridhar, Kanchana P
2024-09-03 18:24   ` Kairui Song
2024-09-03 18:38     ` Yosry Ahmed
2024-09-03 20:07       ` Andrew Morton
2024-09-03 21:36         ` Barry Song
2024-09-03 22:05           ` Yosry Ahmed
2024-09-04 21:30             ` Usama Arif
2024-09-04 23:10               ` Barry Song
2024-09-04 23:23                 ` Usama Arif
2024-09-04 23:27                   ` Barry Song
2024-09-04 23:35                   ` Yosry Ahmed
2024-09-22 23:57                     ` Barry Song
2024-09-23 10:22                       ` Usama Arif
2024-09-23 12:10                         ` Johannes Weiner
2024-09-23 16:53                           ` Yosry Ahmed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240821074541.516249-2-hanchuanhua@oppo.com \
    --to=hanchuanhua@oppo.com \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=chrisl@kernel.org \
    --cc=david@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=hch@infradead.org \
    --cc=hughd@google.com \
    --cc=kaleshsingh@google.com \
    --cc=kasong@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=nphamcs@gmail.com \
    --cc=ryan.roberts@arm.com \
    --cc=ryncsn@gmail.com \
    --cc=senozhatsky@chromium.org \
    --cc=shakeel.butt@linux.dev \
    --cc=shy828301@gmail.com \
    --cc=surenb@google.com \
    --cc=v-songbaohua@oppo.com \
    --cc=willy@infradead.org \
    --cc=xiang@kernel.org \
    --cc=ying.huang@intel.com \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox