From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4564C531DF for ; Wed, 21 Aug 2024 01:41:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 457036B009A; Tue, 20 Aug 2024 21:41:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4039E6B00A2; Tue, 20 Aug 2024 21:41:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A4E76B00A4; Tue, 20 Aug 2024 21:41:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0AA186B009A for ; Tue, 20 Aug 2024 21:41:17 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 87D6BC075C for ; Wed, 21 Aug 2024 01:41:16 +0000 (UTC) X-FDA: 82474549752.02.BDD20A1 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf26.hostedemail.com (Postfix) with ESMTP id 6B0DB140003 for ; Wed, 21 Aug 2024 01:41:14 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=C9G0mhso; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724204435; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+/u6W4WSFvTj9eIxHCq8p06c4luv6oiysHUIxDwr1Lw=; b=SKMaNLrIz+Bf1hIOKS0BZM2nXf+HQwSV8rf+usGjzUZZvHa6tPjmkWtjDI3IBfyKdfc882 j/yMNRzkXPYyrn3jTFWAjUYYejOMvy6vSdJFYujFZYJhdS9f3MXo1xkirgsbgrRSwJ6shu UxQ3n/W+uioyKHUnnZqxzsJqQLG8KI0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=C9G0mhso; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724204435; a=rsa-sha256; cv=none; b=ACKLOvTYby7YgKwgp8bp2OjYH9R6FkkQF5N1Wya3f6nKmfxfR20cmn58HhtSKNWX4j8r4f SVjQ41kXqGDSNzDeKw8tMg5mRrfVTGvqbUEhsSVirAX2Hwt0iKNxD7kIU21VwD9DdvAjwD FH6pFcEw2/7m960sFcULqZ8P2M6jDA4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 081F3CE0CDF; Wed, 21 Aug 2024 01:41:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF7C8C4AF09; Wed, 21 Aug 2024 01:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1724204470; bh=ilzPKcaFWeNz+HDTPh3ofMSoN75Ggz9gbOHWcMHuGMs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C9G0mhso2iOXD/JGL4fVTx0cDizeojFY3XRjZnEJwAgXus68k4y68vAdnLXSy/shy f4t2pxBeKjd6oz0itH1dUg2HO17jUlRqxcNsx6ANVjJnqytXWTXrvz7LncHGcnbBuT v8E0zK7DuM+1MpY6C+cKhojZwOouFX+Gnh3309Xo= Date: Tue, 20 Aug 2024 18:41:09 -0700 From: Andrew Morton To: Zi Yan Cc: Kefeng Wang , David Hildenbrand , Oscar Salvador , linux-mm@kvack.org, Matthew Wilcox Subject: Re: [PATCH] mm: remove migration for HugePage in isolate_single_pageblock() Message-Id: <20240820184109.ecfe8578870e1aecc658e94b@linux-foundation.org> In-Reply-To: <5D57871E-0360-40F5-A3E3-B3DAD0B2F5BF@nvidia.com> References: <20240816040625.650053-1-wangkefeng.wang@huawei.com> <5D57871E-0360-40F5-A3E3-B3DAD0B2F5BF@nvidia.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 6B0DB140003 X-Stat-Signature: m6m9ydu45qr6kygkjs9spq7t4j5g6g6z X-HE-Tag: 1724204474-578691 X-HE-Meta: U2FsdGVkX1+z4+17MiapmWxodUEM4fQjTQ/qNdUjZZqmd1FhfDF0XEzGlHMvasCi1k/6WEkMpplFo+rcNWzXSGb5RSx68n+zQe4eKyaZItcxGzrmAePWBONi4PwCIqymj5YrGO10KATfhJ4SHHgw6AcJpPIx4uVHg88un0x9tovHn/Vu4jgjG6K5C4JiDO8OmCKwO156wTeuA0DaJtxHVnnI9x7gfbMPP6nS0ruKM+02NG+hnmfmA2nNtvmFxKqGySzAub1I7fW2jayfN2gfdW/cw+WnuqM2wl3t0jUxnYbcBQ4PHnymCbv1PhzPZENPirLgvDtcZEIp2qnYCt+AThGy2JBF93DtNlAXKcVdXWkvRyph30qxRMEWM39VOFc6fp2pbDXY8nL/HbGoNrsU8Mh3p5c/lKFgmg4vWVlDptfoJBfbkmRVZwzgns+ctBVdW4AORgBqX7hoNu7smXa3BrEvMITeUUWyYoBgqWWyzh40Q4uRcFyU9bJVor6x35LGszMe5eLxnI6zHLapThMGOJeDU9xtJyTP2FFImrw6E4Uef/QsHi6PKkxh56iu43J6NgnJUlnabjr6dWw1Gy/BU8Lr/WMuQ/O08proiXo+4est4VnJ5KkODK+rccyYiICarSbvyPGCvQwL4t5UyUphL4zOwB1AeeeYWDeiHMvyy9MNlLIi07qa4OpK/l0ObNcFl4ADg9F3EgB7qAeCEPErM97jvUOpk/SJ7hN0WKyjjtjtGgOQrQ7MHrJvW/gzFVLp+0bv5euv2Yt/olU00oHyfWZasKIjo/pscBqp6gJxIAO2zo0flYKZsNOzcKSCRMZIf6bKsOLggWIKGZgdRso6j4mN6BJw+KlrNpBpfe4EjGtRpSEKuQDDHX+/jGIFyfaMA26wjadweYgL+luG+MYkOPAnf4SHwr7K9yc6vxCLgdOJ8cr5YCWYLxVzkyZCliUd1wYdvz5pjUtqCJX2/z0 Ffjq+Vr5 m59eX8wxFE1O+5+bIoTWjZ8htAkYl/6CBFhopA9SiBlm4IthCwZAJg9CflPiqSX5KpQVVP5Tf7Zx8avg4ObAObp37acGd5SPcfmCYDoWvBVIq3viJ1Y0A4Z/+LVzV5f9DJA+SV5/Ns08LL0JmKuKLYMvyo/4xpwedlVQuypLq/ch6dlGhwkryn6gCznb8GpKPwYBeJyxV3dxidXB29PsT4E6fRifybjtbB32WJWl2DEvaOfHF/rHoqP34FMmsSXY7fsMLzJOWHT5bceMvf8pJ2eHBygAgZ6bTiZoj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 17 Aug 2024 19:58:07 -0400 Zi Yan wrote: > > Please correct me or help to write better description, thanks. > > How about? > > Gigantic PageHuge is bigger than a pageblock, but since it is freed as order-0 pages, > its pageblocks after being freed will get to the right free list. There is no need > to have special handling code for them in start_isolate_page_range(). For both > alloc_contig_range() and memory offline cases, the migration code after > start_isolate_page_range() will be able to migrate gigantic PageHuge when possible. > Let's clean up start_isolate_page_range() and fix the aforementioned memory offline > failure issue all together. Thanks, I updated the changelog with the above.