From: Andrew Morton <akpm@linux-foundation.org>
To: Zi Yan <ziy@nvidia.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>,
David Hildenbrand <david@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
linux-mm@kvack.org, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH] mm: remove migration for HugePage in isolate_single_pageblock()
Date: Tue, 20 Aug 2024 18:41:09 -0700 [thread overview]
Message-ID: <20240820184109.ecfe8578870e1aecc658e94b@linux-foundation.org> (raw)
In-Reply-To: <5D57871E-0360-40F5-A3E3-B3DAD0B2F5BF@nvidia.com>
On Sat, 17 Aug 2024 19:58:07 -0400 Zi Yan <ziy@nvidia.com> wrote:
> > Please correct me or help to write better description, thanks.
>
> How about?
>
> Gigantic PageHuge is bigger than a pageblock, but since it is freed as order-0 pages,
> its pageblocks after being freed will get to the right free list. There is no need
> to have special handling code for them in start_isolate_page_range(). For both
> alloc_contig_range() and memory offline cases, the migration code after
> start_isolate_page_range() will be able to migrate gigantic PageHuge when possible.
> Let's clean up start_isolate_page_range() and fix the aforementioned memory offline
> failure issue all together.
Thanks, I updated the changelog with the above.
prev parent reply other threads:[~2024-08-21 1:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 4:06 Kefeng Wang
2024-08-16 4:58 ` Andrew Morton
2024-08-16 6:10 ` Kefeng Wang
2024-08-16 10:11 ` David Hildenbrand
2024-08-16 11:30 ` Kefeng Wang
2024-08-16 15:06 ` Zi Yan
2024-08-16 20:12 ` David Hildenbrand
2024-08-16 21:16 ` Yu Zhao
2024-08-16 22:09 ` Zi Yan
2024-08-16 19:45 ` David Hildenbrand
2024-08-17 6:13 ` Kefeng Wang
2024-08-17 23:58 ` Zi Yan
2024-08-19 2:42 ` Kefeng Wang
2024-08-21 1:41 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240820184109.ecfe8578870e1aecc658e94b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox