From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A37C3DA4A for ; Tue, 20 Aug 2024 09:18:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9E3B6B007B; Tue, 20 Aug 2024 05:18:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C27806B0082; Tue, 20 Aug 2024 05:18:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA0CF6B0083; Tue, 20 Aug 2024 05:18:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 884DB6B007B for ; Tue, 20 Aug 2024 05:18:15 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E6257A9262 for ; Tue, 20 Aug 2024 09:18:14 +0000 (UTC) X-FDA: 82472072508.16.9AF580A Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by imf18.hostedemail.com (Postfix) with ESMTP id 0F35F1C0016 for ; Tue, 20 Aug 2024 09:18:11 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=1TpC3XNR; spf=pass (imf18.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724145415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f+ICdms72HfoF4mAv99/z3Z6CJn/38fKcvyPjiB+emU=; b=1H63PFGmHxIY62ENk8vyoWTrDsZpvBuAb+DNt5iaBxENoexeViKhe/W1tCJM5MuNHWRtBv QLu7tITqN1aTjKQtS5g3NQMgcMTxN9jNt7B6RVjZgT/xCUOpn3EEORHXk8v8HUWZ/gyhdG dWSr8OFRXaBmwnJoCHL+xlhSos96U3U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724145415; a=rsa-sha256; cv=none; b=3QyY+pbvFUOO/LBoKLOR+b5di5OoXQgpalHZv5SXB1PIQxkkDkb//guL+D62CnCpJbpE3R F8DFfLPD4dstq855L9JznEIaWHY5BsjyG08nqFbx2os2mANkTZO382FglG2cAjahaHWmXN mA9ffTAKmH9WktlfC75/wGfYtPi+u2s= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=1TpC3XNR; spf=pass (imf18.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Wp3lz2FtCz9sbL; Tue, 20 Aug 2024 11:18:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1724145487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f+ICdms72HfoF4mAv99/z3Z6CJn/38fKcvyPjiB+emU=; b=1TpC3XNRabaGO7N5sW4gKUNX5AldqRHL0F+Q59ySDOOMW11dpqYvmdHXKrjFzE9+kEuAZc xD7L+OQgpO1UWy0xxTYs0ehlCqmrkOSejl8Sm3hgg0pwypovKKLdlPC/yO9YEUWCttiG55 585Ut50eLrkQdYnUR3ZqzFFJnbXHKWs/A4N4A1YpvDJWifoBUhRebkRmuajq9lQ5LZSKH3 Btk12vH/oJvaKJsnGa20r52My7EROT0wIyldnP6WuodgZr9oQp+zzd5CpdUeCOABlVJ6Fk olyyXoEJURraAgRQFMmi/973uUUnaxScwem2gEIjqq1nD6LuiZXVyiVaIwY4Cg== Date: Tue, 20 Aug 2024 09:17:59 +0000 From: "Pankaj Raghav (Samsung)" To: David Howells Cc: brauner@kernel.org, akpm@linux-foundation.org, chandan.babu@oracle.com, linux-fsdevel@vger.kernel.org, djwong@kernel.org, hare@suse.de, gost.dev@samsung.com, linux-xfs@vger.kernel.org, hch@lst.de, david@fromorbit.com, Zi Yan , yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, john.g.garry@oracle.com, cl@os.amperecomputing.com, p.raghav@samsung.com, mcgrof@kernel.org, ryan.roberts@arm.com Subject: Re: [PATCH v12 00/10] enable bs > ps in XFS Message-ID: <20240820091759.vogo5uxaldvik2u2@quentin> References: <20240819163938.qtsloyko67cqrmb6@quentin> <20240818165124.7jrop5sgtv5pjd3g@quentin> <20240815090849.972355-1-kernel@pankajraghav.com> <2924797.1723836663@warthog.procyon.org.uk> <3402933.1724068015@warthog.procyon.org.uk> <3458347.1724092844@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3458347.1724092844@warthog.procyon.org.uk> X-Rspamd-Queue-Id: 0F35F1C0016 X-Stat-Signature: ucs183ypzdrebngxhfqhismdc4xd9hu1 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724145491-309413 X-HE-Meta: U2FsdGVkX1+YJbVOVG6vbVWYWA9k/2f38O42TSnUNucqB/0gXB/H+Lv6qsRQ4Zdue7HQAz0dJNR5WNKmzSx2nZNqlxv3PbP5WpFYDBBfQrancrKplSO/8Gl6urUMmyRLmxSv9CnOPuKrvztjgmnM87voQgNMCkNcOAPkt9pbCHqWIlAt6nyZs4YwFKBLdOQrM3dMVDZyUmoDuy0SndvbYrwfvUtHhiHgQ1ekOQg5Ez9wq78uNPt1J0fEtxJb+U8SeT792LHIYr4e/3pAz5F2f0aywLvP36UppyxxogpJZtMh+lMxeSybgUhjvFJNjuzySUs6FMd996RPn+pblWJx5La68A969RggWiqo8Le3iCS5O2JKPdpth2KPCZXTgrEXSEFSyBdi9tjEjw904RBWzVz2vgGV+Sdgo1CiCE7SnGmt5lO6DNzCh7zQgyDsAU4TSUleUExhhaYfEzTNS9F1tA/pKiI5AnSXj/C5xPdpnMLfTy52vZ30QO6zqqtY6YpE1IFWGJ+p5tliXDKCL1g6olCZ1Psm/tIsMgX1dQf7tWn8d6oJAWZY4FBOEwDkYMs6ax6QjHLafB+DBEjAOi7VvhN47etCFsseR1OcvYAUEmetd+TQG+A09htmcP3BzamuvEp0ZWHoBIaCNF1Mdo7z3HioryZ9zlrIMfCnzTqCjAuaR7AafT9MOc/sJYdOxPVutFn3gqKxGbU6mDovxJhDB4iGdu4/jslDGblxtX9QZcyq6gMYKSZ6kZPCx3UUyEG0WvHflW3lJTe9FOoV+DSESBGpl7dNUCayFxfjgJQzw8ZZU63z4U/NtjVgHslZQLFsWTBo2anTSbfFQ501M6sCQYAhbQtZ9FrjxT9885BtfODWrehu/7aLOIfEASyEphp/Sq0VDxgez+BM0P99ChHUaptJ3eCoE9n+WmbfWa7ZD3K8iCTMJgcOiu0LHo1FdVPXwvFZd1wLGTcJLVGfSeV t8t//8yv 38YuqnV67jGv0Tjhkg3T1IRitN3WjGtB/fKvyXR44EUrIpytmzAAoYORo5sCPYQo7+iorG/eIQln6AJ/OjgSR9Jx4F7Mfmr4QyES0mBYImrfHMtAlmc1J07FnOCmt1WBrXzSc1oEzCNtQ2wNzGJhgkSosFYRN1UW3gZEm9GRbF7+mJmyjXIb5063Q+CynfjfNibr4g6xHncVQhxXrLwjMrur6I4vOyy3Ex+t0e3eJzlC1AyIYdxFESYAXAVQ2JrVl3/9aUDMGU9Pym4AZbA6wFJe3FQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 19, 2024 at 07:40:44PM +0100, David Howells wrote: > Pankaj Raghav (Samsung) wrote: > > > I tried this code on XFS, and it is working as expected (I am getting > > xxxx). > > XFS doesn't try to use mapping_set_release_always(). Thanks David for digging deep. It is indeed a bug in this patchset (PATCH 1). I think I overlooked the way we MASK the folio order bits when we changed it sometime back. But still I don't know why AS_RELEASE_ALWAYS is being cleared because it is in BIT 6, and existing bug should not affect BIT 6. The following triggers an ASSERT failure. diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c index 0fcf235e5023..35961d73d54a 100644 --- a/fs/xfs/xfs_icache.c +++ b/fs/xfs/xfs_icache.c @@ -88,9 +88,13 @@ xfs_inode_alloc( /* VFS doesn't initialise i_mode! */ VFS_I(ip)->i_mode = 0; + mapping_set_unevictable(VFS_I(ip)->i_mapping); mapping_set_folio_min_order(VFS_I(ip)->i_mapping, M_IGEO(mp)->min_folio_order); + ASSERT(mapping_unevictable(VFS_I(ip)->i_mapping) == 1); + + mapping_clear_unevictable(VFS_I(ip)->i_mapping); XFS_STATS_INC(mp, vn_active); ASSERT(atomic_read(&ip->i_pincount) == 0); ASSERT(ip->i_ino == 0); The patch that fixes this is: diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index 61a7649d86e5..5e245b8dcfd6 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -217,6 +217,7 @@ enum mapping_flags { #define AS_FOLIO_ORDER_MASK ((1u << AS_FOLIO_ORDER_BITS) - 1) #define AS_FOLIO_ORDER_MIN_MASK (AS_FOLIO_ORDER_MASK << AS_FOLIO_ORDER_MIN) #define AS_FOLIO_ORDER_MAX_MASK (AS_FOLIO_ORDER_MASK << AS_FOLIO_ORDER_MAX) +#define AS_FOLIO_ORDER_MIN_MAX_MASK (AS_FOLIO_ORDER_MIN_MASK | AS_FOLIO_ORDER_MAX_MASK) /** * mapping_set_error - record a writeback error in the address_space @@ -418,7 +419,7 @@ static inline void mapping_set_folio_order_range(struct address_space *mapping, if (max < min) max = min; - mapping->flags = (mapping->flags & ~AS_FOLIO_ORDER_MASK) | + mapping->flags = (mapping->flags & ~AS_FOLIO_ORDER_MIN_MAX_MASK) | (min << AS_FOLIO_ORDER_MIN) | (max << AS_FOLIO_ORDER_MAX); } Could you try this patch and see if it fixes it by any chance? -- Pankaj