From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B740DC5320E for ; Tue, 20 Aug 2024 06:54:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D7276B007B; Tue, 20 Aug 2024 02:54:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45F606B0082; Tue, 20 Aug 2024 02:54:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B1E96B0083; Tue, 20 Aug 2024 02:54:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0AE266B007B for ; Tue, 20 Aug 2024 02:54:49 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7CF44C1820 for ; Tue, 20 Aug 2024 06:54:48 +0000 (UTC) X-FDA: 82471711056.06.D6578DF Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2087.outbound.protection.outlook.com [40.107.117.87]) by imf01.hostedemail.com (Postfix) with ESMTP id 1185340014 for ; Tue, 20 Aug 2024 06:54:44 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=fjwm3FHh; spf=pass (imf01.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.117.87 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; dmarc=pass (policy=quarantine) header.from=oppo.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724136846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=64VfPkM5jiyfI3QlIZiidjo2FiQDaBn0oS3fIM40ors=; b=MZ6xLLRFVeLxLOzB6HPtPA7ADedDOBUEWHyga34NiJg2p8AsyZM7Jd84y0RfLdwRmpyvLP KqYvPmm285wxODwF1rAdzC0WsBIRBq+6F7Da6GYaZLTIu6bK5JpeNKAwkRQtFU9lo45EqH /UPWqqhzF5n6o8p3PVTAhQXLlqgVcPQ= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=fjwm3FHh; spf=pass (imf01.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.117.87 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; dmarc=pass (policy=quarantine) header.from=oppo.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1724136846; a=rsa-sha256; cv=pass; b=O2W6YysFVxEX3SAtZrUNcDf0OsAT6FKGUgANU3AiQQ0NGPSYuD7SwtX09Kkx/MnX/FOtXF G6csyJPcB2Rvu289G0JaeSaSZysWh7txhkMuVn6/bAEHTdzzDEnXTJ23UnmecOWqHEZtjl EoanO+6CFWUbo6a8EGvTVUa3Z7yuKyg= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fvIxPjhL3qROJ5il6ABY2t5jrGGFxo+LY/JcsHr1DW+u+RmzsDkeqO6z0kby++r6GNSgcEAozEZZSZDKDnSH4o8LU0p5MYtVXbd1hwJ1BGgEMppxjA/L36aot7C7YjdrkROcMB5H8RnX+Trkry3eByhZALWTGCZWSVFh/D4RI2XbT780YVeiDHm46faH+ALDPbgG6MQgCaur2iIaXqYEtVSyQFbhE5w7Zi7jz/we0HeFpG268n8CKcebssiZ6TdkhrbwdrptpeIuJCr94vm7tHLGlzSLDnywoiMH4pqbZn1a5I+RF5i4F3EJLz9SjgX6EU64JQqJuhm1h1h0PVBvEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=64VfPkM5jiyfI3QlIZiidjo2FiQDaBn0oS3fIM40ors=; b=D74MZywgIvsjFojQdNByvPTr7PTo7AHqnU3IOSYQdRCzoL+ySX8SAjNMCvDPuHX2ReO4n/BBnlwcmM40ILghfhMEmYDhD+vdItmuB3JEoaSxFp1ZZ9bXUj8tLK/FdIwyj4MWvXuW7pTUjNz74BqVqOaDEff3+CKA77kputsQgF7uICpvN08V/hD+VD9/asCdTZRd4MNInxyT/cpHtsuIcTzgd0o7GWh1QuBbC1ff13Y904JEBC/k5AnkMz66QhFyeORARwOrI717AWXCeDnP77fblIZTvi4hRKemm/lFbhkk6mnqR5Px0elbGswgji9S0FNHpYcNqFYvC6NwUUZCPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 58.252.5.68) smtp.rcpttodomain=gmail.com smtp.mailfrom=oppo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=oppo.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=64VfPkM5jiyfI3QlIZiidjo2FiQDaBn0oS3fIM40ors=; b=fjwm3FHhTERPwueJU+YqOJC1CNGr6Zlt6tfR6x5Cy89t2HBraeA10pMjMjhfGeYXyVxuGFazKWkyXH/Jr0Iaus06hcoiz7YR0isgSSWg/0gqU6/nu9wy2cduR1dan5huYzjCNwbmIlpHpzc8GaG0Qje+SdsLTDkSSQZMEdfBk+0= Received: from PS2PR01CA0070.apcprd01.prod.exchangelabs.com (2603:1096:300:57::34) by TYZPR02MB7267.apcprd02.prod.outlook.com (2603:1096:405:40::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.21; Tue, 20 Aug 2024 06:54:39 +0000 Received: from HK2PEPF00006FB0.apcprd02.prod.outlook.com (2603:1096:300:57:cafe::2c) by PS2PR01CA0070.outlook.office365.com (2603:1096:300:57::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.21 via Frontend Transport; Tue, 20 Aug 2024 06:54:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 58.252.5.68) smtp.mailfrom=oppo.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=oppo.com; Received-SPF: Pass (protection.outlook.com: domain of oppo.com designates 58.252.5.68 as permitted sender) receiver=protection.outlook.com; client-ip=58.252.5.68; helo=mail.oppo.com; pr=C Received: from mail.oppo.com (58.252.5.68) by HK2PEPF00006FB0.mail.protection.outlook.com (10.167.8.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7897.11 via Frontend Transport; Tue, 20 Aug 2024 06:54:38 +0000 Received: from oppo.com (172.16.40.118) by mailappw31.adc.com (172.16.56.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 20 Aug 2024 14:54:37 +0800 Date: Tue, 20 Aug 2024 14:54:36 +0800 From: Hailong Liu To: Uladzislau Rezki CC: Michal Hocko , Andrew Morton , Barry Song <21cnbao@gmail.com>, Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , , Baoquan He , Matthew Wilcox , , Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: <20240820065436.7na2c74tuqxmvpbp@oppo.com> References: <20240815220709.47f66f200fd0a072777cc348@linux-foundation.org> <20240816091232.fsliktqgza5o5x6t@oppo.com> <20240816114626.jmhqh5ducbk7qeur@oppo.com> <20240819125738.vbjlw3qbv2v2rj57@oppo.com> <20240820015950.toqohtw7ofpembjg@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [172.16.40.118] X-ClientProxiedBy: mailappw30.adc.com (172.16.56.197) To mailappw31.adc.com (172.16.56.198) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HK2PEPF00006FB0:EE_|TYZPR02MB7267:EE_ X-MS-Office365-Filtering-Correlation-Id: 99a32754-d2f0-4fb3-ac37-08dcc0e4f569 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rYPQWkM5E0kwLQ4kCcOxVBokT85UJdZgXmU31sTGnXqavop344z3uVjZcDYM?= =?us-ascii?Q?y9UyeFKcRskkmWELvhtHAgMkdVGEPvmnGrHUi8LdjjUYjpCsbnHYiXKenvp1?= =?us-ascii?Q?t0tzuhhgQm7TlGUCpVsbKLKai4gDiM4YzBfOv9fzrv1iweY23Y06MAhbUaVY?= =?us-ascii?Q?obB+aVu+PhRpQu5yKjhC+4Hwu4lfBy+vnLdmefIJCXLHqdo92/w3ac1ncoA9?= =?us-ascii?Q?kiZSygeiqw+LEyk/xMNLcmBkLBsA/2lAFwUpB+43GwwFJhhIAv6SxWuQ7kyy?= =?us-ascii?Q?dVwZE+MJ7gXlUw8+FWidGn0Ot6Cq7U0RF/2G9JrkI1T7+CS5bqaWwp37haf9?= =?us-ascii?Q?hjJSzymOFH3M2FiEFKurxAa+BEfdem2zG9BCnN/hpjZB6ui6J3NZsmRe2+m0?= =?us-ascii?Q?LU6ozi9znxMPH3MUxTgxcqtJKmx7ZKrXyBY65ZdmlQTP779/TZkPJXnXZLhM?= =?us-ascii?Q?empIHUK17osqZkyeztGv7c5vH8YtODupqemMdq6j4mWOMgbpA1VTsBf4V7mM?= =?us-ascii?Q?Vrz+heatj/SOasi+zHIJliPdWlpU2tg4bYUypUMOU2L1mxw8tOYH/IXG2Rry?= =?us-ascii?Q?EhcKiq+gAB7kKaUY7P2dJi9KeKqh2Q1211hjQ1OcSoNOFrnX77basBFh91XJ?= =?us-ascii?Q?2V+amdkq+LxR0NUpfXQwT3FRE/9EytJUcfa58wEv9uzsB9rHpbZb4qBLNI+E?= =?us-ascii?Q?XxUuOKTd6D7XY0Rr+iEvngA5hPXY/ztvgJAEKlO5DneyFIe++kGyXNQ9XqLr?= =?us-ascii?Q?yw2j4qORkqVibMTuBgY5WJAToaTMoZ2VuPu3QdwZP1luWnbw2sgHDxX272sw?= =?us-ascii?Q?hBmkBGLuipYRjuS25Egp7VkBEh7YAXuSykNQ2E/VTnsSSMEXaP4wJ7Cid9zc?= =?us-ascii?Q?+a2vIlenwmFrcKN1oRTHG+/X47RIF3HkMw97flkoxzdkKfqYOVgeiVahSQmC?= =?us-ascii?Q?TLo2Qxh4BN/GZP/VZCTDpPbKg2/1Kz99x2TxtjBTBI/CSmvvxNbVoVXD3irc?= =?us-ascii?Q?8J9g4G53cB2KRytDS0nHXeWNz7IDJ49MQfxT2zOToj+82Z/hh/MQm9zY/dTQ?= =?us-ascii?Q?rBMp4KEq6kvTGmraRiHRXB7IKi1AJ2UViPg2oOYsX7V7U3Vtu6YeRApSZl+M?= =?us-ascii?Q?t+TmghAcNRYVLBr3havuf+zPP8y9VJzwvjv3DSrD90tZfkC5Tpq3vWbRu0p4?= =?us-ascii?Q?1lQ5zcQtJAdsQCY4COsmJ8PoVxvq/xZvYugSVVVEdmWLlt4ey/nXGO2OsQYZ?= =?us-ascii?Q?keI/3y8dXSkGrHkh9RBkMCVwEsSYCscuFktdCjKhomHlgdnU40sGoauDUbM/?= =?us-ascii?Q?trSlwcD4hZTb/3AEzbEEcDzA+R/5ENRwv47956HsqQW6szz2ec3majIVtGHU?= =?us-ascii?Q?qVUtD+RW3aDjhf14r0ObNBNjMAoRT325r2uQEP0tiSQNON7MvwOAo8wT351I?= =?us-ascii?Q?TXMIwlsUYpjBeEZUzV6/enHryCX9FNQO?= X-Forefront-Antispam-Report: CIP:58.252.5.68;CTRY:CN;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.oppo.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2024 06:54:38.0468 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99a32754-d2f0-4fb3-ac37-08dcc0e4f569 X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f1905eb1-c353-41c5-9516-62b4a54b5ee6;Ip=[58.252.5.68];Helo=[mail.oppo.com] X-MS-Exchange-CrossTenant-AuthSource: HK2PEPF00006FB0.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR02MB7267 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 1185340014 X-Stat-Signature: ddm8mtc6mspmfz6jz9wwj63q8eggkysk X-HE-Tag: 1724136884-897606 X-HE-Meta: U2FsdGVkX1/590QZAx3KLyA20jS5egR51Yj+NJmgnGpG2x/XGFTNWAAfM5UtNqXPJyZR00jeiMhkj1S8O8HYdESeTgl1N0ZW1BlIVn9s9zBFNiTzjCwnYwx08kXBMSx3qhuiwIk4NxG33q4wAZwrc9BTEks7xtpTSe5sWl/t9Xt7wBG+NosyGWAqjZpFCxjVfmWBwzc49q8gpo7c9i3RDKNNlo00b2h6na1IJkWLFrrCJo4BdW2F+pvpCjcospWAUBjefw1BJEFexZ0n00UX1hQfaS6YSYNCt03DYjzJeowSunotegYZtSadNkS8dUMr0OVDkg4/HAn0XZjGc8JIauGaY+d0n4PLDKI952/RdkimvuMbN1Y0UmKAX7VrmBIiRzOdUigqv3Xqn4T5My/OKf3or6oC4m/6fkxQwMmQUUeYZbRERkDWw60r6L6ekHmET4Q7DGr7kQYHO5F8UFCT3zVDgv+E4oXHvMDUwZl+OFQe1gVaZExJDAOE12D2EfcPJrkwcscJ11NU7MSkYsqbfRskJGv/cDlGIiT5s3b2TVWSbMhlP+DdPH8u3fARhvuuDGsxXYAGHCQ6qC9Y+Z/MVxfxC3VdqX29qVqq1/2z7MFlhV9g2XvxcNq/DSzK3/EM5Atrq/yhGkoHEQ7eGNEZySpOJ0+tMtEOGpSM6v5gY9HL5R8ceYKpgKyM3BZw1GtTru3qXPFlsFI8WetakagVqawJPKhP/qv2gATbpV+B2tEoOsCxt6seWej622DntA3JFQua1tIJ8/pLAz3lD81yjcZWVB2mTpVhf7/WumBCEGvuw4jNxe3Fdav0Fea+PgNfY8S0ChWoPgCPRWCDSKO3tl34Hb73cBbr4Pm7+E5+Tm9zoczf6AgVASAP6hVAXmfkOkKJyPHdgQdEiS5pHztzJijRYV6rgi3XEDfTbr6AhFDEdPGAj1Og4v9jjgP1fQpx8085rQVCcqSHGKxqGSv Gdb0/FUC eUsD1ESvG+ZW991RQz1OXA1DZnZDtfoHKq0lH7vIlPfnUJJ88nWZhU9AbDi5FgBqFB1+aY+6vc8vouNB2kYqEX7ybSPmDwTuxqk2sRs7cXDYVrKboD4rfOwYMi94W2Uw9efGFF+KaoE0v+vt/Bn5KenRy0exn916LYKqued76HgSdWj5Jktraat8IjDECFJZDu9Rv/t+nrx2bQXjM+6N3JvBpomwVFSni0Vbg32PAAADk6tYTdVKp8sTgMHvTOZx4u5U0Vp7LeMkZr3+Lk7TCkXTTriEmXTemp7rMmH2NoC3nptllAclRBCwy96hn76q2Q+b57+3B3i4eQMHfsK/k5XKmGJRt525qVmPaLWxY7JV0q/PghMOmczGhviS6jBmE5tit1vOH2aqKCmWD2lflhHvYW9O01S1q2v+OJZLU8nzrU9kOoDSUiQ1ZAq8ozks91VvFA7nle11JcOL2nWj1XN9k6gxqXRKeprTDgVx4Ry2ZUvepUblUFHGIROH0l+UGCr4DIetbxmkt7xuFQ3rn5TVaTa+Lwc+WCciElmk7pTBg7WXFvkHvW5Zz56fJ9jH2pBwFSxAq0mKQuMI5k9rVC8dXVcmm6OOldzeqVqaeICNhkVfRHpAS248Ssd132ovQK+ay X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 20. Aug 08:44, Uladzislau Rezki wrote: > On Tue, Aug 20, 2024 at 09:59:50AM +0800, Hailong Liu wrote: > > On Mon, 19. Aug 15:38, Uladzislau Rezki wrote: > > > On Mon, Aug 19, 2024 at 08:57:38PM +0800, Hailong Liu wrote: > > > > On Mon, 19. Aug 13:59, Uladzislau Rezki wrote: > > > > > On Fri, Aug 16, 2024 at 07:46:26PM +0800, Hailong Liu wrote: > > > > > > On Fri, 16. Aug 12:13, Uladzislau Rezki wrote: > > > > > > > On Fri, Aug 16, 2024 at 05:12:32PM +0800, Hailong Liu wrote: > > > > > > > > On Thu, 15. Aug 22:07, Andrew Morton wrote: > > > > > > > > > On Fri, 9 Aug 2024 11:41:42 +0200 Uladzislau Rezki wrote: > > > > > > > > > > > > > > > > > > > > > Acked-by: Barry Song > > > > > > > > > > > > > > > > > > > > > > > > because we already have a fallback here: > > > > > > > > > > > > > > > > > > > > > > > > void *__vmalloc_node_range_noprof : > > > > > > > > > > > > > > > > > > > > > > > > fail: > > > > > > > > > > > > if (shift > PAGE_SHIFT) { > > > > > > > > > > > > shift = PAGE_SHIFT; > > > > > > > > > > > > align = real_align; > > > > > > > > > > > > size = real_size; > > > > > > > > > > > > goto again; > > > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > > > This really deserves a comment because this is not really clear at all. > > > > > > > > > > > The code is also fragile and it would benefit from some re-org. > > > > > > > > > > > > > > > > > > > > > > Thanks for the fix. > > > > > > > > > > > > > > > > > > > > > > Acked-by: Michal Hocko > > > > > > > > > > > > > > > > > > > > > I agree. This is only clear for people who know the code. A "fallback" > > > > > > > > > > to order-0 should be commented. > > > > > > > > > > > > > > > > > > It's been a week. Could someone please propose a fixup patch to add > > > > > > > > > this comment? > > > > > > > > > > > > > > > > Hi Andrew: > > > > > > > > > > > > > > > > Do you mean that I need to send a v2 patch with the the comments included? > > > > > > > > > > > > > > > It is better to post v2. > > > > > > Got it. > > > > > > > > > > > > > > > > > > > > But before, could you please comment on: > > > > > > > > > > > > > > in case of order-0, bulk path may easily fail and fallback to the single > > > > > > > page allocator. If an request is marked as NO_FAIL, i am talking about > > > > > > > order-0 request, your change breaks GFP_NOFAIL for !order. > > > > > > > > > > > > > > Am i missing something obvious? > > > > > > For order-0, alloc_pages(GFP_X | __GFP_NOFAIL, 0), buddy allocator will handle > > > > > > the flag correctly. IMO we don't need to handle the flag here. > > > > > > > > > > > Agree. As for comment, i meant to comment the below fallback: > > > > Michal send a craft that make nofail logic more clearer and I check the branch > > > > found Andrew already merged in -stable branch. So we can include these with a > > > > new patch. > > > > > > > Just to confirm. Will you send an extra patch with the comment? > > > > > If this is not urgent, I can send this patch later this week. :) > > > This is for synchronization, so we both do not do a double work :) Ahh I guess you already have a plan, so I don't need to do this. Wating for your patch :) > > -- > Uladzislau Rezki -- Help you, Help me, Hailong.