From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17666C3DA4A for ; Tue, 20 Aug 2024 05:05:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76C0D6B007B; Tue, 20 Aug 2024 01:05:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71BB16B0082; Tue, 20 Aug 2024 01:05:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60A976B0083; Tue, 20 Aug 2024 01:05:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 431B26B007B for ; Tue, 20 Aug 2024 01:05:53 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B7F2B1A17DE for ; Tue, 20 Aug 2024 05:05:52 +0000 (UTC) X-FDA: 82471436544.01.6A4D5AD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id EB579C000F for ; Tue, 20 Aug 2024 05:05:50 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=PMIn2RWX; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724130293; a=rsa-sha256; cv=none; b=Q/j57Rsv3hGPl2c56jWNr3qjOaSFUYzDjB/LKNPzpa4WIGUvtfL+KEbD9zUaX+Tx7dA0Xu f8PRBIvdJj7vRPsSrAgVpa84/wTVM5FAmUmIyXyJmf0owTrdFWhu8vHTaf5j5kR5RmuWUQ 6n8pFRSW5hB0MGRmuItX3ifkScK8cNE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=PMIn2RWX; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724130293; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OIaa6+AfSt2Xza2Ga6ti958sBcssOlciWIffwsGiWLM=; b=VpX0y/QjlHi2ChnJrcZARWWICAOrFPIBHaUy0qwY75yRfLPoIDczjrF9UHTWkFP7z2gENC QQaENym7uIENE4OElOVJ95PYRWTlWr4yvfKdmoROSmBMONYBH1e1akpnK1553/5AfeYA6Z VqfHbCBB1r5FYFiqNrE2OhlDfaedq6M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C159860A0C; Tue, 20 Aug 2024 05:05:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17699C4AF0B; Tue, 20 Aug 2024 05:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1724130349; bh=Qk4x8r7jRJD6hkIYmtG/mztRf8YMFcS8K5ZNtoCas2c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PMIn2RWXlS1k3tsabpC+vfCMInsVGJyUNEOITWfgeANg2b7JoeXNBin+vZ7/T9rCM j6GyRIQqo1/LOxEGVvwKs8CamVyaFDb2UZScOYpHZEkCzl5hqRZV96GmtZ6a+hXdO+ CiZwvFdf7iyfBbbaauyGUnjjQjF17cZ/5ed3/QCU= Date: Mon, 19 Aug 2024 22:05:48 -0700 From: Andrew Morton To: Kairui Song Cc: Naresh Kamboju , Chris Li , linux-mm , open list , lkft-triage@lists.linaro.org, Linux Regressions , Barry Song <21cnbao@gmail.com>, "Huang, Ying" , Hugh Dickins , Kalesh Singh , Ryan Roberts , Anders Roxell Subject: Re: gcc-8: mm/swapfile.c:863:40: error: array subscript 1 is above array bounds of 'struct list_head[1]' [-Werror=array-bounds] Message-Id: <20240819220548.d8f1ea5cf504cfd8feb5780e@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EB579C000F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: dkqfjds1t31k8mdxabrxwcmwozojnhwt X-HE-Tag: 1724130350-279471 X-HE-Meta: U2FsdGVkX1/eVV1n8q4BKN2JECOvseUbb+B/cLHvaYYdsWwTq9Zg2a1AsSJLRxTIxH2+cdwKlEViEVWL06vS0H0C1cF5hvhDieOdcmh5rL+qBse0560MWnaH+M5uSZnqWHkJ+Menwm/QZfBSv1z0IFrEPM/P/f54dZn/UMPbTpvN7IPreMTwUvXW/ol57H9OiaGSn8raiWRQwwC7wHrhM2zwX2F8EmdBG2e042a0zzn90FacwtSD3pCBMkC4TKPs+Yv5Ul3pm3JvR6hMFUFVANcYKwdaIIIsT0FYK0CAceTH+XjiBGqcOdp7Z6fqNZXdhDSraXtukEJYRxhIAsI6Oya8n16uO6BECMNyNmt6PBSmj5Qr38KIC8PKomIIY3cGOWGTHqEB2St0mqkLD8bSoBEuVvu2rK6W9njf+/MyW+V5EXOnokE+hVBM7GKFfiQO4aqQjRnY3vmKuetnUgi5AERLmf+sh95wmHmtyrQyPRTX96PUNjFLCjmZ+p5Z9EsDIIFyjqxmyyn/WXW/iKIPuhy4MoW+nNNrJv4hmslzENqwG7UZ1WanIO2THJOOp5gv7mHEfGzSKgZKnq+n+tMDFSjgfloHTzgSIiiSp8StmaEAlluMu0xQRwDobqGKx2Y60rGvK4MqRcxTFdctXvt7qf3AizXafDv/MYTCeXXTYynQB++bhiHws6AGssmVesbpsHT1q4udCIqgYSgHAx8KPv1l3jmRfp9y+9B7GnMqlxDfKq6wk6BzwgFgRl8Fb/LVfKsuJO7KHAAGfBSy4CMqK0Ib02tUohUjc8PxMIlObtofXiuzA56xgoOD40MxPW0vbUhyLcTaw2548vkAyF3yFUrK3iP2kYQeSZVvy6bSTv7Coe5zpyHEnNHjkazC71QOaVVRft89VTwuC1c5nv373u4Nkh18CTNJzUN/Tak+T4J46FZ5TpT6urCi7s3xam5IbdfA8W4qQ6N0LV9B7bi TmSyU/4A VhnEu5+0aVaQoUj1SE6+Ech6xcjfT8C+JSVeVI2Fdw94/lTTI+oCZmRv8UpRpPztAKkOE7qXLTBDG0C7Fdg8aZ5DlTxdH8FpZWrRM6Li1E2ztsdlePVPrEPJGcno2VHm1wX8slgUrzxoU/HwoRhgCXDadAgsQySKRVOri6ZTk50pbL/x/1/EZz8RpPYI1P2v+crTo0bm74GeWLRDs8CBA+z1f92RUZ+gE/kxNF8uLdVEQvgip5iZzUAkgUAPNbpxQV5B96/+Z839gRARkOnbhD9A7Edso09waIJJ2z8ECQRlZ0rs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 19 Aug 2024 19:44:25 +0800 Kairui Song wrote: > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -836,7 +836,7 @@ static unsigned long cluster_alloc_swap_entry(struct swap_info_struct *si, int o > goto done; > > /* Order 0 stealing from higher order */ > - for (int o = 1; o < PMD_ORDER; o++) { > + for (int o = 1; o < SWAP_NR_ORDERS; o++) { > /* > * Clusters here have at least one usable slots and can't fail order 0 > * allocation, but reclaim may drop si->lock and race with another user. OK, I got that landed in the right place, but... The definition of `o' within the for statement isn't typical kernel style - I'm surprised we didn't get a warning for this - maybe things have changed when I wasn't looking. Also, this code makes no attempt to honor our "The preferred limit on the length of a single line is 80 columns" objective. There's just no reason for comment blocks to violate this. So Chris, please attend to such things when preparing v6, which I assume is in the works.