From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB170C3DA4A for ; Tue, 20 Aug 2024 04:41:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 188296B007B; Tue, 20 Aug 2024 00:41:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 139006B0082; Tue, 20 Aug 2024 00:41:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0273C6B0083; Tue, 20 Aug 2024 00:41:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DE42F6B007B for ; Tue, 20 Aug 2024 00:41:03 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3D44A1C5328 for ; Tue, 20 Aug 2024 04:41:03 +0000 (UTC) X-FDA: 82471374006.25.6D1A6DE Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf28.hostedemail.com (Postfix) with ESMTP id C72E4C000B for ; Tue, 20 Aug 2024 04:41:00 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=LF3Zb4lb; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724128846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GTpWcZEF5Cf+y5UziA0qPoYkAElKQ1C+2w8p2tjcI0c=; b=U3LSxULzQ+jqgtdNh9Lc87uvVnsyTu9jUBdlA+KHb/xSVs1FOtkScAWgJHuruog1gcGUyO tbuUukX/SKr3k/C3/ljI7uwOLwZ+BGXbLXPSV9f0Ck2/ETh0H6r/WWyZESemqIhljD5pl8 99V57/p1MYS7aejocSZdkDIw8dzx4kc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=LF3Zb4lb; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724128846; a=rsa-sha256; cv=none; b=Tx6REO9VMqOFURsVZI9Jw4g+7HHwUT2OO0Sf5WjzbmDAmSfkDNB6DVI8KY4MT16SW4TqXy d0AGm4pLkIbWHfAOfgGjPfBrILuZZnC6vLcLkrY5ZsfWGhxxfTuz0kJVjOAQ4pyTlLLcpM 6XcEBznvCoJn3gPiEenYxDipJpZknPE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5414ACE0AE0 for ; Tue, 20 Aug 2024 04:40:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 543ADC4AF09; Tue, 20 Aug 2024 04:40:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1724128856; bh=lxLBe2HRcNF7J8oGCvBcLAykY2824pBpNcSJqIMsKAw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LF3Zb4lbY0O8p4DrLSfOhMM1rZkVKt4aHHqhnOwYe6T139vDoAmT/P1JH75hGxHja eRw7xPe9eZPktzkPYD+ZPSRBm6xKolHNlTdUclLsiXxdl07OZ6zEk3q7rDuWvej2Jd nqh08eM2j4y8+zMN+qJ97WsxIjqpINCvHtkYlvnw= Date: Mon, 19 Aug 2024 21:40:55 -0700 From: Andrew Morton To: alexs@kernel.org Cc: linux-kernel@vger.kernel.org (open list), linux-mm@kvack.org Subject: Re: [PATCH v2] mm: skip less than check for MAX_NR_ZONES Message-Id: <20240819214055.978b33eae88004d35b9ce634@linux-foundation.org> In-Reply-To: <20240819112628.372883-1-alexs@kernel.org> References: <20240819112628.372883-1-alexs@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 9a4d666w6gbsnwa1s1bsh58nzjb3bhtm X-Rspamd-Queue-Id: C72E4C000B X-Rspamd-Server: rspam11 X-HE-Tag: 1724128860-332199 X-HE-Meta: U2FsdGVkX1/iqxt0QuHzi1yqWIOJy8lfDemlzXHnFep3bhj2fDb7ENiVFKtaP8hpW6Uf3itZyLiOz4BoYP2EFVx2ItyQMR22j0uWjnUvrFi+QMbKtoVOlGO+F0RJ5jc3fuH/St0g/TEXb70WCKWKBZK1yC5+RhaPMb9pjA0fd/Lb+nzu/LTz+jItMW3s1le5kRWZMZfFRw7OvCCtGmmRi9tcPgkGN1YVVxjKlGLDTqY0T31rntiybGNgke19GdznlNcHPIY8QHzm0xN/3YNN85q0sm40qsFQ2i/d1lGWxu2+EE8waHx6XJCxnDvu1Of9U4D2mROVD4/WUQ42EXPZL9TNNUBInWzvcOD9gDuTwUWi1hgn6L6fQE2HJSo8JhKhr5vnNHhNgPeIGjfWCdBFSFHHFT8fJezW1aZyIZycqkNrs51PSE9ljn9jSFp59pN1Lw5AYrzcF0Y6sI1R+fDGj5/KaR5TghylG3C+BkTYljfvANJ4UZeCDivvZkWLv6N7ssvi+bQgtLvkYXlAhlL7a/B0L2Kh99lqjSx8wZQ5XMVaPyALNQohOG9RfvIAkFqxm9cQAZDbCU3QrNQaEtL5vv3R96omfOR7vnpK5cqhDPm/HdiNyIY+zG8bYZN1prYcIz8c2sq1OqpDXkfOCXUtUwCgyzAT/6sHkPY1Kg37QiXxkSfE2E6IpRZxVey+w7Z4HkzSYiatBQdl0uYE6Ab+vKxmt3cIUUcPpj6/QrBS50hU8UCI5ypPLIVYJxZu0YNhZ0DjwsHqKtoqRMpA4KfSRlzjIJG7Z846yUXdKBKmlykqiR0HYXRv7Be9LXgiG0Xp7RLF8/0ZJ1ObdpfGyBKKUKwAKCIXeh6D58oU7yOa5pZpi76EGGWBXGHZTG0QXtaXY2u93KN+H8fLxM3Pc+b0x+Uvf9e4I1gqlfkJm2pNcMGk61sAwe4tMKcQkUe9AeTIkL6CAufS2w4OKcH/flh SIbYVRa2 QXgQQLm6sz9C7bprnGxc/6HFDMEsKdjH8dVrXPKt2iDxOIvj67xj+ZkW4d4O7yEfFqP+f400VcYP+vU1g61SPe4C58NC0gqpCttzwFEEEFlkJvWz0W3b3azFNjimYUjDhqVaAQ/9vc2zi95XYhxZMjhmcatelCH2Ft/HqEV9A2GoSa2J7Ojv0BUOdHE9r/eeI+hA/PdySLDxVnYLX3qUD8iqDoTDK7lF1yKQqgK4GdxYbfdob/sdmJcflnFZK6PYOv1CCCPsSIvHRtlWzTYu3NRBf5PBE9xEX5fRxYDduXdlJOnvjIO9Z+L7nr2NmLL2ZQ55hkRb/5aFZWeQsld7cm3e4PYSOhBVxA0SIaEQn/5SQSW5vUVZztLRrRxVlnk18V5tEGYZd/6sBjaU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 19 Aug 2024 19:26:28 +0800 alexs@kernel.org wrote: > From: Alex Shi > > Remove unnecessary '<' check for ZONES_SHIFT assignment. > > ... > > --- a/include/linux/page-flags-layout.h > +++ b/include/linux/page-flags-layout.h > @@ -14,7 +14,7 @@ > */ > #if MAX_NR_ZONES < 2 > #define ZONES_SHIFT 0 > -#elif MAX_NR_ZONES <= 2 > +#elif MAX_NR_ZONES == 2 > #define ZONES_SHIFT 1 > #elif MAX_NR_ZONES <= 4 > #define ZONES_SHIFT 2 mmm, why. I think it looks more logical (and certainly more consistent) the way things are now.