From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5DD8C52D7C for ; Tue, 20 Aug 2024 01:05:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E6356B0082; Mon, 19 Aug 2024 21:05:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 296416B0083; Mon, 19 Aug 2024 21:05:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15DF56B0085; Mon, 19 Aug 2024 21:05:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EC8A36B0083 for ; Mon, 19 Aug 2024 21:05:55 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7AD401A15F8 for ; Tue, 20 Aug 2024 01:05:55 +0000 (UTC) X-FDA: 82470831870.04.4E15157 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf29.hostedemail.com (Postfix) with ESMTP id 6E7B2120004 for ; Tue, 20 Aug 2024 01:05:53 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Ohr8uPnM; dmarc=none; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724115938; a=rsa-sha256; cv=none; b=vahBlRVfzsjNVa2/VNL3sGfgD6L27UAMPq+WCbTWfo2fYMWeholI0FIND1wD2Elf2lKhyb rPYrP0kEJht2R+MYCBXUiraODtR/O1ojR4JeilxSV7aJN9/Lsp1wB/uxfIFSjvPlcmGLFu AwjKXyYA3F0WmTJfdwbxREfi0cjh99s= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Ohr8uPnM; dmarc=none; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724115938; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EuN7+YBAKmzog529LVv9sSISlD4oXFwMrmsyOUXPKMY=; b=1VrOYoZWhrHW6IQNkw6IWHZTu+WIK/kTfLPmHiitikm9aykEB6zU1kffBGY3Cjl1oG6/bt tUvxGGib+Bgd4J9aa1XOiL0v5S18Yl+zEZRHKcq4v50pDqXC7vSjZMwC/nn7ZB72bJ53Fd cO6qSkx9JABxjSizrdVpP38jZeH2yIo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 772B6CE09EA; Tue, 20 Aug 2024 01:05:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA95FC32782; Tue, 20 Aug 2024 01:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1724115949; bh=0U7jOid/uP8Y+iIqM7ITqWrx8b2Snwx2qFv6PcPMlns=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ohr8uPnMeT9PqbC27FNE2NUgwBSpD2Am8ljUhb2MkNtpvuqCxRgINXdfU+7Z5Ok4Q oLhpzo7qQb2Jy/L9reXhcowB+4RKVOZlFzvsJaEDLoJ4G/pXRebjYmXlqoj8xddMJJ umSfjfzu/bhamoXfiWzuJ1aWiSlwUJ4EuI/WZtuw= Date: Mon, 19 Aug 2024 18:05:48 -0700 From: Andrew Morton To: Linus Torvalds Cc: Nathan Chancellor , Guo Ren , Brian Cain , Dinh Nguyen , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Richard Weinberger , Anton Ivanov , Johannes Berg , Michael Ellerman , linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, christophe.leroy@csgroup.eu, jeffxu@google.com, Liam.Howlett@oracle.com, linux-kernel@vger.kernel.org, npiggin@gmail.com, oliver.sang@intel.com, pedro.falcato@gmail.com, linux-um@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon , Linux-sh list Subject: Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping Message-Id: <20240819180548.9f5dac3ac0bd09a26c0d0948@linux-foundation.org> In-Reply-To: References: <20240812082605.743814-1-mpe@ellerman.id.au> <20240819185253.GA2333884@thelio-3990X> <20240819195120.GA1113263@thelio-3990X> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 6E7B2120004 X-Rspamd-Server: rspam01 X-Stat-Signature: ike7fat4cf4zmzz4yx7fh6y7bz54wqub X-HE-Tag: 1724115953-431908 X-HE-Meta: U2FsdGVkX18kIWAoPwmNGpC/braV00g3KEEUwQAWPIAGXh7cq+RsvSPbDiCN3w98EmKoaxEP6RcKBQWL0NY0xrZSbGi+onBhRzTK0RxD6kynpUIJQ74jJL8ABrLM+2l7WCxz0AL8Fsdm/bRmenbVNUJJe+g3DIbfseKb7vo7kgjL2SSbYFgROQsVfZ4NNvdaGpTwLkb9UOYK4FQ1sILUhkhNR5vCI6DKzy3aUl/t2ZLINSWyaCxmxB8NjhKI7I5Mv4UCJUc0JjQrxOJIAcbcV83XcY6TqMjQG9nFCssWeOtS6vAL5kiZz4us3Gc9quk9hL/eaCrK1qECwJ2GaPthjFmogfRndfenu36KT1AMJuT70XWo1VkMTXXGKx8WYCYe7odqbIR9YnlAUEcoB+fKANuAH0rIzzhbpCTF7nsDhp6s9dLPBP/ofkHKB+asXbEiugshWXmVIeT54bhNt0v1gA3woIKZU9ifJ8e7HqnW/O3wC6qH3pM1cjeyHolCijU7XTX2/osnvrnHjU3Fexh9tiOhyvNFxFbwQnCUEfLXg2oYMHmeOpXLITHeLBxKYoBvpVGDYl2GnSQ6ZJtseW65JA/Jvo1F9p1rKZP98ZIn3FdW+DCwiTGzLg1MMu05XeraL27cTv9d8VuzpW9l1nrnaR37Gv3PJtLaAo9OkrWIxsJiiSvdt2mhzNbsuVhOEyl5d0CvuRsvoiq9V69vmZ58P/0c9sO3sBv7aPX+5rbIvnJ+XcBsYwf2yaO7cx5SkQcpk9F1fMfxYr5+VeLb5ROm56oEE4hXrNLOfMfUGowuzcCTpeZgJEDrv27Kqu+dq8N+/Ge4M9STHxUPLG6pDXTNFPp7JL4uyUaqNiRqpAtt/NS4t5+9GGZKS05RJSFZrgOTSschiGRKzZmaKFqNQfKS43moRPb5BXfMIUyJNejQVEYFCS2WURqp6zGxIMGpNoDXG29IlxQSwxJYqmAalEk t3osfMm5 9OYQ4QOzYjK0qs3RZqTngTS5EgoxtcIdgCCbuF8uwD+yqndZ95iRIQZZiIeBBgvnV1XGPqRwBP0oAL8igeSoa2QLELu9Lej1M6Sm3lAhyD2TYIOYbGc6GEu5jAYA49OYp1TH0Ur0oBsRvivHDnhjyGNwukCZmoEo/sZCZqtr+PupUQdLyftZXozPiNukw1Hflxpe9FNdonh3yzhv2znvEgruhbQjv4gccBabchflmo5+p8hGi2Y4qFAOg/dfkDeI7Fc7M2rvgtFquIMfv8P1PISwe+R5LqeomB0Zn+PZA0gx80xHloMpXK+8y3U0bsC9Qr2oAxfu/B9VtfjKIvoBL5esG2LS9p3mqGbSxk9hpIbldt6gff7VcDbqJAbuUKyMJ5mhZIRLXCpAUfUwt66BsQWOOKA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 19 Aug 2024 13:16:32 -0700 Linus Torvalds wrote: > On Mon, 19 Aug 2024 at 13:15, Linus Torvalds > wrote: > > > > Ok, I did a quick hack-job to remove that disgusting > > install_special_mapping() legacy case. > > > > With this [..] > > I forgot to actually attach that "this". Here it is. For real, this time. Thanks. Do you think your one-liner remains desirable with this fix in place?