From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7464EC3DA4A for ; Tue, 20 Aug 2024 01:01:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C3996B007B; Mon, 19 Aug 2024 21:01:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7743F6B0082; Mon, 19 Aug 2024 21:01:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63CCB6B0083; Mon, 19 Aug 2024 21:01:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 44CF26B007B for ; Mon, 19 Aug 2024 21:01:41 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F27DCC16CB for ; Tue, 20 Aug 2024 01:01:40 +0000 (UTC) X-FDA: 82470821160.11.FFA1A8A Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf01.hostedemail.com (Postfix) with ESMTP id CE1AA40011 for ; Tue, 20 Aug 2024 01:01:37 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=DAh8Q1mq; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724115620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9RCP0vqOpo81/aXw+qhA+TBn/wR2EuExitCpaGv568U=; b=gBx5FjAhZ7SDAUlkxSYZLgjIYJRsV8Y2mlle88sPym+6Q3MYsmLmDDKADUWv4pjG/vo9ZT kI2fKSIoLpkwaX8WxY9gImGh2KxX628R4CzbLeo8yZChRwROaLNA5kig211bpa7W//xs5k 0eQrTF7KsMwr4M7l+5a9tn71dAzldzE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724115620; a=rsa-sha256; cv=none; b=WJG64nCsDea9o9xTB0+7DmHUS4dKdFuz/5j4WNNmZb0favYwtisEFHfznUwU1xT00Vh/n9 xNMyilugds8QFaEplTc5ySL9tkAFcL/jsu1o+jxv6mm1YrFrEe+pNy4eJQspdSr87E69HC ZQB+Mk1tQBd7/9o5dEkZHGovyEjqcc0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=DAh8Q1mq; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6E2B6CE0B52; Tue, 20 Aug 2024 01:01:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51B09C32782; Tue, 20 Aug 2024 01:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1724115692; bh=vCG/7EpNWV9MCkM7KPhgmJCNxcxQVYJ412oNcR79CpQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DAh8Q1mqXkhQInNT/qhhFFmsnlZecwU+De2iRX4YCms7YUv2I8VBB+MSNpiA9iykY xyYncceolzB0iOOXCfPB/XtGUgqydXUG2ucXhNX3nLslQgwy7OHH0BNFNE0TnqdEey s0PzuTPf4EyYItzzEY31Xa6XdjWR7HcWWdhxhSBI= Date: Mon, 19 Aug 2024 18:01:31 -0700 From: Andrew Morton To: Yosry Ahmed Cc: Nhat Pham , Mike Yuan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Muchun Song , Shakeel Butt , Roman Gushchin , Michal Hocko , Johannes Weiner Subject: Re: [PATCH] mm/memcontrol: respect zswap.writeback setting from parent cg too Message-Id: <20240819180131.27b0ea66dd50b83c85102540@linux-foundation.org> In-Reply-To: References: <20240814171800.23558-1-me@yhndnzj.com> <20240815150819.9873910fa73a3f9f5e37ef4d@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CE1AA40011 X-Stat-Signature: hgo98h3q3d67a6tc5nhqm57fs1mdwsc6 X-HE-Tag: 1724115697-718888 X-HE-Meta: U2FsdGVkX19AdzQKINYdBED7cB2/D8yhQKLGvEI8M8twXil4HA+wOo8uv3xntFAS8U9KicJP3fIB27nglrjtD2p+9M0dgekJvLyrFsXW127EW76VGGnXOrFv5DEnft0AUCKEUBTHjmteWUFuTga9rydqf7MuuFHSIRTRJ8+MOk+Bme05mAGiHRLUWA+THUfCFwYmQyKUd6d6YglWvcuSIrrg/DICC5Tt3gnwJsA7pf83oqIZSQmUIe9YfQ0Gx9I+UqOBPSQbk7vsq5lC5LlahOQrC8BmD1DLs3eMlS3bM521mxeOM9qKyqt9CEgF2BUBgpE5eMNJTXCM34HoOL3RJfAEHWzVWnzL/A4+vJ7ts7nVWmBdDP1BD50HzhBIFpvjgJrtZNzCfXGFvHFm4R81qX/kIm5KXKQGXdVepauDuvi/IkBL6N//+exX/YlO4KswNmeeuzcTpFBxCJMRoumbsl9Nieu6pFptbVg04dspwEY2Rp46JU8aY7+GqHO55FZSuTF/T7w6vzAporq8rYyEr+lNKIH0yd83BQDguFJ2upFqkP3VrkN9QE3Id+UgbKA9r446A3OQz9hPLNe9qzjJsrs50TKrfC++oD6t7t7/n01lZC5njUFniZVxEjisUaJLoWxor2Rty0G1V1KVU+yJYQNNM06klkYqSCKwnnRxClnOuvuOfX5tzogP1o8I8wWaAQb03ZZ/QYHBs+in2sAnjK6dBEJz0a/Fg9DE/nMt4qeSCgnwjguDil2utlKT10qDgDmvDGLH+XR36314kMSC6iCfpyljKYdjFj4M1fybIKJ3ClDEPQYPHedCyLcM19BAIX249ocMQiiiWQ9HFgTPQi2ikRbmPV4iVe8jBTbArxHFioWCsGs6FINpa2/3uMyFxWy4XI+2VkT82Gaukp32bpHGMnnNYsWGMIrtxhryG6k2U3nSvo5QWXGE2TbtecqB+eghMh1xiqgL5NDXkI5 jiZzRJih hVUwNyuN3PyyLLIoMfEz2AnabjsOIlW6RzKmytIDWGDvx/n4DDDbZvskB40vpN5ckVE5OZBPmuYoBks/JEL9+5v4FVgXYdIFTJrqX8L65ztJAiKhORYEqmk21UwjS1xrkqB4qT0BeD3VSLBmK78EVUvsvLsRihzbae4l7wNr+Rreai+KVFJ3tZVcAJS83HKuv8zzuq9J9+4CdtorGLlt3B12RTQLX9TXDL9owkonX+2bSkBkUP8QeU+goJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 19 Aug 2024 12:05:44 -0700 Yosry Ahmed wrote: > > Ah yeah, I was thinking this could be done in a follow-up patch. > > > > But yes, please - documentation. Preferably everything together as v2. > > > > > > > > Also, do we want a Fixes tag and to backport this so that current > > > users get the new behavior ASAP? > > > > Hmm, I wonder if it's more confusing for users to change the behavior > > in older kernels. > > > > (OTOH, if this already is what people expect, then yeah it's a good > > idea to backport). > > My rationale is that if people will inevitably get the behavior change > when they upgrade their kernel, I'd rather they get it sooner rather > than later, before more users start depending on the old behavior. > > I am guessing there is a chance this is not what backports are meant > for. Andrew, any thoughts on this? I agree. It does depend on how long the old behavior has been out in the field, and on our assessment of how many people are likely to inconvenienced. So... yes please, what is that Fixes:?