From: Andrew Morton <akpm@linux-foundation.org>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Nhat Pham <nphamcs@gmail.com>, Mike Yuan <me@yhndnzj.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org, Muchun Song <muchun.song@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Roman Gushchin <roman.gushchin@linux.dev>,
Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] mm/memcontrol: respect zswap.writeback setting from parent cg too
Date: Mon, 19 Aug 2024 18:01:31 -0700 [thread overview]
Message-ID: <20240819180131.27b0ea66dd50b83c85102540@linux-foundation.org> (raw)
In-Reply-To: <CAJD7tkaY3FsL-9YeDuVG=QtCK-dgm71EJ2L_T3KfGUa9VW_JkA@mail.gmail.com>
On Mon, 19 Aug 2024 12:05:44 -0700 Yosry Ahmed <yosryahmed@google.com> wrote:
> > Ah yeah, I was thinking this could be done in a follow-up patch.
> >
> > But yes, please - documentation. Preferably everything together as v2.
> >
> > >
> > > Also, do we want a Fixes tag and to backport this so that current
> > > users get the new behavior ASAP?
> >
> > Hmm, I wonder if it's more confusing for users to change the behavior
> > in older kernels.
> >
> > (OTOH, if this already is what people expect, then yeah it's a good
> > idea to backport).
>
> My rationale is that if people will inevitably get the behavior change
> when they upgrade their kernel, I'd rather they get it sooner rather
> than later, before more users start depending on the old behavior.
>
> I am guessing there is a chance this is not what backports are meant
> for. Andrew, any thoughts on this?
I agree. It does depend on how long the old behavior has been out in
the field, and on our assessment of how many people are likely to
inconvenienced. So... yes please, what is that Fixes:?
next prev parent reply other threads:[~2024-08-20 1:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 17:20 Mike Yuan
2024-08-14 19:52 ` Nhat Pham
2024-08-14 19:53 ` Nhat Pham
2024-08-15 18:39 ` Mike Yuan
2024-08-15 19:10 ` Nhat Pham
2024-08-16 13:25 ` Mike Yuan
2024-08-14 20:22 ` Yosry Ahmed
2024-08-14 20:43 ` Mike Yuan
2024-08-15 19:12 ` Nhat Pham
2024-08-15 22:08 ` Andrew Morton
2024-08-15 22:10 ` Yosry Ahmed
2024-08-15 23:31 ` Nhat Pham
2024-08-19 19:05 ` Yosry Ahmed
2024-08-20 1:01 ` Andrew Morton [this message]
2024-08-20 1:06 ` Yosry Ahmed
2024-08-20 15:28 ` Nhat Pham
2024-08-21 16:14 ` Michal Koutný
2024-08-22 17:49 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240819180131.27b0ea66dd50b83c85102540@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=me@yhndnzj.com \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox