From: Yongqiang Liu <liuyongqiang13@huawei.com>
To: <linux-mm@kvack.org>
Cc: <linux-kernel@vger.kernel.org>, <zhangxiaoxu5@huawei.com>,
<cl@linux.com>, <wangkefeng.wang@huawei.com>,
<penberg@kernel.org>, <rientjes@google.com>,
<iamjoonsoo.kim@lge.com>, <akpm@linux-foundation.org>,
<vbabka@suse.cz>, <roman.gushchin@linux.dev>,
<42.hyeyoo@gmail.com>
Subject: [PATCH] mm, slub: prefetch freelist in ___slab_alloc()
Date: Mon, 19 Aug 2024 15:02:04 +0800 [thread overview]
Message-ID: <20240819070204.753179-1-liuyongqiang13@huawei.com> (raw)
commit 0ad9500e16fe ("slub: prefetch next freelist pointer in
slab_alloc()") introduced prefetch_freepointer() for fastpath
allocation. Use it at the freelist firt load could have a bit
improvement in some workloads. Here is hackbench results at
arm64 machine(about 3.8%):
Before:
average time cost of 'hackbench -g 100 -l 1000': 17.068
Afther:
average time cost of 'hackbench -g 100 -l 1000': 16.416
There is also having about 5% improvement at x86_64 machine
for hackbench.
Signed-off-by: Yongqiang Liu <liuyongqiang13@huawei.com>
---
mm/slub.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/slub.c b/mm/slub.c
index c9d8a2497fd6..f9daaff10c6a 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -3630,6 +3630,7 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node,
VM_BUG_ON(!c->slab->frozen);
c->freelist = get_freepointer(s, freelist);
c->tid = next_tid(c->tid);
+ prefetch_freepointer(s, c->freelist);
local_unlock_irqrestore(&s->cpu_slab->lock, flags);
return freelist;
--
2.25.1
next reply other threads:[~2024-08-19 7:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 7:02 Yongqiang Liu [this message]
2024-08-19 9:33 ` Hyeonggon Yoo
2024-08-21 6:58 ` Yongqiang Liu
2024-09-14 13:45 ` Hyeonggon Yoo
2024-10-02 11:57 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240819070204.753179-1-liuyongqiang13@huawei.com \
--to=liuyongqiang13@huawei.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=wangkefeng.wang@huawei.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox