From: Kanchana P Sridhar <kanchana.p.sridhar@intel.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com,
ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com,
akpm@linux-foundation.org
Cc: nanhai.zou@intel.com, wajdi.k.feghali@intel.com,
vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com
Subject: [PATCH v4 4/4] mm: swap: Count successful mTHP ZSWAP stores in sysfs mTHP stats.
Date: Sun, 18 Aug 2024 19:16:21 -0700 [thread overview]
Message-ID: <20240819021621.29125-5-kanchana.p.sridhar@intel.com> (raw)
In-Reply-To: <20240819021621.29125-1-kanchana.p.sridhar@intel.com>
If zswap_store() successfully swaps out an mTHP, it will be counted under
the per-order sysfs "zswpout" stats:
/sys/kernel/mm/transparent_hugepage/hugepages-*kB/stats/zswpout
Other block dev/fs mTHP swap-out events will be counted under
the existing sysfs "swpout" stats:
/sys/kernel/mm/transparent_hugepage/hugepages-*kB/stats/swpout
Based on changes made in commit 61e751c01466ffef5dc72cb64349454a691c6bfe
("mm: cleanup count_mthp_stat() definition"), this patch also moves
the call to count_mthp_stat() in count_swpout_vm_event() to be outside
the "ifdef CONFIG_TRANSPARENT_HUGEPAGE".
Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@intel.com>
---
mm/page_io.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/page_io.c b/mm/page_io.c
index a00e2f615118..ac5954149eb9 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -196,6 +196,7 @@ int swap_writepage(struct page *page, struct writeback_control *wbc)
return ret;
}
if (zswap_store(folio)) {
+ count_mthp_stat(folio_order(folio), MTHP_STAT_ZSWPOUT);
folio_unlock(folio);
return 0;
}
@@ -215,8 +216,8 @@ static inline void count_swpout_vm_event(struct folio *folio)
count_memcg_folio_events(folio, THP_SWPOUT, 1);
count_vm_event(THP_SWPOUT);
}
- count_mthp_stat(folio_order(folio), MTHP_STAT_SWPOUT);
#endif
+ count_mthp_stat(folio_order(folio), MTHP_STAT_SWPOUT);
count_vm_events(PSWPOUT, folio_nr_pages(folio));
}
--
2.27.0
next prev parent reply other threads:[~2024-08-19 2:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 2:16 [PATCH v4 0/4] mm: ZSWAP swap-out of mTHP folios Kanchana P Sridhar
2024-08-19 2:16 ` [PATCH v4 1/4] mm: zswap: zswap_is_folio_same_filled() takes an index in the folio Kanchana P Sridhar
2024-08-19 2:16 ` [PATCH v4 2/4] mm: zswap: zswap_store() extended to handle mTHP folios Kanchana P Sridhar
2024-08-20 20:03 ` Sridhar, Kanchana P
2024-08-19 2:16 ` [PATCH v4 3/4] mm: Add MTHP_STAT_ZSWPOUT to sysfs per-order mthp stats Kanchana P Sridhar
2024-08-19 2:16 ` Kanchana P Sridhar [this message]
2024-08-19 3:16 ` [PATCH v4 0/4] mm: ZSWAP swap-out of mTHP folios Huang, Ying
2024-08-19 5:12 ` Sridhar, Kanchana P
2024-08-19 5:51 ` Huang, Ying
2024-08-20 3:00 ` Sridhar, Kanchana P
2024-08-20 21:13 ` Nhat Pham
2024-08-20 22:09 ` Sridhar, Kanchana P
2024-08-21 14:42 ` Nhat Pham
2024-08-21 19:07 ` Sridhar, Kanchana P
2024-08-24 6:21 ` Sridhar, Kanchana P
2024-08-26 14:12 ` Nhat Pham
2024-08-27 6:08 ` Sridhar, Kanchana P
2024-08-27 15:23 ` Nhat Pham
2024-08-27 15:30 ` Nhat Pham
2024-08-27 18:43 ` Sridhar, Kanchana P
2024-08-28 7:27 ` Sridhar, Kanchana P
2024-08-27 18:42 ` Sridhar, Kanchana P
2024-08-28 7:24 ` Sridhar, Kanchana P
2024-08-28 7:43 ` Yosry Ahmed
2024-08-28 18:50 ` Sridhar, Kanchana P
2024-08-28 22:34 ` Yosry Ahmed
2024-08-29 0:14 ` Sridhar, Kanchana P
2024-08-24 3:09 ` Yosry Ahmed
2024-08-24 6:24 ` Sridhar, Kanchana P
2024-08-27 14:55 ` Nhat Pham
2024-08-27 18:09 ` Sridhar, Kanchana P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240819021621.29125-5-kanchana.p.sridhar@intel.com \
--to=kanchana.p.sridhar@intel.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nanhai.zou@intel.com \
--cc=nphamcs@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=vinodh.gopal@intel.com \
--cc=wajdi.k.feghali@intel.com \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox