From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E0F2C5320E for ; Sun, 18 Aug 2024 16:51:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50CBF8D00E2; Sun, 18 Aug 2024 12:51:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 495DB8D00B8; Sun, 18 Aug 2024 12:51:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 336CC8D00E2; Sun, 18 Aug 2024 12:51:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 141A38D00B8 for ; Sun, 18 Aug 2024 12:51:39 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B9339120CF2 for ; Sun, 18 Aug 2024 16:51:38 +0000 (UTC) X-FDA: 82465957476.21.3AA8900 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf02.hostedemail.com (Postfix) with ESMTP id 906EA8001B for ; Sun, 18 Aug 2024 16:51:36 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=Ud62Q1Hf; spf=pass (imf02.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723999795; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iJtQXoqkg1Ql6i6lKlrT5656z34Z7stPQ3wfnhFxFrY=; b=kj2r4FtPUDtDILT48JiAy0PDVHGUMgu0TpZMt30Exvsik8uXU7dD6pKQw6rc7IVciliTWQ DFUuDhdO/Ht+2+o4j8UYW6/I39lls1PJKTJXgIMfGZAVZuEld1wVDP+f6D04AcuHpBYAXV hkt5Tz7vbStsTzIo333U11DupntqcDI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=Ud62Q1Hf; spf=pass (imf02.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723999795; a=rsa-sha256; cv=none; b=uuWUfFAT5g+llbpFBdByMg1Op5G76F75D5zA7Bg66RR8/AX3L7I0sh/1KPlYbx8yAy7WZR CaTMICmh9ehf0G03hWOsYveSotH6z8+zPs+kv6wJUYg/7frjOkWAS0cGksVZbXXs50Vupw q8wC3d9X6LibnWUPhjOX5gZb0DCDMcg= Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4Wn1w34sYfz9t0Z; Sun, 18 Aug 2024 18:51:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1723999891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iJtQXoqkg1Ql6i6lKlrT5656z34Z7stPQ3wfnhFxFrY=; b=Ud62Q1Hfxg0cQlxfaNFcOxaYdhJdHuFYjTbZThaJO7BH6N34wLvYzV1t2F9cgp7qTGc5b9 1tYxvKOWEUfVZhi0sEt0KhPoLlHNEKCDzrbi9Lh5Wu6oNjjFkZgxL+I+OnqGs3Z8TUtG/4 9CLOKRqENEqOk0JHVgt3fHU0MKmIzHBBznCYQanLnJYHdsY/rvlJPK7zGwFHmTYaQXuFma JoH3+6+mjRnaWR8Wqxvle1g4Zk1CMc63QtHctV/ZT9UMkfTmzAZshJxpYSV+Ue94TglLNH MqDVU0fVn3ILLYw2LrnWJi2i08G+AxL+/BnZfGz7jud1NlY/VKvBdYWhctTsWg== Date: Sun, 18 Aug 2024 16:51:24 +0000 From: "Pankaj Raghav (Samsung)" To: David Howells Cc: brauner@kernel.org, akpm@linux-foundation.org, chandan.babu@oracle.com, linux-fsdevel@vger.kernel.org, djwong@kernel.org, hare@suse.de, gost.dev@samsung.com, linux-xfs@vger.kernel.org, hch@lst.de, david@fromorbit.com, Zi Yan , yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, john.g.garry@oracle.com, cl@os.amperecomputing.com, p.raghav@samsung.com, mcgrof@kernel.org, ryan.roberts@arm.com Subject: Re: [PATCH v12 00/10] enable bs > ps in XFS Message-ID: <20240818165124.7jrop5sgtv5pjd3g@quentin> References: <20240815090849.972355-1-kernel@pankajraghav.com> <2924797.1723836663@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2924797.1723836663@warthog.procyon.org.uk> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 906EA8001B X-Stat-Signature: f4oidxp3kof4e1tb8wb6xaczm5u19rxf X-Rspam-User: X-HE-Tag: 1723999896-437758 X-HE-Meta: U2FsdGVkX1+/hiicK0/hZrAhji+dCWrmhMGOJveUIheYXmE8IaGmpMWZIs+kPsR49DKTSf/XqMFz9Wgvqq7nILTk3HypmnAA3goIY+4NmtBrknXuBZ9fNNNGJSkDr/bvBqoe01SDztSHegwzt6g4is0brvGWRYbhZgyDOjOUt4PFX1wQJfbOGL5wlqo9jFOUVMAilkAnPGt2qAyAeTBAxYjDP9oLqw4mgoWJIRG8Gk9GyeTccKVuMMAqIel/KZmGeu54RAkKbEQW7Hkmu2wZB5ml75tdDx/N/Ae3fP4TJNumVkO8sZ6gcwEus907DsvUi3Izi93qfV89V7YBsTKHaZi1KQ2vQbR7w0gzRNtn13PJO9wfH0nvVubne+ss8lbFmBXXN9hvSdWPOnI439eO9Q/+Srm6QHBHom5tGbZ/5Zb0hOWJbOdczHPn7/Xhp12ZaCtYmQLDWF59q8o7v7LvSAJ8a9TMgrWanJfV6ujB5UgNukBlWlavOtB/WKbQJG61kEA+9OEcnOSITRGa6v61YriG2iEjMEk9zq4Uj0Fsbp6ufI/llqbdz/i4UXXfFysPmPCGPUPg2KTlpNk+NgbqDOtefKbCBSgH7cbfxCD9L8EQZlBFGMz8tklaa86KR82mqk2lRG56HskPqiJVIvHx57LUseAz4rkh013OvX0q23cAMG9OmlnbuB7HHVajeOKbB3UMlqV2Wb9jYZisgFVElY7RoNlBmHUxNEW8lo2Wakf5ClB1mnSoAsToKq8z7UqKZhUtnl2z9DhtYkE4qn0YHTW5UWUYxA8KzO5fuKzAeq28yGn8eLDq2EX41VrxXKnJHPz6oM87xEawkP6p99VrO6YQ/beRZT86zKkCp7WRdKY/1o9JAbDG746Xoye2AAIZVP+tVV4q5JOqvqJSj096fB7b7L481P8ief+WHrrYcV18ak+cygewINC5XBnhgIQaQ+9xpnzD2G5eVSDeMOd /pnmvHUs sBsKkUKHI8B+QCmKw7h7gI6jdyodUayKJtSiOscSG7sR97f0oJN8Hwh7TaJDz2XgCneYu4op7VXUzSObdTPu7+I9nneTkxIh/UIGT/Pq9763V5Yb36aluN6F86yDT1jBp8D4txA3N5OmEgBN1i1H3lwCObJOeg6cv41dwWxuOCSdbfbOsyCoCHZAeNdc3iDVIRQ5egy0bDak/IOYGS8n5q3DslGfQdOdJh9JV88hIG6mpdAUFZ/ub/85PNc4rLuyWqKY1chuCkcf17RodybXCgToncjaRgbIHbuTNBTdBDUWqs7FMcDvnixTllX32Y11FlovBTsJY/2pfDjY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, On Fri, Aug 16, 2024 at 08:31:03PM +0100, David Howells wrote: > Hi Pankaj, > > I applied the first five patches and set minimum folio size for afs files to > 8K (see attached patch) and ran some tests. > > With simple tests, I can see in the trace log that it is definitely creating > 8K folios where it would previously create 4K folios. > > However, with 'xfstests -g quick', generic/075 generic/112 generic/393 fail > where they didn't previously. I won't be able to look into this more till > Monday. Thanks for trying it out! As you might have seen the whole patchset, typically filesystems will require some changes to support min order correctly. That is why this patchset only enables XFS to use min order to support bs > ps. In the case of XFS (block-based FS), we set the min order to the FS block size as that is the smallest unit of operation in the data path, and we know for sure there are no implicit PAGE_SIZE assumption. I am no expert in network filesystems but are you sure there are no PAGE_SIZE assumption when manipulating folios from the page cache in AFS? Similar to AFS, XFS also supported large_folios but we found some bugs when we set min order to be the block size of the FS. > > If you want to try using afs for yourself, install the kafs-client package > (available on Fedora and Debian), do 'systemctl start afs.mount' and then you > can, say, do: > > ls /afs/openafs.org/www/docs.openafs.org/ > > and browse the publicly accessible files under there. Great. But is this enough to run FStests? I assume I also need some afs server to run the fstests? Are the tests just failing or are you getting some kernel panic? > > David > --- > commit d676df787baee3b710b9f0d284b21518473feb3c > Author: David Howells > Date: Fri Aug 16 19:54:25 2024 +0100 > > afs: [DEBUGGING] Set min folio order > > diff --git a/fs/afs/inode.c b/fs/afs/inode.c > index 3acf5e050072..c3842cba92e7 100644 > --- a/fs/afs/inode.c > +++ b/fs/afs/inode.c > @@ -104,6 +104,7 @@ static int afs_inode_init_from_status(struct afs_operation *op, > inode->i_fop = &afs_file_operations; > inode->i_mapping->a_ops = &afs_file_aops; > mapping_set_large_folios(inode->i_mapping); > + mapping_set_folio_min_order(inode->i_mapping, 1); > break; > case AFS_FTYPE_DIR: > inode->i_mode = S_IFDIR | (status->mode & S_IALLUGO); >