From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Hildenbrand <david@redhat.com>,
Sidhartha Kumar <sidhartha.kumar@oracle.com>,
<linux-mm@kvack.org>, Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH 2/5] pagemap: use a folio in __readahead_batch()
Date: Sat, 17 Aug 2024 17:51:19 +0800 [thread overview]
Message-ID: <20240817095122.2460977-3-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20240817095122.2460977-1-wangkefeng.wang@huawei.com>
Convert to use a folio in __readahead_batch(), remove the
check of PageTail and thp_nr_pages().
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
include/linux/pagemap.h | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index 68f59cd7637d..a83913555497 100644
--- a/include/linux/pagemap.h
+++ b/include/linux/pagemap.h
@@ -1363,7 +1363,7 @@ static inline unsigned int __readahead_batch(struct readahead_control *rac,
{
unsigned int i = 0;
XA_STATE(xas, &rac->mapping->i_pages, 0);
- struct page *page;
+ struct folio *folio;
BUG_ON(rac->_batch_count > rac->_nr_pages);
rac->_nr_pages -= rac->_batch_count;
@@ -1372,13 +1372,12 @@ static inline unsigned int __readahead_batch(struct readahead_control *rac,
xas_set(&xas, rac->_index);
rcu_read_lock();
- xas_for_each(&xas, page, rac->_index + rac->_nr_pages - 1) {
- if (xas_retry(&xas, page))
+ xas_for_each(&xas, folio, rac->_index + rac->_nr_pages - 1) {
+ if (xas_retry(&xas, folio))
continue;
- VM_BUG_ON_PAGE(!PageLocked(page), page);
- VM_BUG_ON_PAGE(PageTail(page), page);
- array[i++] = page;
- rac->_batch_count += thp_nr_pages(page);
+ VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio);
+ array[i++] = &folio->page;
+ rac->_batch_count += folio_nr_pages(folio);
if (i == array_sz)
break;
}
--
2.27.0
next prev parent reply other threads:[~2024-08-17 9:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-17 9:51 [PATCH 0/5] mm: finish three more folio conversion Kefeng Wang
2024-08-17 9:51 ` [PATCH 1/5] mm: remove find_subpage() Kefeng Wang
2024-08-19 11:02 ` Kefeng Wang
2024-08-19 13:27 ` David Hildenbrand
2024-08-20 8:22 ` Kefeng Wang
2024-08-20 8:23 ` David Hildenbrand
2024-08-20 8:34 ` Kefeng Wang
2024-08-17 9:51 ` Kefeng Wang [this message]
2024-08-17 9:51 ` [PATCH 3/5] mm: remove thp_nr_pages() Kefeng Wang
2024-08-17 9:51 ` [PATCH 4/5] mm: khugepaged: pass a folio for set_huge_pmd() Kefeng Wang
2024-08-17 9:51 ` [PATCH 5/5] mm: remove PageTransHuge() Kefeng Wang
2024-08-18 20:33 ` [PATCH 0/5] mm: finish three more folio conversion Matthew Wilcox
2024-08-19 9:59 ` David Hildenbrand
2024-08-19 11:13 ` Kefeng Wang
2024-08-19 13:20 ` Matthew Wilcox
2024-08-20 8:41 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240817095122.2460977-3-wangkefeng.wang@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=sidhartha.kumar@oracle.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox