linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v5.1 16/19] mm/mmap: Use vms accounted pages in mmap_region()
@ 2024-08-16 16:09 Bert Karwatzki
  0 siblings, 0 replies; only message in thread
From: Bert Karwatzki @ 2024-08-16 16:09 UTC (permalink / raw)
  To: Liam R . Howlett
  Cc: Bert Karwatzki, Suren Baghdasaryan, Vlastimil Babka,
	Lorenzo Stoakes, Matthew Wilcox, sidhartha.kumar,
	Paul E . McKenney, Jiri Olsa, linux-kernel, linux-mm,
	Andrew Morton, Kees Cook, Jeff Xu, Liam R . Howlett,
	linux-security-module, Lorenzo Stoakes

Change from nr_pages variable to vms.nr_accounted for the charged pages
calculation.  This is necessary for a future patch.

This also avoids checking security_vm_enough_memory_mm() if the amount
of memory won't change.

Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Cc: Kees Cook <kees@kernel.org>
Cc: linux-security-module@vger.kernel.org
Reviewed-by: Kees Cook <kees@kernel.org>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Reviewed-by: Suren Baghdasaryan <surenb@google.com>
---
 mm/mmap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index 57fb1c82a852..d0942b1a62f0 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -1416,9 +1416,10 @@ unsigned long mmap_region(struct file *file, unsigned long addr,
 	 */
 	if (accountable_mapping(file, vm_flags)) {
 		charged = pglen;
-		charged -= nr_accounted;
-		if (security_vm_enough_memory_mm(mm, charged))
+		charged -= vms.nr_accounted;
+		if (charged && security_vm_enough_memory_mm(mm, charged))
 			goto abort_munmap;
+
 		vms.nr_accounted = 0;
 		vm_flags |= VM_ACCOUNT;
 	}
--
2.45.2



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-08-16 16:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-16 16:09 [PATCH v5.1 16/19] mm/mmap: Use vms accounted pages in mmap_region() Bert Karwatzki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox