From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70F64C531DC for ; Fri, 16 Aug 2024 09:12:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06DC86B02F2; Fri, 16 Aug 2024 05:12:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01DF78D0002; Fri, 16 Aug 2024 05:12:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E005C6B02F4; Fri, 16 Aug 2024 05:12:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C27736B02F2 for ; Fri, 16 Aug 2024 05:12:51 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 72BA7C088B for ; Fri, 16 Aug 2024 09:12:51 +0000 (UTC) X-FDA: 82457543742.24.8DA1C7B Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2051.outbound.protection.outlook.com [40.107.215.51]) by imf27.hostedemail.com (Postfix) with ESMTP id 0BF5D40007 for ; Fri, 16 Aug 2024 09:12:46 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=UuWup3DH; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf27.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.215.51 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; dmarc=pass (policy=quarantine) header.from=oppo.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723799493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VY9QOS5fN3AZlL4R3zdWzY382CXbfWPb5wa+SD0wRjg=; b=R/j+0WsRSAnSIuLmRxb1mVMmGewTL8JPGmNH1g6sC2tzOG7aG8tV00T1UETfKOYnReAY+S 4WCC3q5lvp6gRfP4SgKexNEi9ll8g0nOBdAPzmAEGV/XwPkhxqwfUmB04mKxBAtMDZNuC8 yZNUC1oqyLVIWT2S65UVlzA7WGPErpw= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1723799493; a=rsa-sha256; cv=pass; b=0ZdTGaVqLTAdHr84zZNElSL2VT+hJTpx5v4VREkpYdPUlZaIYWUL3m1G6wEW6eLFroFYFq b69ZlFU0dwHydDSJ9LBhz0u9sC4U4h9nqhlNXzpDXeGOzjejkxA7dbXNUD0j+5A5nzakjl Ek5Vt5VcxXEdb/7sRLVmfgLSqFVlHt0= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=UuWup3DH; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf27.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.215.51 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; dmarc=pass (policy=quarantine) header.from=oppo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wcUuat7zq0H02u8TjKz8JjR7gAw0BYe75Icr0XhnXZXbRI9qpsIaKdzVCS0TYurqqxDGl8K+ElW/PLV5xpWic/WnJyymlKk4PBLMmZQRchWJzvxO25YNsmr5Ya41KPxw7AS0NBCDdhCB3QCDUio2BdpIlzRWKq0CI6zyTIBm2yg7IZ7KJzbCealCH69pQrYvPwS4f9KT4uGA4tS9S6OhDBwz/CqGPYuKSuTennwcm8wojf+T02oxYEGYCU8a96+36noIOYCUfs1w5ZnJOpxOzU5xBeXkVyaSha1GO2CPu8ovnF0xqPXr2V/CmD0CrdskLw+Q+whuYQHjpnLmHXfzBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VY9QOS5fN3AZlL4R3zdWzY382CXbfWPb5wa+SD0wRjg=; b=vLrpkXD4+z9ulQkU/H/CAxeVDsxqb9zgvqT6NfHKTCGXBvUeDEs1M9liw+yoYBSZCy11Fd0XxeT1R4B11DXGQb2cM7cheXm2LKXSgO8zrUxQZ7CKdoCDjzzQf1DMQ3dQEJd8qjGxu0UtdSsTosAKNsV6cWNkQTbP9EFSd7c+oga/vqOle1oGlHX/5m1wt5RdsZ3rLPLFVQ/Vtj8fqkkai+8K6ZbPj2tx69CjFyzRmII0RneRlemHX+WIL81WwVHaIj6VITMxi3LITNJJq4OP7s/6jCA3FY9x1IkbCqm//tNkkBSvBxiMBCSACgG1j7bBBEhCJd1bBNUkVMAngsRkCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 58.252.5.68) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=oppo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=oppo.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VY9QOS5fN3AZlL4R3zdWzY382CXbfWPb5wa+SD0wRjg=; b=UuWup3DH99BccC7PDEwTksOhNv6ktNoM3gYX2MVc02xZ4LD9JrOwm5FEiAyyaAt6HxqVBji2w27tSF50VcyW0fMDLX9+hrkdVn/UnYq4f6Q/UlNC6DoF0GP8WBh13IgGTV/5P0NuHwzdAlRXz6cBYShq8RDmDX/NbzI4xxmUohc= Received: from SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) by SEYPR02MB7067.apcprd02.prod.outlook.com (2603:1096:101:1a9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.19; Fri, 16 Aug 2024 09:12:39 +0000 Received: from SG1PEPF000082E4.apcprd02.prod.outlook.com (2603:1096:4:140:cafe::8) by SI2P153CA0017.outlook.office365.com (2603:1096:4:140::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.10 via Frontend Transport; Fri, 16 Aug 2024 09:12:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 58.252.5.68) smtp.mailfrom=oppo.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=oppo.com; Received-SPF: Pass (protection.outlook.com: domain of oppo.com designates 58.252.5.68 as permitted sender) receiver=protection.outlook.com; client-ip=58.252.5.68; helo=mail.oppo.com; pr=C Received: from mail.oppo.com (58.252.5.68) by SG1PEPF000082E4.mail.protection.outlook.com (10.167.240.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7849.8 via Frontend Transport; Fri, 16 Aug 2024 09:12:38 +0000 Received: from oppo.com (172.16.40.118) by mailappw31.adc.com (172.16.56.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 16 Aug 2024 17:12:38 +0800 Date: Fri, 16 Aug 2024 17:12:32 +0800 From: Hailong Liu To: Andrew Morton CC: Uladzislau Rezki , Michal Hocko , "Barry Song" <21cnbao@gmail.com>, Christoph Hellwig , "Vlastimil Babka" , Tangquan Zheng , , Baoquan He , Matthew Wilcox , , Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: <20240816091232.fsliktqgza5o5x6t@oppo.com> References: <20240808122019.3361-1-hailong.liu@oppo.com> <20240815220709.47f66f200fd0a072777cc348@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240815220709.47f66f200fd0a072777cc348@linux-foundation.org> X-Originating-IP: [172.16.40.118] X-ClientProxiedBy: mailappw30.adc.com (172.16.56.197) To mailappw31.adc.com (172.16.56.198) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG1PEPF000082E4:EE_|SEYPR02MB7067:EE_ X-MS-Office365-Filtering-Correlation-Id: 6985adc2-2f9a-4a67-254b-08dcbdd3937b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?TxPAzu/sLQM3YEJM/zIAUexJuRXlHLpYXq76Oda9p4ZSK+vPNCfjIxNFN7YP?= =?us-ascii?Q?PdPUQMUp7Rn8/8feXA6cdIUUQuTWXz1iZr6d+7wgP/YiC+p+9PqHBuu52QpE?= =?us-ascii?Q?C7evlxv2b89qEN/2nz8qp4c6R4P6bbuKIta00+XsRySYy3u3wkypbA3A8X5p?= =?us-ascii?Q?UlZuWaWPFdzmtiGiCfZ8VTGwDdPy1pAE6GHCSpGCBtvLYRsViHVoldnkpmKX?= =?us-ascii?Q?OsUSwERkdLtwK1VXPoqAzCKljl7d1mLtfbyNMk87DSjQ0MoUwOeKZGMqNF5b?= =?us-ascii?Q?9ll3ALIXfV54THPYib98P5VOXXr9uX6diHWkiHMUgyjq+5Oxd594J2N/lHU6?= =?us-ascii?Q?pqZcLQmE3huMCti4i6xII2S1Uqff3/IpLBDcZTdwMw90KtCy/b2mm/Ylt6rN?= =?us-ascii?Q?/c9xaMy0hcDzoGQbAuvQ9jcWbjZwZ1R+3B1NHSZ2vQiRCSHE53OzTkXu9bjY?= =?us-ascii?Q?ULLAMMsjRtVHDKker68SmY7XcdFe0dfwrYocpUHKrU5HOe9/6cur9U2VjHmN?= =?us-ascii?Q?+l0dmRqQqTKx1nALftcgNiliSqLtt1MLXkdP6E79P7ayogbVN8c7TzmPPegC?= =?us-ascii?Q?dm+I0o1G51bmyp1uw0HcclakgHW8UdCnYKz5XPR5dLfzrN7J3aQKmDAJi18o?= =?us-ascii?Q?hotM4CXoZl7XQOehbReZyZyKmucdr2LfIWbOUCUfUqWx2kppqnn/ppavRacC?= =?us-ascii?Q?ID4uGB0qy44So40+DvoS2Z3fom630MnxZ8aTyCf8nV7i/EmPOFqsGI3WTt6d?= =?us-ascii?Q?3FQ45zji6xmk/ZHbv7qvpxcwSST4P3cAHZ7AmHhjr9eix/WXOxgsx9t+pL7b?= =?us-ascii?Q?AwoK1NAfY6RhHNu7xtouni2ln9KUHV8T6ox33kly3pq8PwsBqwcBYP9KkDUM?= =?us-ascii?Q?6Kylg1UGOQSRxpSdwAg/xfU/XEcRM9azdWzm5nNWr/tfj3jSxqvQQxufMVNa?= =?us-ascii?Q?P8r7biSk20TvU5fH1HX5N6TSkeM7pxtLQh/Wyrp/v3C2dygoWpVa8yJRz3s4?= =?us-ascii?Q?ODbAdmTWn5YTiJMsNviQfWMsuB/kl06tMTtozfb0IQJvC9y6+su7rxiHdzBL?= =?us-ascii?Q?vvpiZA6fmjJO6EBivoJhBfQTsXuF5i9D6wrK2ZsyWRlkantGG0S+GFJC4jBU?= =?us-ascii?Q?KNDrqA2/QFFjgeqK8QECk8AsVyYOZgH/Yrg4qxzAHry6DYg0/r2PExTSDWXL?= =?us-ascii?Q?KMc7Xnw5/SPuQ/CMrVe7p+CCZyy2+66IkyGfWcDROwmZLzb+gAPMCAIxN4AN?= =?us-ascii?Q?M6Og8B1YyeqJdTTJqggzwhDYcdaI/1IcvQniQo66y4fWc+9iec0gWEYWowML?= =?us-ascii?Q?iDTkFHrMjtJwdaxCt7vzPNo/edR3XmU5xTw6y17f939Ucyn/IK359O48bcrY?= =?us-ascii?Q?JkJ/wshS1lpc2+DOO07CzLK/LRzwpaF4vPQB20pouZH8NBj/K7VNIZrvsKOE?= =?us-ascii?Q?B5sOgaJoQDJolq/cYmzZ8xFT5pl+nVOX?= X-Forefront-Antispam-Report: CIP:58.252.5.68;CTRY:CN;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.oppo.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(7416014)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2024 09:12:38.8900 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6985adc2-2f9a-4a67-254b-08dcbdd3937b X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f1905eb1-c353-41c5-9516-62b4a54b5ee6;Ip=[58.252.5.68];Helo=[mail.oppo.com] X-MS-Exchange-CrossTenant-AuthSource: SG1PEPF000082E4.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR02MB7067 X-Stat-Signature: 5w9pu36tyqi1qin6thwgx6rinsft5pah X-Rspamd-Queue-Id: 0BF5D40007 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1723799566-536828 X-HE-Meta: U2FsdGVkX18/RuIByvXqLqSoonR8wyrUDEY5fYJRHwOBkQt/ShxFe/TOM7JHxc2cXZqQjZ6B0bMP/t8cNkKf+HMlFq2y4tDtf5l/dRJWiwVAiHPDsHzPTctb+cRL2njaH20icNGvtnyXntG2+YZRQGTGcX0+hCMWcl+vtBYSGhOlTO5A1JQbtFzPRDlEaT4QxDUNWWNs1j+wsVerPLGaYTpRUI4QvhDWB6NyrG4VinbixJVIOkVJwZJxHCAZg5IYhx3/S9jwMmpSTzfV2PwCG/1QPhvkcaTrklzcJLXVXwnXXEhycRSac8ofMLc+iXB0/DV2tWJxPFxsV+eBrFA6EIUiyL/75xF6l0GytMWymdU2uXNe8mgu/C3re8S1/GwUKNB31goqU8KFd/xZecz9N7y5AHfZ8C5fFEOOXDYO2OOpTQj0UJOLDWhYEAZfOtyQjkf6CtsJ1TKVa30ggt8zBJkSpFxRpVcpUcRacERtO9hEQ2g0sP3RUudIom1DIZ3T+SvW4EF2MoLqrI94tRRs7gRoEX1XaKjPaeZgBJcb3+hThEFp08czlaxTZES6lZPuvfd1/CxxI7lBHptNS5F7NIN8mNxM2B3A5wn10PM2yMdApIYriZkUQN1rviVW4RJ3MPrdglg+CvLNc5fh5n+THUylkc0HQPNpJhXxxbU7hfDQnvZkoSxSyqFIhpClw0GaiK4aFhtoTIRtaKhme0ieFKMIYwzaDNkUdrj3sr4GuWceQloPuo0rE5rd8Lg+KCco5fqShQrYB9ngNhlrhVRHRu7dEOkUY+qO/s1nk0U4emL3YD04ywKevrGjVPe+R2wVbojgnp0YQD9WEgT0ivmG/OoeYA1zeLIiR28NUxHzPstGcVATZaXvSWDiOlRm6mpiLCwKFzj5k6bAr2ToTdRZ6uUQY0fGM6dEj9Gz8jA4Jvu8ReIcs3yQxHRu/4uFmluVPSfqd/Wlr8g5kk6hIYM dgKMD7Kr j6y64tAQBctrd9kXDUn3BFZyJLLNZiNCLedInTr0mWNL3cWElvnz6ddrpVZQsDbuOSnHj0wryKnVUh7RmlS4Ismp40PVDppbxIB+oEfsG4JFjDAZuJ9fYflPWa4EkYB+YpM7KSqB0P/Fd0fuXB5fimBUWe7nyw/BthnMVWLQfCyew4tRXpyAxBvS1UqTNILdWRsk/y495KjfTzvChG8r6F7Ck1aQIAUUytIcBuWAoQb9sbiv15JrCx27wN/HhzVICjp/JVOh1dLKwhkX5xuBGm9QnkndTdq6h6yAmZpSPgaXeoYoJ0hYVeai23A8Huu22Cip8R910xCk+IsQevhfukYJzvNsLL4pzAR7rUeZFvZqiyz/njt8unOTQ/WmVC3XcweOAQYDaGFymgm8T+CX9NoOwfACY7qlBMpP2PjvIihk47FdlSkAzENHJ6svlW3DCAoEdqOWHuZDd9g9r6UBDUucpQ32xWe1nwxcUqr9SpBfT2iCyCetaAWxyyH5w9d5ZxAJZ1PerFttTyoaS922TST5et1SD9G08nksK+1IrV/b0SAzpxhamtXKc0lbOS/U0ZhlWU8pXhW4W/2moxmSESMD+Qg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 15. Aug 22:07, Andrew Morton wrote: > On Fri, 9 Aug 2024 11:41:42 +0200 Uladzislau Rezki wrote: > > > > > Acked-by: Barry Song > > > > > > > > because we already have a fallback here: > > > > > > > > void *__vmalloc_node_range_noprof : > > > > > > > > fail: > > > > if (shift > PAGE_SHIFT) { > > > > shift = PAGE_SHIFT; > > > > align = real_align; > > > > size = real_size; > > > > goto again; > > > > } > > > > > > This really deserves a comment because this is not really clear at all. > > > The code is also fragile and it would benefit from some re-org. > > > > > > Thanks for the fix. > > > > > > Acked-by: Michal Hocko > > > > > I agree. This is only clear for people who know the code. A "fallback" > > to order-0 should be commented. > > It's been a week. Could someone please propose a fixup patch to add > this comment? Hi Andrew: Do you mean that I need to send a v2 patch with the the comments included? -- Brs, hailong.