From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AA5FC3DA4A for ; Fri, 16 Aug 2024 05:03:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 205836B02BF; Fri, 16 Aug 2024 01:03:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B4FF6B02C0; Fri, 16 Aug 2024 01:03:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A36E6B02C1; Fri, 16 Aug 2024 01:03:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E17066B02BF for ; Fri, 16 Aug 2024 01:03:23 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9EDA9809D7 for ; Fri, 16 Aug 2024 05:03:23 +0000 (UTC) X-FDA: 82456915086.09.6B11655 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id C28BCA001C for ; Fri, 16 Aug 2024 05:03:21 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MNC1V273; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723784544; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FdVgIWTt2uTYSg+qSD70pdC3wJ/NP6zsswhGMQsX+4g=; b=7YdhJ8DPvlmP3TJcfLO58asgP+Ak2R8+r673/GC8UqpUQT/f+h593JnwQTGSdWKB3Qchx1 J3WJBchq8LFVD7J/BolSQV10OrvvZJ5pfVUdcphv8YcI8DtisJO/tCBXoitOHsx/8zU38t Ag7cG4CTdB5qHtkxi3DfC5BmkKNGtuI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MNC1V273; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723784544; a=rsa-sha256; cv=none; b=Qyt38Tc+275qeKHY3fpVa6Z4L95Ws7Ad3r+IPjN5khKty0F/HkR7HMVfULt0VH9UfVbkNA eaLFXllq+hgi37GUFJ+puwNKPRMk3nFcLUIckb1rUG1D02Gd+YlDEJ1xOiag8KnDdgQIqA tp7Uk53PcMeG/iQm0wa3KEkggzibMVU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0A0ED620A3; Fri, 16 Aug 2024 04:58:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8709EC32782; Fri, 16 Aug 2024 04:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1723784288; bh=uUVkLWIhZqTLhpu++OgX5TX5ELorIrhJ6UoJPt4saaY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MNC1V273v/uVDewlmy4L7vsDy6thPud4w8773ZysKQHqhoLaG1kaXGhcZKoSiMWuS B2mzFuC8E2Xa6j5wkaYvoRMPfch+yM5C8nn0kuf6dSOSY2zR9hhsGg3nQdo6ZOMXCH YPdnXvLVAmlnsGhkz3ytYUPJPPleqafXnKo0tKJU= Date: Thu, 15 Aug 2024 21:58:08 -0700 From: Andrew Morton To: Kefeng Wang Cc: David Hildenbrand , Oscar Salvador , Zi Yan , , Matthew Wilcox Subject: Re: [PATCH] mm: remove migration for HugePage in isolate_single_pageblock() Message-Id: <20240815215808.c2086dfe013cf2e2360e8bd6@linux-foundation.org> In-Reply-To: <20240816040625.650053-1-wangkefeng.wang@huawei.com> References: <20240816040625.650053-1-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: dpb8q6t6fiupkhtspzf5ht5yhng6ghy7 X-Rspam-User: X-Rspamd-Queue-Id: C28BCA001C X-Rspamd-Server: rspam02 X-HE-Tag: 1723784601-477571 X-HE-Meta: U2FsdGVkX1+UY57nmlkVGf3X8cYWt/zPFKonec2kB72BwK083we5+9x/lbBseA9b7lTOln7UGM4QXH/YPlj7LzEfvWiP+lY/H+BPS6Y2/Ou3PznBPLBKYgxFd/DIUwrs6Rsl5b+5SgtWK8Dg7a/WuuBMgfnV9uKZ2KGrIriyKIouoPxtHWNOySoEmerhCQkWIf3ItCCP+8IYY450LDkCqx8jCGZXLSbkNnLtZQZPpekIyYBdsDA6pG0QBB3R5/bPR+bUfYXUy7nvh3R3YQGjmWU3b81wxcBhhpmMYrMP8hYD8yVY2ZeqjIXzmpiGzFBxz0LS22429YyznXxQk1Cp2z7hbfpQBu3f4sSM9xK1fbkvGfOZQjdT+V6HmpYrtZVFDplnFootN97JYTgzlA7cAKaVmokX8kauhl5ndKaucbZ3ge/TqS9qeEgGLkXEOP4eBwGMiDYIk9H99O9Q/cQ7SJ6rZjqnfl79Dw+r8tI8hmmPdLl5/3DxHAErzlPTcpX9KoOJeyB0iNayMKatp/R6JNir2v+6mxC/z/JzuXCpjNX1o5IJr7LQajh+kBI3iJJG7vysifGZlhNXdwQYhxfP/0a2QpCeNKPzBSj8onRJ754fntkrXlT/jZ3u4C6oQo5tuAUEBSAKd15kULApplYoDWBn+XJgr7p12PaGdsUdKMuj1FaKQU/WsjC+BFZBXkwk/0BTIc3PdxEuOTkF4O2nqmWAL5hyKU+YfwM8yQ5Gv0yEqECC1JsP3a7YKj4mBhZGnaTgonB/U01UaTcjfUDibCnI59PHqCyk4aieDBIc7AJEA09Iz9DRod1psB4buJlImFuOILhoyR5Q3JgV07d4WyEkyKGJGtwfHuggn9NnEoynDDDRgsoUmw+Fo7pHdoS2nFewKZgGjHRh380BerHTzG2/lsvSTgIRv8/hdiJJevFuG/MaEgTj6PdV+vhSy/lHL0rUoB2Gh5Xgs8/Ht90 6z9LgPfM GqeoFfapocUliJ1RFbO8TCvlD3uaPsMMKLMTej+xpgEcCqUmHBHZMAUnTuwHNoy6WLO+MbXhUz+JKMtuJTV62C94vbDcNhSjsB8EWNrVuYbDZxPrsW7CGwbuRQizCMBXW//um0FJHoSkFf4y8/SW/IX1DO4lTfVLplMok8R8teWFMYiZ7rCk1cdyr24b/qXwJ/bXnEqwUVwXv9t1EyP+UQ0PzxncDgANFZxo5tpMlHBQ7QvBgoZ75wg9JsdRYQxREIOu5DPc80oBlBBxIpdYSvYFdZema7vMymWPVp9QmVojjLVM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 16 Aug 2024 12:06:25 +0800 Kefeng Wang wrote: > The gigantic page size may larger than memory block size, so memory > offline always fails in this case after commit b2c9e2fbba32 ("mm: make > alloc_contig_range work at pageblock granularity"), > > offline_pages > start_isolate_page_range > start_isolate_page_range(isolate_before=true) > isolate [isolate_start, isolate_start + pageblock_nr_pages) > start_isolate_page_range(isolate_before=false) > isolate [isolate_end - pageblock_nr_pages, isolate_end) pageblock > __alloc_contig_migrate_range > isolate_migratepages_range > isolate_migratepages_block > isolate_or_dissolve_huge_page > if (hstate_is_gigantic(h)) > return -ENOMEM; > > In fact, we don't need to migrate page in page range isolation, for > memory offline path, there is do_migrate_range() to move the pages. > For contig allocation, there is another __alloc_contig_migrate_range() > after isolation to migrate the pages. So fix issue by skipping the > __alloc_contig_migrate_range() in isolate_single_pageblock(). > > Fixes: b2c9e2fbba32 ("mm: make alloc_contig_range work at pageblock granularity") Should we backport this into -stable kernels?