From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04A27C52D7F for ; Thu, 15 Aug 2024 23:30:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 832C38D0011; Thu, 15 Aug 2024 19:30:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E2AE8D000B; Thu, 15 Aug 2024 19:30:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AAEA8D0011; Thu, 15 Aug 2024 19:30:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4C4C68D000B for ; Thu, 15 Aug 2024 19:30:22 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9F179C1895 for ; Thu, 15 Aug 2024 23:30:21 +0000 (UTC) X-FDA: 82456075842.19.4137D8D Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf30.hostedemail.com (Postfix) with ESMTP id 46C9B8000B for ; Thu, 15 Aug 2024 23:30:18 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Rtq95sLe; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723764562; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a3ngONRIhbz7dPHM4YuVboJpYAf4a52MIUfupWO6XSY=; b=50VnyzK+5pOYuLvK0T7pcZmB/BugErhJtMj7ZX8yf96GghRA60O585QfPMgdXg/T1GB77W fx7TOMP5Ne4DxPJc78Pel89gHxDOCMOVoSOZouUp64mO1LWslLtWEcWtwn4Wr9rTI05FNS uUICFq6tEJ9W5wvgW1T4erws2Hj/nU0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Rtq95sLe; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723764562; a=rsa-sha256; cv=none; b=CTXXD3cfxT3HB2v+wFBGckbi7H0FTBwMC+PCgkjjkn0vV6OZBr//i+sdo357E4Ai3ugUdu C/yZ+RabOhNO0SWOgl3N/nklWk9oItt4Pq2xGMHIEGXiZ+aNp8PPJQxt+DdrErKWXZaS6K b9IVvS27Jaoze9TSD6MxcfkLEPxKrMo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C17E1CE1E86; Thu, 15 Aug 2024 23:30:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F94BC32786; Thu, 15 Aug 2024 23:30:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1723764615; bh=9ybmCfblB8Ey7gn8Q0u+C7HuoH1fJL2UaVC7mbCadHM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Rtq95sLeC/zJdIJ6AbOUVJFGQJQLik8GjegYp9ZEL9ezhrfIAxA0vIIgkgA4X7bs9 PI1dImoavQo2D1OEqQ+zjaSEoe30VipY7+v73eD+h7BVLhAQZo4k3FzSlEfw/G3qgo mmp43J4W6XM1bGyPIfZlSaimw+af0qiOYlDE4FaE= Date: Thu, 15 Aug 2024 16:30:13 -0700 From: Andrew Morton To: Usama Arif Cc: Barry Song <21cnbao@gmail.com>, baohua@kernel.org, cerasuolodomenico@gmail.com, corbet@lwn.net, david@redhat.com, hannes@cmpxchg.org, kernel-team@meta.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, riel@surriel.com, roman.gushchin@linux.dev, rppt@kernel.org, ryan.roberts@arm.com, shakeel.butt@linux.dev, willy@infradead.org, yuzhao@google.com Subject: Re: [PATCH v3 4/6] mm: Introduce a pageflag for partially mapped folios Message-Id: <20240815163013.2522e3dd83acffe70af9cba6@linux-foundation.org> In-Reply-To: <4acdf2b7-ed65-4087-9806-8f4a187b4eb5@gmail.com> References: <88d411c5-6d66-4d41-ae86-e0f943e5fb91@gmail.com> <20240814230533.54938-1-21cnbao@gmail.com> <4acdf2b7-ed65-4087-9806-8f4a187b4eb5@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: pkttpq8gdawaji5qsctnk9mhmohb6bgr X-Rspam-User: X-Rspamd-Queue-Id: 46C9B8000B X-Rspamd-Server: rspam02 X-HE-Tag: 1723764618-435255 X-HE-Meta: U2FsdGVkX18v5mHKCKe9MxQuBekUnRcewFd2FLUTIDt3S8CKEd1El/jDXfm8XBbfD9iBkCLMc8yEsXOU6cefoUANFiPrZIlDSbdP2K+00+CLdAZLYT8BYGmTJ9sJALsnMRypCI1RPOT52Pm9xEj9nm+Hfkk9fHcK+1y3y7jeCVcrm7cdFx/M7DgOOiSWO3zPU7eh9T0FG65HvDPE/RJ3PUutn97mRDS7ECL3LR3OL4xYH9QHCyABVLg+YJ59nPGgA65gO+8MW3BYaKJC3oBPMu4gfsvCt2pFgtbN1pTiP+waeRx+hn61JQz5LlCoOjeSPGoVdeEDNYAHtS0/fWCSExpZVNP+hS7QbHPyfvOfMW4S6hQnLOXu2thDnR8MBJ7mO+aROThOL3xIDGPlGNbdrYaljRNZWlJnENNquv552/m34N1/TRrilIbRWp6YcvptGOnjqHkHX6/2FjGfTdK61mANfwX1wfhu9B4Y2IXP+z38KAr6ZTeowY8Qkuzs6z33jMaoAhFohVJf1XtRm9fDsvwuWy1m55YAuMUcu4vNccuG0HEZD+Je9PzBgXFCx2FJRuq0DdxdX7uqgu4lXXd5qth7LJaDuRcB0IazMDpdPUXRe/CYnCP1WIrdOFe/bD8EumgFJ28L4n86QYJnFxdTBA6WVUp3KRE/onxeKibccrkyXDYp76uyBMPV67JEionC4HQK7JHL207RkQ+uOJgEtOZJufixhWsjazU29sGmelOVnMud3HK15OzZBdZKqpuvf2iGaBIGLEbvwT6UY5JEgfgNb63vh68mo29y11mwUtg9Sqi2TIYN7GCpQpYJolAgW8pyj7PqqcB7SX2NRozDQooh4SGEbSyTnfeD3IoHH32UfNrwKU5rLO/Hi6EWd1l3kQjqJtPx5eyKsddg7viKAQUkBgKj9fZuAZjjIm2g67mKBXf0kAqV6BnMtRlp136jc4q7ewaLnjz5sN19U91 5rmEu54/ wdZ4xXvFgGl2aXeUnyZe1EM2I1cKmB89Q/1uBuuoG/I1SNYoTWQytbL3dOkZbvQfHF9N+13KZ3uH8XPHgag7Edi0RyJavQhkgtJF28fDOkP7RYRzNYDMc4eccsWvIagkdRzSRJcjG4SssRNpVcJmjVPHWlg0LPp2FdNG1CqT6yLH5P+7SdqTba3mawUYE7MjVSsoiaSHJGytOhYUH1hW/vBSK407wchC2Eku7PWX3HlYzj2JQ1UdkFDeyyg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 15 Aug 2024 16:25:09 +0100 Usama Arif wrote: > > > commit c627655548fa09b59849e942da4decc84fa0b0f2 > Author: Usama Arif > Date: Thu Aug 15 16:07:20 2024 +0100 > > mm: Introduce a pageflag for partially mapped folios fix > > Fixes the original commit by not clearing partially mapped bit > in hugeTLB folios and fixing deferred split THP stats. > > ... > Life is getting complicated. > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1758,7 +1758,6 @@ static void __update_and_free_hugetlb_folio(struct hstate *h, > free_gigantic_folio(folio, huge_page_order(h)); > } else { > INIT_LIST_HEAD(&folio->_deferred_list); > - folio_clear_partially_mapped(folio); > folio_put(folio); > } > } Yu Zhao's "mm/hugetlb: use __GFP_COMP for gigantic folios" was expecting that folio_clear_partially_mapped() to be there. I resolved this within mm-hugetlb-use-__gfp_comp-for-gigantic-folios.patch thusly: @@ -1748,18 +1704,8 @@ static void __update_and_free_hugetlb_fo folio_ref_unfreeze(folio, 1); - /* - * Non-gigantic pages demoted from CMA allocated gigantic pages - * need to be given back to CMA in free_gigantic_folio. - */ - if (hstate_is_gigantic(h) || - hugetlb_cma_folio(folio, huge_page_order(h))) { - destroy_compound_gigantic_folio(folio, huge_page_order(h)); - free_gigantic_folio(folio, huge_page_order(h)); - } else { - INIT_LIST_HEAD(&folio->_deferred_list); - folio_put(folio); - } + INIT_LIST_HEAD(&folio->_deferred_list); + hugetlb_free_folio(folio); } /* Please check.