From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ACA3C52D7F for ; Thu, 15 Aug 2024 22:08:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F5456B0261; Thu, 15 Aug 2024 18:08:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77E6D6B0266; Thu, 15 Aug 2024 18:08:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61F136B0269; Thu, 15 Aug 2024 18:08:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 412EE6B0261 for ; Thu, 15 Aug 2024 18:08:28 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B7041A8FC4 for ; Thu, 15 Aug 2024 22:08:27 +0000 (UTC) X-FDA: 82455869454.05.4726C13 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf11.hostedemail.com (Postfix) with ESMTP id 8D4A640021 for ; Thu, 15 Aug 2024 22:08:25 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=a0ocZodL; dmarc=none; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723759624; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dwOvbgLLC7blGlbYyliCNLhLpcDE9tCHPe7Dvqsb038=; b=UgO2SeVBNLQH/gDz7xcF1gQ5y6lbliwN3ih127NkadU8VJB9edgsqIUMHf4Qo00wwrGr0s 1vjszrxkEZGVWQUxtYBCWVjcKXQuY3F1NlAnGoNGh4fma2/6jQ96vUJjORfsFWY1FGb7z0 138kVb2J7B5yKYkW8pit6ZTD8/ISzaI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723759624; a=rsa-sha256; cv=none; b=ZR0yk+WFMaAhFMZtDVIUGHpuWdy2KxEu5Rt2Ufh3a6d7h6mFLaPYFVf1N/XAh5H4DpJzp6 2wE0U8XUBRr59DbvLUHakzRI7HSTJsMU6poHJylhNwxnpdjT1fLSy13/nfrpnzHBGawkaw hXy/orxcATMyYOkA8b3apZ7cl9HR8Z0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=a0ocZodL; dmarc=none; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 69F6BCE1E44; Thu, 15 Aug 2024 22:08:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24BDCC32786; Thu, 15 Aug 2024 22:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1723759700; bh=YtFXgyqpzm2Rt1zT4t38YIrkQsdF3Y09PgGCqyONOtQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=a0ocZodLN84n+Y0Mw/qYnMIi1sHS4o6xYxB0OYzVlM6FgkKzWtx0AuVvdl6IyiTnE N2ZqguA7CKuFWbG1fWjf24rjfItaGrhKWosd6OtGQoNPELywY6Xz6tApRpn6V1ZnH6 KEN+IVrsrZrrC9h0XkA45y7QWQRcdnY9aFTjrMwk= Date: Thu, 15 Aug 2024 15:08:19 -0700 From: Andrew Morton To: Nhat Pham Cc: Mike Yuan , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Muchun Song , Shakeel Butt , Roman Gushchin , Michal Hocko , Johannes Weiner Subject: Re: [PATCH] mm/memcontrol: respect zswap.writeback setting from parent cg too Message-Id: <20240815150819.9873910fa73a3f9f5e37ef4d@linux-foundation.org> In-Reply-To: References: <20240814171800.23558-1-me@yhndnzj.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8D4A640021 X-Stat-Signature: uuinztwacrobq81xn389o9e9xaywdgp4 X-Rspam-User: X-HE-Tag: 1723759705-445285 X-HE-Meta: U2FsdGVkX18qA95T751oYKVTlgf08Vc4oXut2IMhFk+oN5r90OD3s2wIg32/onk51R65NlciUzrE/k7UjyNqQhid+nkKT5Xz4vZtVWnuxGR4Tw7nfrGt5Q2rIn2SFvuKAWpAosuHrztmRQrNTLGshBLrgGq2k4B6/Di3+R+S9Vvh/G0oAERKnEkDGVGOqLj0C15MjRFvX1L2nfx4CmBNfxSJ8OrZz7jUEY49BoX2VCQjFVc+t8xE/2LgC7f7ej32D49yA0oeQcan98YT1J1JBSucWobUOMlkdBJNYKMvKX32c+lxmDATKqv6Go4klAWrNlVpCq0j10ajr7ZroU9RK1rYUbaEE/eQdF3ayp2exjDeqfAU6EIIMjTshq9ppF4GyzFXkdTYk3kKvtx08V1FuttSC5YDEQnxWGuSMqb0NcHmd0gbL6T4/DCWHD/xExDd2MCtrxDHi+KWwKqCqR4DxPQ3tgPnkYr1sDAirRBSEjjUVdzkAKwBzMwpBHJUPz5IuI1/9MtC7ulGbt++sn1AMGNGk9SKDlPptoYbF/EJOdm68qRgL+fO7NmYdlAV+kIB/Pk20jJ7tSeUF02RcGshR06Arpf/CY/Go52C6khnzHJUmxxXBlWGqs7b2txMKR4oNjg2TO4T5XlDR3uMuBMOPX5qSFHnqsQ8sMyP6j2gKbW3LJJA0b9X3IxSx3fkbGF9MwuKyvIohezgNU4a7pg8IYQMYWWPGycg10LIDXg+4Io3OI7SxD8KE+2I35zrRpD6jj1xavUfY+JP6lxHAKd3VFJb6AGtoHj9pN8vZwlezOpeVU7cz0jhmzwspR18uB3+uAaiFfjaBE/kTAHy+X1H7DzoNxnyRX9TwUEUsMJtmXEDBmt3es+B+RAEOaok3wVnRuY+FnzKW+pyYIgPBYVh5BfXYEQG0wQxcgCracNjVI4itutWP0QccvRQRKRXvsmnLvca7NA5P0LmDVBf6bm 7iWvVp/L De0BaYr8YGpOkeqDue5ApwGmP7ZacjJWyFPGDCklXUOFcI8io2nxCudosyqArqKDn5ww4sPiXr0F0yYIpLgSmeDROX8RerEOLwvKhYO+m1Cvb1uXzWG6vlZI8GUBID4qcswI8eLEwN6kXAWQS3qgw+vzgUvkawDUO4rH/JayOc84/hIvUw7OJqL8dCTiFR2KYjwlh8h8Y0Rxb1+vrFL2XZFT6h+C9Fq7EV8SKGjWXD7F3/FfN9ouDIrZq0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 15 Aug 2024 12:12:26 -0700 Nhat Pham wrote: > > Yeah, I thought about the other way around and reached the same > > conclusion. > > And there's permission boundary in the mix too - if root disables zswap > > writeback for its cgroup, the subcgroups, which could possibly be owned > > by other users, should not be able to reenable this. > > Hmm yeah, I think I agree with your and Yosry's reasonings :) It > doesn't affect our use case AFAICS, and the code looks solid to me, > so: > > Reviewed-by: Nhat Pham But you'd still like an update to Documentation/admin-guide/cgroup-v2.rst?