From: Andrew Morton <akpm@linux-foundation.org>
To: Nhat Pham <nphamcs@gmail.com>
Cc: Mike Yuan <me@yhndnzj.com>, Yosry Ahmed <yosryahmed@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org, Muchun Song <muchun.song@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Roman Gushchin <roman.gushchin@linux.dev>,
Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] mm/memcontrol: respect zswap.writeback setting from parent cg too
Date: Thu, 15 Aug 2024 15:08:19 -0700 [thread overview]
Message-ID: <20240815150819.9873910fa73a3f9f5e37ef4d@linux-foundation.org> (raw)
In-Reply-To: <CAKEwX=MDZdAHei3=UyYrsgWqyt-41_vOdCvTxj35O62NZhcN2A@mail.gmail.com>
On Thu, 15 Aug 2024 12:12:26 -0700 Nhat Pham <nphamcs@gmail.com> wrote:
> > Yeah, I thought about the other way around and reached the same
> > conclusion.
> > And there's permission boundary in the mix too - if root disables zswap
> > writeback for its cgroup, the subcgroups, which could possibly be owned
> > by other users, should not be able to reenable this.
>
> Hmm yeah, I think I agree with your and Yosry's reasonings :) It
> doesn't affect our use case AFAICS, and the code looks solid to me,
> so:
>
> Reviewed-by: Nhat Pham <nphamcs@gmail.com>
But you'd still like an update to Documentation/admin-guide/cgroup-v2.rst?
next prev parent reply other threads:[~2024-08-15 22:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 17:20 Mike Yuan
2024-08-14 19:52 ` Nhat Pham
2024-08-14 19:53 ` Nhat Pham
2024-08-15 18:39 ` Mike Yuan
2024-08-15 19:10 ` Nhat Pham
2024-08-16 13:25 ` Mike Yuan
2024-08-14 20:22 ` Yosry Ahmed
2024-08-14 20:43 ` Mike Yuan
2024-08-15 19:12 ` Nhat Pham
2024-08-15 22:08 ` Andrew Morton [this message]
2024-08-15 22:10 ` Yosry Ahmed
2024-08-15 23:31 ` Nhat Pham
2024-08-19 19:05 ` Yosry Ahmed
2024-08-20 1:01 ` Andrew Morton
2024-08-20 1:06 ` Yosry Ahmed
2024-08-20 15:28 ` Nhat Pham
2024-08-21 16:14 ` Michal Koutný
2024-08-22 17:49 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815150819.9873910fa73a3f9f5e37ef4d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=me@yhndnzj.com \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox