From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E35CC3DA7F for ; Thu, 15 Aug 2024 12:52:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F6F06B00DF; Thu, 15 Aug 2024 08:52:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A74C6B00E0; Thu, 15 Aug 2024 08:52:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76E136B00E1; Thu, 15 Aug 2024 08:52:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5972D6B00DF for ; Thu, 15 Aug 2024 08:52:12 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EE9C381528 for ; Thu, 15 Aug 2024 12:52:11 +0000 (UTC) X-FDA: 82454467662.01.305AD7C Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf08.hostedemail.com (Postfix) with ESMTP id DBA1516002E for ; Thu, 15 Aug 2024 12:52:08 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UCrqLpYr; spf=pass (imf08.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723726256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JSBdkSN06atmwyYLpN2LTxDdHk6T7WTh8BH/yUHQueA=; b=fnqh1q2kTttcNavfk6VlY41jF9hn/dwogI+cy5Cl4caJaQ4jyq6cGyC8COzI+g1cYqqd80 XwbH9wjlebTyQd9WsmmHg6ysheqpDNwpIiRmV4qNK0mmunQqXMEd0ududJralszjHGUDpV Kk7SPhZFE/ZX05NtdH40QO7YZLpcg/E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723726256; a=rsa-sha256; cv=none; b=GfdQAYQ3Ovu452tg/+qAfTw2qAW5VT/ucnZANfxqTn2msbIHmK6mBQotEPfGw0CkxEZDxA ci9HSWw0foONGCEG/4QD/G0aQweKvLNUDTF4mxJbXiyJ7V0BMG/Pwig20Nm+8+zuSop8Hk 7OenemzWhOFZz1a8qm/APSy//gx/1go= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UCrqLpYr; spf=pass (imf08.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 56C12CE1BA4; Thu, 15 Aug 2024 12:52:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A72DC32786; Thu, 15 Aug 2024 12:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723726324; bh=fmAaJecgka9DtD3tycYfxWFmq7Wq+S8jNV0j+zS0T9g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UCrqLpYrUKSUV4NpK5XZNazZdoJIu5QrDwMTOjSqEKEXJN9l7hJ12jYtbT3ZJM4Tj buXE6UCmk9Q0isaJvAHJ/6sGwjIz8S9NC5uZNkHc3shRfJTzgttQO8WK3CRWAn1uie mrrXKbEszrW8q/x6+z7Ygfbogv2HmwQLIhYJiawPr0oy6/Vqw9+wjafwVmGT9i2YKS sMpD69ZVFWbs67KBUYRwv+1uIRxju3SKls77GX2g9vEVxO80EBoXsFxw+YUqeLX2vZ KPFdUnSDRQ8cGDprINzne9L4j4hHpYmJ8BhvHrCdqOL8YkLT2HHvIKvHT87J7MQNop GbZ4qAZZq2MWw== Date: Thu, 15 Aug 2024 14:51:58 +0200 From: Christian Brauner To: David Howells , Konstantin Ryabitsev Cc: Max Kellermann , Ilya Dryomov , Xiubo Li , Jeff Layton , Matthew Wilcox , ceph-devel@vger.kernel.org, netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tools@kernel.org Subject: Re: [PATCH] netfs, ceph: Partially revert "netfs: Replace PG_fscache by setting folio->private and marking dirty" Message-ID: <20240815-seiten-vorteil-168ac82432a7@brauner> References: <2181767.1723665003@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2181767.1723665003@warthog.procyon.org.uk> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DBA1516002E X-Stat-Signature: 79qmbncgx16g5hu1eeuaziqjcprx8rfr X-HE-Tag: 1723726328-318658 X-HE-Meta: U2FsdGVkX1/96CeEh2ZBUKfs/NIepiy5F9EPxxKy9zAI9vyjXGU3beo9b8y1hG0Ytw5mv/ryqo4Pfck7UnpHHjGTI9zKIPAt4jtDavJ4mY2kOPz/aHeq6bm8Ac9DQ++alkfANFWuroYCY7btepwrmEUjg17u4bI455KhuYVSm10XhxOCLz2g3d4NSqAvFMcLbVDIZYQ4U+sR0xtbF6Toxf+obyw8hhv7cKh2GmEq6YcNaPOTZruL2/8RYOecXDQtFOReEJGmvrkPzu7McpBSZFqy+Eobz2aNam2Go6J/cruEuMV2/8Qo1a3NrOerPqhzm3I8DIY3qZaL06bC1eb7OjbaZ3TmZdYAzBBsjmnfaxbNm9CDa0wcGjDf60PZ1xwT8bBC+JuJqNb1sLUcfsPvqHvetvZsmL6gMg3tzs8PCx5CVoqpE9wh2iBu38BSdnk2Uw/ZPq1jwxoIX4S7U2FDuBICVFmRS3HKdRyFChvrvPKthkSdXJCfB0Sfl7FQACA1csIVG5SSm1nTHCIhq2hDPVV1BdwfelQ2wc9KfE+MeG7Bn0Oi61gPgVGmIYOMAr2d3p/wuGceY2EPgh+UfALEfqRKj6peC8MiaqhEWdyka4VsbrPjuxYkH3iS9v72K92lD6Fblszv8cP5jQKovS2DOCXhLiWWGvfjw9hjsKqU9cdGaWTCk1eTam/3lKp+Vvs/ipL61VAm0RPBHQcqaB0TXkJQu0aBKfZWqw1+izDttakTSD+pgBeyiMod/4n+iH9lwOEUEAD9LEObu7Ab/4odN3fief06NxFdeIFyBRv4FHa8Qkp4jYbA9bN2byIQmflu+ogvZHPOsXTggXT0pXvfZnWG3Q9YGRMo9YBDLSikWnQvYPYFjtzc/1K4HdeqLkyhCsr3M+E/i4u9jhTfKO857gqrKY/IP8EMtwr6z6v567O9ko6E+dfW3FV5n+CwkW114Sp10LBVKRZzl9yLogz MGCXvLdf rlJPaHR+8y14Za9d0GWUAlOKyMuZVtO2QWN8J8hjtJFCYu5wUDZQhnqjtGbxeSljafIqVzKBuaJQz2a1x7dVya5AepQd/23UPMvdwFBsPzIqXseT7k6whRnHd4cqrOYSfNcy9wKkP0/0xxdOsWXJ6wOvcEgIPM+DRtR2r7YPLcDJRIW5QI+mBMPOF5vRb9Iwc25pEFxlvQYXJomBL8HZsAbdLHzUm56THAEVwINwAQ7NZwZrhVymgvRS0si8KxjIsViqFTh7oLsZLoRgTHxQddoUrq8vs3afzch+seKz2zZU3nrAoIMC3gl9cvpnAQVdIwbquMH1nx9ffcwCfVCxe2oN30OETZvmMdOPiAQL7EWYZ+r1Mi9ru3EcB0+vysmg9YA5HX3fBc8DoLjzR7Aix6K6PQUyCg4AGaEluJPJW8lIC/iTmlX/gQ0zHns0J3eODpLA3PW9eDu60JJVdH5pRtmfd6QCPYtjBQg2zRGsP3H5bHk/axyorvxxqxRALQbPmEkSgi5PwREQg5/ZGjoylnzPaOFjtzbdaLEZYY8MuRdoGWK4/2hiscfZ/XXVlAYcNBnbJwPjiLkejxVYlfCo4lvXEc0OLYOIHU6eoORcIDue3rpbDW5T00yTdN+n8VWs8EEb00y/W/YC1hnukpRspgz1tDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 08:50:03PM GMT, David Howells wrote: > > This partially reverts commit 2ff1e97587f4d398686f52c07afde3faf3da4e5c. > > In addition to reverting the removal of PG_private_2 wrangling from the > buffered read code[1][2], the removal of the waits for PG_private_2 from > netfs_release_folio() and netfs_invalidate_folio() need reverting too. > > It also adds a wait into ceph_evict_inode() to wait for netfs read and > copy-to-cache ops to complete. > > Fixes: 2ff1e97587f4 ("netfs: Replace PG_fscache by setting folio->private and marking dirty") > Signed-off-by: David Howells > cc: Max Kellermann > cc: Ilya Dryomov > cc: Xiubo Li > cc: Jeff Layton > cc: Matthew Wilcox > cc: ceph-devel@vger.kernel.org > cc: netfs@lists.linux.dev > cc: linux-fsdevel@vger.kernel.org > cc: linux-mm@kvack.org > Link: https://lore.kernel.org/r/3575457.1722355300@warthog.procyon.org.uk [1] > Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8e5ced7804cb9184c4a23f8054551240562a8eda [2] > --- Now in vfs.fixes. @Konstantin, for some reason I keep having issues with this patch series. It confuses b4 to no end. When I try to shazam this single patch here using 2181767.1723665003@warthog.procyon.org.uk it pull down a 26 patch series. And with -P _ it complains that it can't find the messag id.