From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: linux-mm@kvack.org, linux-arch@vger.kernel.org
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-s390@vger.kernel.org, linux-um@lists.infradead.org,
x86@kernel.org
Subject: [PATCH 4/5] s390: Remove custom definition of mk_pte()
Date: Wed, 14 Aug 2024 16:44:24 +0100 [thread overview]
Message-ID: <20240814154427.162475-5-willy@infradead.org> (raw)
In-Reply-To: <20240814154427.162475-1-willy@infradead.org>
I believe the test for PageDirty() is no longer needed. The
commit adding it was abf09bed3cce with the rationale that this
avoided faults for tmpfs and shmem pages. shmem does not mark
newly allocated folios as dirty since 2016 (commit 75edd345e8ed)
so this test has been ineffective since then.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
arch/s390/include/asm/pgtable.h | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h
index 6a21d947a687..1bb7f33394d0 100644
--- a/arch/s390/include/asm/pgtable.h
+++ b/arch/s390/include/asm/pgtable.h
@@ -1413,17 +1413,6 @@ static inline pte_t mk_pte_phys(unsigned long physpage, pgprot_t pgprot)
return pte_mkyoung(__pte);
}
-static inline pte_t mk_pte(struct page *page, pgprot_t pgprot)
-{
- unsigned long physpage = page_to_phys(page);
- pte_t __pte = mk_pte_phys(physpage, pgprot);
-
- if (pte_write(__pte) && PageDirty(page))
- __pte = pte_mkdirty(__pte);
- return __pte;
-}
-#define mk_pte mk_pte
-
#define pgd_index(address) (((address) >> PGDIR_SHIFT) & (PTRS_PER_PGD-1))
#define p4d_index(address) (((address) >> P4D_SHIFT) & (PTRS_PER_P4D-1))
#define pud_index(address) (((address) >> PUD_SHIFT) & (PTRS_PER_PUD-1))
--
2.43.0
next prev parent reply other threads:[~2024-08-14 15:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 15:44 [PATCH 0/5] Provide a single " Matthew Wilcox (Oracle)
2024-08-14 15:44 ` [PATCH 1/5] mm: Introduce a common " Matthew Wilcox (Oracle)
2024-08-15 2:45 ` kernel test robot
2024-08-15 2:45 ` kernel test robot
2024-08-14 15:44 ` [PATCH 2/5] x86: Remove custom " Matthew Wilcox (Oracle)
2024-08-15 4:08 ` kernel test robot
2024-08-14 15:44 ` [PATCH 3/5] um: " Matthew Wilcox (Oracle)
2024-08-14 15:44 ` Matthew Wilcox (Oracle) [this message]
2024-08-15 12:12 ` [PATCH 4/5] s390: " Alexander Gordeev
2024-08-22 14:06 ` Alexander Gordeev
2024-08-14 15:44 ` [PATCH 5/5] mm: Make mk_pte() definition unconditional Matthew Wilcox (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814154427.162475-5-willy@infradead.org \
--to=willy@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox