From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2DAFC3DA4A for ; Wed, 14 Aug 2024 21:52:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47E346B00A8; Wed, 14 Aug 2024 17:52:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FE616B00A9; Wed, 14 Aug 2024 17:52:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 278AD6B00AA; Wed, 14 Aug 2024 17:52:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 039766B00A8 for ; Wed, 14 Aug 2024 17:52:01 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id ABFE0C0BB8 for ; Wed, 14 Aug 2024 21:52:01 +0000 (UTC) X-FDA: 82452199242.18.C74E737 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf26.hostedemail.com (Postfix) with ESMTP id 888B2140003 for ; Wed, 14 Aug 2024 21:51:59 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0y8VBtic; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723672263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kbjet2LGQJMbZleuVS2K78QqS/SNuicMsRmcAiKdlNQ=; b=P9b7PWnRrGqCJt5ucgU9IybQn6Uw70wFQ/kA+QXxqT3legi5JV/3tQxErXGWg5rG1/5ot5 zGUagnvNtnTIzSN2z0tC3NZyOFEyS+mXcewUS/lvWxC3y8z7++yO27KoyoFRez84t3vc0+ oo+SXkPQhEC1Cw8LnZBb/+GY5uFNJL4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0y8VBtic; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723672263; a=rsa-sha256; cv=none; b=5U7l35kH3pzSQdkXNf60cjzO9bCXsws1vjQW7G/DuErvH4rX3ul8fjMASlJEoPkwdTc/a+ pBWwUvNKU0qpPa6ouvYCavf9vKNQ4Ffm/8no78FHZoeh2H/89SbMIyKf/nP9dRde9PXbiF nQHNYa3f0SLHGTVMmAxMawfENocWCr4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1AAD5CE1AB9; Wed, 14 Aug 2024 21:51:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2008C116B1; Wed, 14 Aug 2024 21:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1723672315; bh=dI01er8IFqXD5BvIIMx9CMLT0DoCZp+kNEXLxRPDkoc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0y8VBticqDxqdRo/0oSBNhmj4OrRb4zsNA/YMJo1tc2mdzgAWZ43IynMIyFTcB1Oo /hK5xY0L+T7E5mQE5hLYC220TEl0SX7QOK1ATnWpicPbsW9WyuwEBDfhDfAPns01LN mUZ+/EvLfyTwk6eiIc5p1VaCbWhA3kU1x1F+e4NY= Date: Wed, 14 Aug 2024 14:51:54 -0700 From: Andrew Morton To: "T.J. Mercier" Cc: Shakeel Butt , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org Subject: Re: [PATCH 3/4] memcg: initiate deprecation of oom_control Message-Id: <20240814145154.a115a1642137b71df0650cae@linux-foundation.org> In-Reply-To: References: <20240814202825.2694077-1-shakeel.butt@linux.dev> <20240814202825.2694077-4-shakeel.butt@linux.dev> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: gmkmckkn4uq7m1qxnpgmkwqicrx73crg X-Rspam-User: X-Rspamd-Queue-Id: 888B2140003 X-Rspamd-Server: rspam02 X-HE-Tag: 1723672319-605376 X-HE-Meta: U2FsdGVkX19g1JIbFN8ePUFA75EiR5xFor+EziFBquTFPTEXHzWP3WWHcQAVTkRW8VOcOn6YaySyidv6nkPzAjBf5vkgfXQhpDFbSmNqP8d8ue1JBXgZQb9NnZwQcde4Vk5xgMkbS914vbIlKRq6KR3vRirPS31yUIfZQmJVzoECW8LKuame3eoBjpVzc+atxeP8QSJocah95H1KbyfhNtSpwiVsnv+4uSxtl09VtyUhDPQOr0qVzoYwGdW+GCMAWpPgEJqmYubMkYLGTRKXpK1/QDV07wRXAbCrBRDlxvy1cYwU+sNdw96TNRgs+J7McPnU73yHO+ul/rQeclNY9nuOrrvG5oQ0u943558DAA9Ytf7r6AVHSDdbJ69HQ84PT1r0xHPzgnkCP4tmvZ2UrKb/4Vq1kN9R4NmqKRgQno6DBvNJsAAnpFKMMmH1CpYxZyAJt5VLh5pvGegrhuUhRx249f5t+ZMcjNmr2w2ggcwSNUFeE9nHS+IGvk3xYwif8VNTGl/Y4qGQoL4hVGymVnAzh+H4WvuLjvmnxGIddp2NPno/xNM07j9cx/aQnKiVLk7OHZOwKLDea7zKLptVR+qzqET4ZdIPISfIZm+My9f6XRCqHJzh4YP4KhIF43NWZHKE+HapPJh960Gr81BnN8Mg5CSiiS9iDdnOfKOrIGZQL6qRNjRaMctEycg835gGgrL3NeTZiMT9w1MwHQ5k6TYky74xQlR7GdZWiGW7tDRgpQw2Eai1QR5YRuwCC1cq0K+wI+lP+J7/iMQcNo8KQkRIaotLaYIdl7VCUZpn7CpBDKQ3b7DCiaXpgsH4+Z35PkgDdqTtmkr8Wzc0Mnd9W/LrC1cERLUxoj0EdE/7Tgfv5yGMaUXBWfkKz3yfootoxi9Busm/MN6MPlm2nDa924ZdyZui5M1xsA2L/1gwZe4+VnDZ0YgCJ5s+Qg7HVX/XQkIn8q0u6eII/NSSUcC b6hRMQUz YwaIi+PbozsM26RYmKV8JZ3FCJrqWIERPp/m4onjz2gDfFA7qMIt9zmDNCgrqofpdFkcrs1lxH0GDLzwJXGRVLroam8Mhwj4opwa6B8xs/C35crO+O9lqoyPAkSdiU234OeDFNED0JNgu4xq9cXLy2PkDofCB1+N2gjU67BY1eYacTjcSRXE+Bbu9KNKg4pc7H5RJ0xF1OaLhf3s6yvqM0WtzbWXcibmCCZxTv37q2K/mVXorCMtbVEr19Vvx0SfjxGUfNOKeszDXf7OELY1tj2gCl19DnPYuxmRZ8vvz1o37OIQL68CjEc6ugHINej5HVdiihAZ/qardbkoAmFMqzeOUMupjKGtYawVIxss2MQ1iU2Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 14 Aug 2024 14:00:03 -0700 "T.J. Mercier" wrote: > > --- a/mm/memcontrol-v1.c > > +++ b/mm/memcontrol-v1.c > > @@ -1907,6 +1907,9 @@ static ssize_t memcg_write_event_control(struct kernfs_open_file *of, > > event->register_event = mem_cgroup_usage_register_event; > > event->unregister_event = mem_cgroup_usage_unregister_event; > > } else if (!strcmp(name, "memory.oom_control")) { > > + pr_warn_once("oom_control is deprecated and will be removed. " > > + "Please report your usecase to linux-mm-@kvack.org" > > + " if you depend on this functionality. \n"; > > Missing close paren? err yes, thanks. V2, please ;)