linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "T.J. Mercier" <tjmercier@google.com>
Cc: Shakeel Butt <shakeel.butt@linux.dev>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Muchun Song <muchun.song@linux.dev>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Meta kernel team <kernel-team@meta.com>,
	cgroups@vger.kernel.org
Subject: Re: [PATCH 3/4] memcg: initiate deprecation of oom_control
Date: Wed, 14 Aug 2024 14:51:54 -0700	[thread overview]
Message-ID: <20240814145154.a115a1642137b71df0650cae@linux-foundation.org> (raw)
In-Reply-To: <CABdmKX2HvW3qZ9zrTq0Gz6q0Gg7_XubVY22o3GJoTOhQg=V+8Q@mail.gmail.com>

On Wed, 14 Aug 2024 14:00:03 -0700 "T.J. Mercier" <tjmercier@google.com> wrote:

> > --- a/mm/memcontrol-v1.c
> > +++ b/mm/memcontrol-v1.c
> > @@ -1907,6 +1907,9 @@ static ssize_t memcg_write_event_control(struct kernfs_open_file *of,
> >                 event->register_event = mem_cgroup_usage_register_event;
> >                 event->unregister_event = mem_cgroup_usage_unregister_event;
> >         } else if (!strcmp(name, "memory.oom_control")) {
> > +               pr_warn_once("oom_control is deprecated and will be removed. "
> > +                            "Please report your usecase to linux-mm-@kvack.org"
> > +                            " if you depend on this functionality. \n";
> 
> Missing close paren?

err yes, thanks.

V2, please ;)


  parent reply	other threads:[~2024-08-14 21:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14 20:28 [PATCH 0/4] memcg: initiate deprecation of v1 features Shakeel Butt
2024-08-14 20:28 ` [PATCH 1/4] memcg: initiate deprecation of v1 tcp accounting Shakeel Butt
2024-08-14 20:59   ` T.J. Mercier
2024-08-14 21:42     ` Shakeel Butt
2024-08-14 20:28 ` [PATCH 2/4] memcg: initiate deprecation of v1 soft limit Shakeel Butt
2024-08-14 20:28 ` [PATCH 3/4] memcg: initiate deprecation of oom_control Shakeel Butt
2024-08-14 21:00   ` T.J. Mercier
2024-08-14 21:41     ` Shakeel Butt
2024-08-14 21:49       ` Shakeel Butt
2024-08-14 21:51     ` Andrew Morton [this message]
2024-08-14 20:28 ` [PATCH 4/4] memcg: initiate deprecation of pressure_level Shakeel Butt
2024-08-14 21:01   ` T.J. Mercier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240814145154.a115a1642137b71df0650cae@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=tjmercier@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox