From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF7BC3DA4A for ; Wed, 14 Aug 2024 21:27:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 155046B00AE; Wed, 14 Aug 2024 17:27:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1080A6B00B0; Wed, 14 Aug 2024 17:27:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0FB06B00B2; Wed, 14 Aug 2024 17:27:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CCCB06B00AE for ; Wed, 14 Aug 2024 17:27:52 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 82C85A8688 for ; Wed, 14 Aug 2024 21:27:52 +0000 (UTC) X-FDA: 82452138384.29.A24CF3B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf11.hostedemail.com (Postfix) with ESMTP id 2D56240020 for ; Wed, 14 Aug 2024 21:27:48 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KJNUTFpm; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723670834; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=POR1Ut9suvyfL+5+Ls+w+qfoNYetgKEdY4cjtnpO6QE=; b=aFlttb/tDJJH73ZO84PEIW6k3ynzCi/unSW26+IFvsURtKKywkrDjRSfG+UnuyXqip9tbC /t2+lHd0e5/Kp9py6qsCI8hIbUgtXHGIMmcjxyIM252H/xizsY2P+soV1P5pesnGkbl8Q/ Ao9W5LZ97Ma3ybK384+5+HnBlrRn3G8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KJNUTFpm; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723670834; a=rsa-sha256; cv=none; b=c79ymWgN4CxLU3uc0WDJOBD3pZNRLZQhxLiSaTKauN3apNkQHbsCRdRpCz+D7WnMmlqTZ7 ROL3RLscipHX5126wZwnEP5DK6iO/P2N14fjWETWBfpYTLqnBZLddfOyF1RXzif6T7gvCX 6gAUPByfxbjHdd5ocyopleTez7m+M9A= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2A2ECCE1698; Wed, 14 Aug 2024 21:27:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41D1DC116B1; Wed, 14 Aug 2024 21:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1723670864; bh=tSHRw7nbaq8pZSzLIRmR6HgytwCBnaIa5ivF3FO3EHY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KJNUTFpmADLv6geBpz336zrVmArJWWS1kGsYFboYRm5tsSLHJA0N8kt1YJWfFVbX1 ut1D919hxIk47GYLHgKc/A75dgz2YZ0FjHtlX2UQ0gT1DDdNl2AUYkwrgLzLS5oDno XYOPgdQPN1zKjHcUz8IRGROzVG3zeSurEKb8roKk= Date: Wed, 14 Aug 2024 14:27:43 -0700 From: Andrew Morton To: liuye Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmscan: Fix hard LOCKUP in function isolate_lru_folios Message-Id: <20240814142743.c8227d72be4c5fd9777a4717@linux-foundation.org> In-Reply-To: <20240814091825.27262-1-liuye@kylinos.cn> References: <20240814091825.27262-1-liuye@kylinos.cn> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 2D56240020 X-Stat-Signature: x74j1mabt7ezoiz4ffhqbp6sz5d37qgu X-HE-Tag: 1723670868-497859 X-HE-Meta: U2FsdGVkX1/sxFCxf5qQFloC5z3x+kBIQxW8Zyhmx0Wc0FVMslSIlE0zlunEO0PGKIJmG59fkv59uZA6OEtYBVcTLaJRsK3viVheQ0Q6vxfnlRbugsEnU007KDyMvgB97ccgPTdY9z3Vu2/Jj6QGkY1WioY+0k2yHLU9Fm59N9fXiv2aNr3Fvz4WNTklrBSqH6qId+HagKEXyIDSm+aWgWfpeRQuZOdpLKCVaNIsBFtQgqu68+fLFhsox+o02rRDjfZ9fD35jo2N5IhDkljfArbYgUTWvk7OGFuWrlR79pPNgwaN57kgN10iCjNR1LYALmRVOPJA5EUWHP5DP3RqCdgJ7/uDfookse5PJnGzHs3OcMoZx4KKG9Kz4Ees60Hp67U9Cn7AsFyZ/StizBQhUNhc+nNIPJ+By4m/go/9/OUt9+/AZCLQ406aYPsiIZeZEXebf2ok3xEJ82v1DwJvX+GZoSYOkjLsy6vIko5TULxJcgNI136WdXnkgxsI2xGGenREUp+euhU+rY5KMREKw+0wrdhnA9O5yERxX6m8bpUlRusf8YuCnlMedLtqdCb/jg09xMKruz71wfzKhsnSoCpgadaN09mkH3sD3G6srImS/3a3QbOnQLZOQ7rjAUtY+1swNBa1boJWSjMTEBN/hN8t5DZnM42GtNDYATddsLhY2nDNX9NVTDr8yAfCnM4flNQpzGixFQ46S7ASEQroyStzc6epD4EAeRQz44aUGDg05M6t69aggOmbaBshOo+GmbvReRcU/4r5oWu3kItZ20s5KujNMdpcns/tD+aYg7jkX1KOah56q6/v/z0WbiVtTDs6WEJQL08xCe49colsj9sKdzr8MfQ7/1YFGwGWk5JTuNFUNAiRXRm3mzkSr+Uzvithm0ZA9R/1B4p4KWKaba3AyrXP6o0zMjb8eRev9Gf2hn0gXrz97lRjrPhk1gH8U2PI5Ew9BOa3jBwTP85 yffpTuzP o2QguxGeDxKFdFeCFE4BdegQZM8yFOmwH2OnZDgw3z3BjdwIRyd9dP9bDKU3l8WdXaaKlNroyY8sxS+siqxduwKMf4JyWATJieojjrwNEsL+/N18+bYXhs5msbn7jZvybyQr8X4yfERjczOdyVsS1GoUVCiocFvDmqE3OPGKs2fGUCmdIVoNCAVdpHlLE2XIGx8uEGLBXy5H/bJ3hxw/odz4QHCcs+MDCV9hHVtMSbdUVP7+fAmm6sVdjYXFXDy+nLvDLQ9cdcCTV6/IzgLwy14Jw86le+bvEwzQvfZvptUhYvmo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 14 Aug 2024 17:18:25 +0800 liuye wrote: > This fixes the following hard lockup in function isolate_lru_folios > when memory reclaim.If the LRU mostly contains ineligible folios > May trigger watchdog. > > watchdog: Watchdog detected hard LOCKUP on cpu 173 > RIP: 0010:native_queued_spin_lock_slowpath+0x255/0x2a0 > Call Trace: > _raw_spin_lock_irqsave+0x31/0x40 > folio_lruvec_lock_irqsave+0x5f/0x90 > folio_batch_move_lru+0x91/0x150 > lru_add_drain_per_cpu+0x1c/0x40 > process_one_work+0x17d/0x350 > worker_thread+0x27b/0x3a0 > kthread+0xe8/0x120 > ret_from_fork+0x34/0x50 > ret_from_fork_asm+0x1b/0x30 > > lruvec->lru_lock owner： > > PID: 2865 TASK: ffff888139214d40 CPU: 40 COMMAND: "kswapd0" > #0 [fffffe0000945e60] crash_nmi_callback at ffffffffa567a555 > #1 [fffffe0000945e68] nmi_handle at ffffffffa563b171 > #2 [fffffe0000945eb0] default_do_nmi at ffffffffa6575920 > #3 [fffffe0000945ed0] exc_nmi at ffffffffa6575af4 > #4 [fffffe0000945ef0] end_repeat_nmi at ffffffffa6601dde > [exception RIP: isolate_lru_folios+403] > RIP: ffffffffa597df53 RSP: ffffc90006fb7c28 RFLAGS: 00000002 > RAX: 0000000000000001 RBX: ffffc90006fb7c60 RCX: ffffea04a2196f88 > RDX: ffffc90006fb7c60 RSI: ffffc90006fb7c60 RDI: ffffea04a2197048 > RBP: ffff88812cbd3010 R8: ffffea04a2197008 R9: 0000000000000001 > R10: 0000000000000000 R11: 0000000000000001 R12: ffffea04a2197008 > R13: ffffea04a2197048 R14: ffffc90006fb7de8 R15: 0000000003e3e937 > ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018 > > #5 [ffffc90006fb7c28] isolate_lru_folios at ffffffffa597df53 > #6 [ffffc90006fb7cf8] shrink_active_list at ffffffffa597f788 > #7 [ffffc90006fb7da8] balance_pgdat at ffffffffa5986db0 > #8 [ffffc90006fb7ec0] kswapd at ffffffffa5987354 > #9 [ffffc90006fb7ef8] kthread at ffffffffa5748238 > crash> Well that's bad. > Fixes: b2e18757f2c9 ("mm, vmscan: begin reclaiming pages on a per-node basis") Merged in 2016. Can you please describe how to reproduce this? Under what circumstances does it occur? Why do you think it took eight years to be discovered? > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1655,6 +1655,7 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan, > unsigned long nr_skipped[MAX_NR_ZONES] = { 0, }; > unsigned long skipped = 0; > unsigned long scan, total_scan, nr_pages; > + unsigned long max_nr_skipped = 0; > LIST_HEAD(folios_skipped); > > total_scan = 0; > @@ -1669,10 +1670,12 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan, > nr_pages = folio_nr_pages(folio); > total_scan += nr_pages; > > - if (folio_zonenum(folio) > sc->reclaim_idx || > - skip_cma(folio, sc)) { > + /* Using max_nr_skipped to prevent hard LOCKUP*/ > + if ((max_nr_skipped < SWAP_CLUSTER_MAX_SKIPPED) && > + (folio_zonenum(folio) > sc->reclaim_idx || skip_cma(folio, sc))) { > nr_skipped[folio_zonenum(folio)] += nr_pages; > move_to = &folios_skipped; > + max_nr_skipped++; > goto move; > } It looks like that will fix, but perhaps something more fundamental needs to be done - we're doing a tremendous amount of pretty pointless work here. Answers to my above questions will help us resolve this. Thanks.