From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71AE2C52D7F for ; Wed, 14 Aug 2024 21:16:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F30F36B00B7; Wed, 14 Aug 2024 17:16:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE3766B00B8; Wed, 14 Aug 2024 17:16:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D80CE6B00BA; Wed, 14 Aug 2024 17:16:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B94ED6B00B7 for ; Wed, 14 Aug 2024 17:16:22 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3CB6C1C4CE5 for ; Wed, 14 Aug 2024 21:16:22 +0000 (UTC) X-FDA: 82452109404.12.B31914E Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf29.hostedemail.com (Postfix) with ESMTP id 19440120010 for ; Wed, 14 Aug 2024 21:16:19 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=jUtCI6LB; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723670109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qrYlpcYGYs5ldkXTN1CZN6BZddVn4S8mgAiP8yNQiMI=; b=vN7E3ZWkJ6UZdf4A0K/NEkNgtr+ehsarLjFlmXNS0UOdTRV/iDg5mihQTUrevlB+Gban5R aSK7PZfcjgl6vOajRGsk7in5+wmZ7n2nRn4FXPRVqw5BHPml+2Ma7REqs+wvprnxgS4EFG e3Eoe2VuMmTy88lWBeqvfx/auCQwKnU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723670109; a=rsa-sha256; cv=none; b=RNj21NKyAHYqeTZnYpT5iEC7qjNLNK55DHVgPdG0Sf1ekciJtFoPxS2MnlHbYhowbOc/dJ LXyl5QkrzC/YrMtg+saspHbGZ8RFGBUC1ynSdeW0RTaCsC40ntgr6w683VDINo05K/YoDl oZQHQLsk+Jz7pMttE4ny5eK7bOfyrlI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=jUtCI6LB; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 679F3CE0B74; Wed, 14 Aug 2024 21:16:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62AB6C116B1; Wed, 14 Aug 2024 21:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1723670175; bh=arcrQUXCs+GsDc20YERmB/02EaM59ZtcKl2ujmgBtDA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jUtCI6LBRlGakJIwoFUmJz4H/qsFz4MJ1w/EA6jDmvr54VcgFsxIegdnPMVpSfZWd CEoitFafRq8YN4a//6HU96MTJGY8k9g2gQ0bIOcC9ZCJWwrEqx+wIOTdXCHsdr82MG Vm1cAAvQ035+KWqdZJLg6it4j23r1VuEgAlzQ0rk= Date: Wed, 14 Aug 2024 14:16:14 -0700 From: Andrew Morton To: Mateusz Guzik Cc: npiggin@gmail.com, david@redhat.com, willy@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: whack now bogus comment in pmd_install() concerning a fence Message-Id: <20240814141614.56337d7cd3f0671d8edc7676@linux-foundation.org> In-Reply-To: <20240814145256.1683498-1-mjguzik@gmail.com> References: <20240814145256.1683498-1-mjguzik@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 19440120010 X-Stat-Signature: ydjky813qx4d1nxxxdrtu8yxh8ks8j4k X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723670179-567340 X-HE-Meta: U2FsdGVkX1+tb0O21YyPoWxGIGOhY62NyKQVvluw0nFgVTUEPsYE+80Yq24l4Q4LY14ZgQ9H8PcY5Sg3HkU450YhulXGpmc5FC7b2n0m/yVsNAxZ/WNISMD5V8jUnkb1t7PHWnrHmJXfO/0vRgY6+clERUujtS6H/iQoRoQoUN66CgRJSvBtMZ4flYs/622dJJsPrWnlTznC5FRNgNv+jVl8f3o9sniwjbXuSyrA/GhnDmW+s/bykSQpnRFjUS8cvfM+Mwjnh9VoUFna6cuOxulNNlOCkLN8H7W1IuMQAWTsR3Q67S+SWZy3g8LFZWsbAD/Ehyhs9vAfKTM4koOvusM6Nr8PYv7XfZb/0f0bW1LQC+4OQOMpdvGzV7LeEmKUKTaAn09NzomHNh81JwQ4XC77vh5TSx+uhiuFqYGrpUJAgwGb3xomqNCIyAcSrkSPtVRaaSVjXFyVxLuql7xTiyXnckG5cMS2awLPBYABU2dWbRvQsBfgOc6UusMfj/Dn+ThUaACbpBPXohakmpf/WNcnbvjuGfcOcFMyBx5SNpu6KcpBbGBBeSSfSPc5M139NBJSSqLTBdyOqV51WGyRUUX6Gi1X6+1XazaDp99+Df+d+a4Qq75DcKAGMB+uOtjAm4PVZzRRkoJ/4i895oKRINcZvbQ1rbqpehAkD5izoJpn/kbrU2HLl/kkG1vCXVpG606m2UvvX9DWya/8n08X573ujPNRGKQQZqJEbkbDpdGgbbqPOU9zdj5y1EY/a8LC+Bsy1jyqzuShL6wurNTqgmMfvivC0cSrKu04gbOEFRDNesCaoLsPHedEGM4zzgOi21Agbj7l0qwKwFhU0rtFd8aBIbjBwCxRSgAJZhJOp3573aG2VlWKR9lobGU2OI+ElPr7PX8+MnHDhBimPWXiMt6AOJY7XS1Q79mF9HrEVQbGdnpmA03LCxn2FNAp1F00UbQ0s4SgkcTtPaYQI93 T3dYysHF /6H4r2OxSSb4bFxMyrMC5hJgZhn2YXuwnPRNNlFquI2JfiM7587iL15YAKe6qp4Qc9o3I/RgyiIbru2jJH4YBm5Ljtqv7GwwRvhgA3ulUSZgNwGj2rqd5zPwE+LVkLu8bDSJHLXFdnRrYNNWhzONZa8TpUdvgzSN1GPakPUfQ/2tTgiSjeFoYcjNPVWg81NBKpVADit/gmar5yrELzHzdTueuc8UuILel2xKwUe8sdtNLe04ci4qv34EINKwvysW+AyEeOexKqYnpsu/eVD7ch+hIdxIZxvro/gmQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 14 Aug 2024 16:52:56 +0200 Mateusz Guzik wrote: > Commit 362a61ad6119 ("fix SMP data race in pagetable setup vs walking") > added the following: > > + smp_wmb(); /* Could be smp_wmb__xxx(before|after)_spin_lock */ > + > spin_lock(&mm->page_table_lock); > > However, over the years the fence along with the comment got moved > around the file, eventually landing in a spot where it is *NOT* followed > by a lock acquire (or any other operation which might happen to provide > any fence on a given arch), rendering the comment stale. > > ... > > I fully concede I could not be arsed to check if the fence is still > needed to begin with, I ran into this while looking at something else. > The comment puzzled me for a minute suggesting pmd_populate has an > immediate lock acquire inside. > > ... > > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -436,7 +436,7 @@ void pmd_install(struct mm_struct *mm, pmd_t *pmd, pgtable_t *pte) > * seen in-order. See the alpha page table accessors for the > * smp_rmb() barriers in page table walking code. > */ > - smp_wmb(); /* Could be smp_wmb__xxx(before|after)_spin_lock */ > + smp_wmb(); > pmd_populate(mm, pmd, *pte); > *pte = NULL; > } It's best to document all such barriers, so the preferred patch would be to fix the comment rather than removing it. And if the barrier now does nothing then of course removing the thing would be best. So I'd suggest that the wrong comment be left there, if only to tell developers why the barrier used to be there!